From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, Hannes Reinecke <hare@suse.com>,
Michael Tsirkin <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH 6/6] virtio-blk: modernize sysfs attribute creation
Date: Mon, 30 Jul 2018 11:03:25 +0200 [thread overview]
Message-ID: <20180730090325.GF12038@lst.de> (raw)
In-Reply-To: <20180730071227.22887-7-hare@suse.de>
On Mon, Jul 30, 2018 at 09:12:27AM +0200, Hannes Reinecke wrote:
> Use new-style DEVICE_ATTR_RO/DEVICE_ATTR_RW to create the sysfs attributes
> and register the disk with default sysfs attribute groups.
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> Cc: Michael Tsirkin <mst@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-07-30 9:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 7:12 [PATCH 0/6] genhd: register default groups with device_add_disk() Hannes Reinecke
2018-07-30 7:12 ` [PATCH 1/6] genhd: drop 'bool' argument from __device_add_disk() Hannes Reinecke
2018-07-30 8:56 ` Christoph Hellwig
2018-07-30 8:57 ` Hannes Reinecke
2018-08-13 19:53 ` Bart Van Assche
2018-07-30 7:12 ` [PATCH 2/6] block: genhd: add 'groups' argument to device_add_disk Hannes Reinecke
2018-07-30 8:57 ` Christoph Hellwig
2018-07-30 7:12 ` [PATCH 3/6] nvme: register ns_id attributes as default sysfs groups Hannes Reinecke
2018-07-30 8:59 ` Christoph Hellwig
2018-08-13 19:51 ` Bart Van Assche
2018-08-14 6:19 ` Hannes Reinecke
2018-07-30 7:12 ` [PATCH 4/6] aoe: use device_add_disk_with_groups() Hannes Reinecke
2018-07-30 9:01 ` Christoph Hellwig
2018-08-01 1:00 ` Ed Cashin
2018-08-01 6:57 ` Hannes Reinecke
2018-08-02 11:55 ` Ed Cashin
2018-07-30 7:12 ` [PATCH 5/6] zram: register default groups with device_add_disk() Hannes Reinecke
2018-07-30 9:02 ` Christoph Hellwig
2018-07-30 7:12 ` [PATCH 6/6] virtio-blk: modernize sysfs attribute creation Hannes Reinecke
2018-07-30 9:03 ` Christoph Hellwig [this message]
2018-07-31 15:11 ` Michael S. Tsirkin
2018-07-31 15:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730090325.GF12038@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=jasowang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox