From: Jens Axboe <axboe@kernel.dk>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: Do not reread partition table on exclusively open device
Date: Wed, 30 Nov 2022 15:52:41 -0700 [thread overview]
Message-ID: <0afd657e-ccce-5cbb-dd26-c2c07e2f59d8@kernel.dk> (raw)
In-Reply-To: <20221130175653.24299-1-jack@suse.cz>
On 11/30/22 10:56 AM, Jan Kara wrote:
> Since commit 10c70d95c0f2 ("block: remove the bd_openers checks in
> blk_drop_partitions") we allow rereading of partition table although
> there are users of the block device. This has an undesirable consequence
> that e.g. if sda and sdb are assembled to a RAID1 device md0 with
> partitions, BLKRRPART ioctl on sda will rescan partition table and
> create sda1 device. This partition device under a raid device confuses
> some programs (such as libstorage-ng used for initial partitioning for
> distribution installation) leading to failures.
>
> Fix the problem refusing to rescan partitions if there is another user
> that has the block device exclusively open.
This looks nice and clean to me. Was pondering whether to queue this up
for 6.1, but it's old enough that I think we should just funnel it through
6.2 and mark it stable.
--
Jens Axboe
next prev parent reply other threads:[~2022-11-30 22:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 17:56 [PATCH] block: Do not reread partition table on exclusively open device Jan Kara
2022-11-30 22:52 ` Jens Axboe [this message]
2022-11-30 22:54 ` Jens Axboe
2022-12-01 7:10 ` Christoph Hellwig
2022-12-01 11:44 ` Jan Kara
2023-01-31 14:00 ` Yu Kuai
2023-01-31 14:15 ` Christoph Hellwig
2023-02-01 1:04 ` Yu Kuai
2023-02-01 6:22 ` Christoph Hellwig
2023-02-01 7:20 ` Yu Kuai
2023-02-06 3:24 ` Yu Kuai
2023-02-08 12:02 ` Jan Kara
2023-02-08 14:13 ` Yu Kuai
2023-02-09 9:04 ` Jan Kara
2023-02-09 9:32 ` Yu Kuai
2023-02-09 9:57 ` Jan Kara
2023-02-09 11:19 ` Yu Kuai
2023-02-09 13:58 ` Jan Kara
2023-02-10 1:58 ` Yu Kuai
2023-02-10 10:31 ` Jan Kara
2023-02-11 3:46 ` Yu Kuai
2023-02-02 12:50 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0afd657e-ccce-5cbb-dd26-c2c07e2f59d8@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox