From: Christoph Hellwig <hch@infradead.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH] block: Do not reread partition table on exclusively open device
Date: Tue, 31 Jan 2023 22:22:22 -0800 [thread overview]
Message-ID: <Y9oFHssFz2obv83W@infradead.org> (raw)
In-Reply-To: <92d53d6b-f83d-0767-4f6a-1b897b33b227@huaweicloud.com>
On Wed, Feb 01, 2023 at 09:04:12AM +0800, Yu Kuai wrote:
> > + if (test_bit(GD_NEED_PART_SCAN, &disk->state) && !bdev->bd_holder)
> > bdev_disk_changed(disk, false);
>
> I think this is wrong here... We should at least allow the exclusively
> opener to scan partition, right?
bd_holder is only set in bd_finish_claiming, which is called after
the partition rescan.
next prev parent reply other threads:[~2023-02-01 6:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 17:56 [PATCH] block: Do not reread partition table on exclusively open device Jan Kara
2022-11-30 22:52 ` Jens Axboe
2022-11-30 22:54 ` Jens Axboe
2022-12-01 7:10 ` Christoph Hellwig
2022-12-01 11:44 ` Jan Kara
2023-01-31 14:00 ` Yu Kuai
2023-01-31 14:15 ` Christoph Hellwig
2023-02-01 1:04 ` Yu Kuai
2023-02-01 6:22 ` Christoph Hellwig [this message]
2023-02-01 7:20 ` Yu Kuai
2023-02-06 3:24 ` Yu Kuai
2023-02-08 12:02 ` Jan Kara
2023-02-08 14:13 ` Yu Kuai
2023-02-09 9:04 ` Jan Kara
2023-02-09 9:32 ` Yu Kuai
2023-02-09 9:57 ` Jan Kara
2023-02-09 11:19 ` Yu Kuai
2023-02-09 13:58 ` Jan Kara
2023-02-10 1:58 ` Yu Kuai
2023-02-10 10:31 ` Jan Kara
2023-02-11 3:46 ` Yu Kuai
2023-02-02 12:50 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9oFHssFz2obv83W@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox