From: Jan Kara <jack@suse.cz>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH] block: Do not reread partition table on exclusively open device
Date: Fri, 10 Feb 2023 11:31:17 +0100 [thread overview]
Message-ID: <20230210103117.hpmeqz6373smvchd@quack3> (raw)
In-Reply-To: <668bc362-263d-d9bc-a462-d8b851062ebc@huaweicloud.com>
On Fri 10-02-23 09:58:36, Yu Kuai wrote:
> Hi,
>
> 在 2023/02/09 21:58, Jan Kara 写道:
>
> > Sorry, I'm not sure what your are asking about here :) Can you please
> > elaborate more?
>
>
> It's another artificail race that will cause part scan fail in
> device_add_disk().
>
> bdev_add() -> user can open the device now
>
> disk_scan_partitions -> will fail is the device is already opened
> exclusively
>
> I'm thinking about set disk state before bdev_add()...
Oh, right. Yes, that should be a good fix to set GD_NEED_PART_SCAN before
calling bdev_add().
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2023-02-10 10:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 17:56 [PATCH] block: Do not reread partition table on exclusively open device Jan Kara
2022-11-30 22:52 ` Jens Axboe
2022-11-30 22:54 ` Jens Axboe
2022-12-01 7:10 ` Christoph Hellwig
2022-12-01 11:44 ` Jan Kara
2023-01-31 14:00 ` Yu Kuai
2023-01-31 14:15 ` Christoph Hellwig
2023-02-01 1:04 ` Yu Kuai
2023-02-01 6:22 ` Christoph Hellwig
2023-02-01 7:20 ` Yu Kuai
2023-02-06 3:24 ` Yu Kuai
2023-02-08 12:02 ` Jan Kara
2023-02-08 14:13 ` Yu Kuai
2023-02-09 9:04 ` Jan Kara
2023-02-09 9:32 ` Yu Kuai
2023-02-09 9:57 ` Jan Kara
2023-02-09 11:19 ` Yu Kuai
2023-02-09 13:58 ` Jan Kara
2023-02-10 1:58 ` Yu Kuai
2023-02-10 10:31 ` Jan Kara [this message]
2023-02-11 3:46 ` Yu Kuai
2023-02-02 12:50 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230210103117.hpmeqz6373smvchd@quack3 \
--to=jack@suse.cz \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox