Linux block layer
 help / color / mirror / Atom feed
* [PATCH] lib/crc64.c: add MODULE_LICENSE("GPL")
@ 2018-05-22  8:40 Coly Li
  2018-05-22  8:43 ` Andy Shevchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Coly Li @ 2018-05-22  8:40 UTC (permalink / raw)
  To: linux-bcache; +Cc: linux-block, Coly Li, Andy Shevchenko

This patch adds MODULE_LICENSE("GPL") to lib/crc64.c to remove a compiling
warninng.

Signed-off-by: Coly Li <colyli@suse.de>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 lib/crc64.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/crc64.c b/lib/crc64.c
index ed0ffac7b26a..586e46684ee8 100644
--- a/lib/crc64.c
+++ b/lib/crc64.c
@@ -135,3 +135,4 @@ uint64_t crc64(const void *data, size_t len)
 EXPORT_SYMBOL_GPL(crc64);
 
 MODULE_DESCRIPTION("CRC64 calculations");
+MODULE_LICENSE("GPL");
-- 
2.16.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] lib/crc64.c: add MODULE_LICENSE("GPL")
  2018-05-22  8:40 [PATCH] lib/crc64.c: add MODULE_LICENSE("GPL") Coly Li
@ 2018-05-22  8:43 ` Andy Shevchenko
  2018-05-22  8:47   ` Coly Li
  0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2018-05-22  8:43 UTC (permalink / raw)
  To: Coly Li, linux-bcache; +Cc: linux-block

On Tue, 2018-05-22 at 16:40 +0800, Coly Li wrote:
> This patch adds MODULE_LICENSE("GPL") to lib/crc64.c to remove a
> compiling
> warninng.

I have no opinion about this. Code has a top description from which it
has been taken / derived, so, I dunno if GPL is what it really is.

In any case it's probably worth to add SPDX header as well. 

> 
> Signed-off-by: Coly Li <colyli@suse.de>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  lib/crc64.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/crc64.c b/lib/crc64.c
> index ed0ffac7b26a..586e46684ee8 100644
> --- a/lib/crc64.c
> +++ b/lib/crc64.c
> @@ -135,3 +135,4 @@ uint64_t crc64(const void *data, size_t len)
>  EXPORT_SYMBOL_GPL(crc64);
>  
>  MODULE_DESCRIPTION("CRC64 calculations");
> +MODULE_LICENSE("GPL");

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] lib/crc64.c: add MODULE_LICENSE("GPL")
  2018-05-22  8:43 ` Andy Shevchenko
@ 2018-05-22  8:47   ` Coly Li
  0 siblings, 0 replies; 3+ messages in thread
From: Coly Li @ 2018-05-22  8:47 UTC (permalink / raw)
  To: Andy Shevchenko, linux-bcache; +Cc: linux-block

On 2018/5/22 4:43 PM, Andy Shevchenko wrote:
> On Tue, 2018-05-22 at 16:40 +0800, Coly Li wrote:
>> This patch adds MODULE_LICENSE("GPL") to lib/crc64.c to remove a
>> compiling
>> warninng.
> 
> I have no opinion about this. Code has a top description from which it
> has been taken / derived, so, I dunno if GPL is what it really is.
> 
> In any case it's probably worth to add SPDX header as well. 
> 

Hmm, there is a warning complains no MODULE_LICENSE() in lib/crc64.c,
when I compile a kernel for testing. The purpose is just to kill a
compiler warning.

And sure, I will post an update version with SPDX header.

Thanks for the hint :-)

Coly Li

>>
>> Signed-off-by: Coly Li <colyli@suse.de>
>> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>>  lib/crc64.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/crc64.c b/lib/crc64.c
>> index ed0ffac7b26a..586e46684ee8 100644
>> --- a/lib/crc64.c
>> +++ b/lib/crc64.c
>> @@ -135,3 +135,4 @@ uint64_t crc64(const void *data, size_t len)
>>  EXPORT_SYMBOL_GPL(crc64);
>>  
>>  MODULE_DESCRIPTION("CRC64 calculations");
>> +MODULE_LICENSE("GPL");
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-22  8:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-22  8:40 [PATCH] lib/crc64.c: add MODULE_LICENSE("GPL") Coly Li
2018-05-22  8:43 ` Andy Shevchenko
2018-05-22  8:47   ` Coly Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox