public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>, Keith Busch <keith.busch@intel.com>
Cc: Bart Van Assche <bart.vanassche@wdc.com>,
	Ming Lei <ming.lei@redhat.com>,
	Josef Bacik <josef@toxicpanda.com>, Tejun Heo <tj@kernel.org>,
	Lee Duncan <lduncan@suse.com>, Chris Leech <cleech@redhat.com>,
	linux-block@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: [PATCH 12/14] block: remove BLK_EH_HANDLED
Date: Tue, 29 May 2018 15:52:37 +0200	[thread overview]
Message-ID: <20180529135239.27005-13-hch@lst.de> (raw)
In-Reply-To: <20180529135239.27005-1-hch@lst.de>

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.com>
---
 Documentation/scsi/scsi_eh.txt | 11 -----------
 block/blk-mq.c                 |  4 ----
 block/blk-timeout.c            |  3 ---
 include/linux/blkdev.h         |  1 -
 4 files changed, 19 deletions(-)

diff --git a/Documentation/scsi/scsi_eh.txt b/Documentation/scsi/scsi_eh.txt
index 3ae8419e72cf..1b7436932a2b 100644
--- a/Documentation/scsi/scsi_eh.txt
+++ b/Documentation/scsi/scsi_eh.txt
@@ -82,17 +82,6 @@ function
  1. invokes optional hostt->eh_timed_out() callback.  Return value can
     be one of
 
-    - BLK_EH_HANDLED
-	This indicates that eh_timed_out() dealt with the timeout.
-	The command is passed back to the block layer and completed
-	via __blk_complete_requests().
-
-	*NOTE* After returning BLK_EH_HANDLED the SCSI layer is
-	assumed to be finished with the command, and no other
-	functions from the SCSI layer will be called. So this
-	should typically only be returned if the eh_timed_out()
-	handler raced with normal completion.
-
     - BLK_EH_RESET_TIMER
 	This indicates that more time is required to finish the
 	command.  Timer is restarted.  This action is counted as a
diff --git a/block/blk-mq.c b/block/blk-mq.c
index a7a601f08bf5..d898de8841a0 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -777,10 +777,6 @@ static void blk_mq_rq_timed_out(struct request *req, bool reserved)
 		ret = ops->timeout(req, reserved);
 
 	switch (ret) {
-	case BLK_EH_HANDLED:
-		if (blk_mq_rq_state(req) == MQ_RQ_IN_FLIGHT)
-			__blk_mq_complete_request(req);
-		break;
 	case BLK_EH_RESET_TIMER:
 		blk_add_timer(req);
 		break;
diff --git a/block/blk-timeout.c b/block/blk-timeout.c
index 11879e98c249..4b8a48d48ba1 100644
--- a/block/blk-timeout.c
+++ b/block/blk-timeout.c
@@ -86,9 +86,6 @@ static void blk_rq_timed_out(struct request *req)
 	if (q->rq_timed_out_fn)
 		ret = q->rq_timed_out_fn(req);
 	switch (ret) {
-	case BLK_EH_HANDLED:
-		__blk_complete_request(req);
-		break;
 	case BLK_EH_RESET_TIMER:
 		blk_add_timer(req);
 		blk_clear_rq_complete(req);
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index f82e05df905b..d838a89639f2 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -327,7 +327,6 @@ typedef void (exit_rq_fn)(struct request_queue *, struct request *);
 
 enum blk_eh_timer_return {
 	BLK_EH_DONE,
-	BLK_EH_HANDLED,
 	BLK_EH_RESET_TIMER,
 };
 
-- 
2.17.0

  parent reply	other threads:[~2018-05-29 13:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29 13:52 drop abort sequence, kill BLK_EH_HANDLED v2 Christoph Hellwig
2018-05-29 13:52 ` [PATCH 01/14] libata: remove ata_scsi_timed_out Christoph Hellwig
2018-05-29 13:52 ` [PATCH 02/14] blk-mq: Fix timeout and state order Christoph Hellwig
2018-05-29 13:52 ` [PATCH 03/14] blk-mq: Remove generation seqeunce Christoph Hellwig
2018-06-04  6:56   ` Bart Van Assche
2018-06-04 13:42     ` hch
2018-06-04 14:13       ` Bart Van Assche
2018-05-29 13:52 ` [PATCH 04/14] block: rename BLK_EH_NOT_HANDLED to BLK_EH_DONE Christoph Hellwig
2018-05-29 13:52 ` [PATCH 05/14] nvme: return BLK_EH_DONE from ->timeout Christoph Hellwig
2018-05-29 13:52 ` [PATCH 06/14] nbd: complete requests " Christoph Hellwig
2018-05-29 13:52 ` [PATCH 07/14] mtip32xx: " Christoph Hellwig
2018-05-29 14:17   ` Johannes Thumshirn
2018-05-29 13:52 ` [PATCH 08/14] null_blk: " Christoph Hellwig
2018-05-29 13:52 ` [PATCH 09/14] scsi_transport_fc: " Christoph Hellwig
2018-05-29 13:52 ` [PATCH 10/14] mmc: " Christoph Hellwig
2018-05-29 14:55   ` Shawn Lin
2018-05-30  8:09     ` Adrian Hunter
2018-05-29 13:52 ` [PATCH 11/14] libiscsi: don't try to bypass SCSI EH Christoph Hellwig
2018-05-30  1:04   ` Lee Duncan
2018-05-29 13:52 ` Christoph Hellwig [this message]
2018-05-29 14:17   ` [PATCH 12/14] block: remove BLK_EH_HANDLED Johannes Thumshirn
2018-05-29 13:52 ` [PATCH 13/14] block: document the blk_eh_timer_return values Christoph Hellwig
2018-05-29 14:17   ` Johannes Thumshirn
2018-05-29 13:52 ` [PATCH 14/14] blk-mq: simplify blk_mq_rq_timed_out Christoph Hellwig
2018-05-29 14:19   ` Johannes Thumshirn
2018-05-29 15:12 ` drop abort sequence, kill BLK_EH_HANDLED v2 Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180529135239.27005-13-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=bart.vanassche@wdc.com \
    --cc=cleech@redhat.com \
    --cc=josef@toxicpanda.com \
    --cc=keith.busch@intel.com \
    --cc=lduncan@suse.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox