public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>, Keith Busch <keith.busch@intel.com>
Cc: Bart Van Assche <bart.vanassche@wdc.com>,
	Ming Lei <ming.lei@redhat.com>,
	Josef Bacik <josef@toxicpanda.com>, Tejun Heo <tj@kernel.org>,
	Lee Duncan <lduncan@suse.com>, Chris Leech <cleech@redhat.com>,
	linux-block@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: [PATCH 14/14] blk-mq: simplify blk_mq_rq_timed_out
Date: Tue, 29 May 2018 15:52:39 +0200	[thread overview]
Message-ID: <20180529135239.27005-15-hch@lst.de> (raw)
In-Reply-To: <20180529135239.27005-1-hch@lst.de>

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-mq.c | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index d898de8841a0..ba6f30a67027 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -770,22 +770,16 @@ EXPORT_SYMBOL(blk_mq_tag_to_rq);
 
 static void blk_mq_rq_timed_out(struct request *req, bool reserved)
 {
-	const struct blk_mq_ops *ops = req->q->mq_ops;
-	enum blk_eh_timer_return ret = BLK_EH_RESET_TIMER;
+	if (req->q->mq_ops->timeout) {
+		enum blk_eh_timer_return ret;
 
-	if (ops->timeout)
-		ret = ops->timeout(req, reserved);
-
-	switch (ret) {
-	case BLK_EH_RESET_TIMER:
-		blk_add_timer(req);
-		break;
-	case BLK_EH_DONE:
-		break;
-	default:
-		printk(KERN_ERR "block: bad eh return: %d\n", ret);
-		break;
+		ret = req->q->mq_ops->timeout(req, reserved);
+		if (ret == BLK_EH_DONE)
+			return;
+		WARN_ON_ONCE(ret != BLK_EH_RESET_TIMER);
 	}
+
+	blk_add_timer(req);
 }
 
 static bool blk_mq_req_expired(struct request *rq, unsigned long *next)
-- 
2.17.0

  parent reply	other threads:[~2018-05-29 13:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29 13:52 drop abort sequence, kill BLK_EH_HANDLED v2 Christoph Hellwig
2018-05-29 13:52 ` [PATCH 01/14] libata: remove ata_scsi_timed_out Christoph Hellwig
2018-05-29 13:52 ` [PATCH 02/14] blk-mq: Fix timeout and state order Christoph Hellwig
2018-05-29 13:52 ` [PATCH 03/14] blk-mq: Remove generation seqeunce Christoph Hellwig
2018-06-04  6:56   ` Bart Van Assche
2018-06-04 13:42     ` hch
2018-06-04 14:13       ` Bart Van Assche
2018-05-29 13:52 ` [PATCH 04/14] block: rename BLK_EH_NOT_HANDLED to BLK_EH_DONE Christoph Hellwig
2018-05-29 13:52 ` [PATCH 05/14] nvme: return BLK_EH_DONE from ->timeout Christoph Hellwig
2018-05-29 13:52 ` [PATCH 06/14] nbd: complete requests " Christoph Hellwig
2018-05-29 13:52 ` [PATCH 07/14] mtip32xx: " Christoph Hellwig
2018-05-29 14:17   ` Johannes Thumshirn
2018-05-29 13:52 ` [PATCH 08/14] null_blk: " Christoph Hellwig
2018-05-29 13:52 ` [PATCH 09/14] scsi_transport_fc: " Christoph Hellwig
2018-05-29 13:52 ` [PATCH 10/14] mmc: " Christoph Hellwig
2018-05-29 14:55   ` Shawn Lin
2018-05-30  8:09     ` Adrian Hunter
2018-05-29 13:52 ` [PATCH 11/14] libiscsi: don't try to bypass SCSI EH Christoph Hellwig
2018-05-30  1:04   ` Lee Duncan
2018-05-29 13:52 ` [PATCH 12/14] block: remove BLK_EH_HANDLED Christoph Hellwig
2018-05-29 14:17   ` Johannes Thumshirn
2018-05-29 13:52 ` [PATCH 13/14] block: document the blk_eh_timer_return values Christoph Hellwig
2018-05-29 14:17   ` Johannes Thumshirn
2018-05-29 13:52 ` Christoph Hellwig [this message]
2018-05-29 14:19   ` [PATCH 14/14] blk-mq: simplify blk_mq_rq_timed_out Johannes Thumshirn
2018-05-29 15:12 ` drop abort sequence, kill BLK_EH_HANDLED v2 Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2018-05-23 12:19 BLK_EH_HANDLED Christoph Hellwig
2018-05-23 12:19 ` [PATCH 14/14] blk-mq: simplify blk_mq_rq_timed_out Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180529135239.27005-15-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=bart.vanassche@wdc.com \
    --cc=cleech@redhat.com \
    --cc=josef@toxicpanda.com \
    --cc=keith.busch@intel.com \
    --cc=lduncan@suse.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox