* [PATCH blktests] common/fio: do not use norandommap with verify [not found] <CGME20200130084950eucas1p2dac69024658d531d5f69ea0bdbd2be81@eucas1p2.samsung.com> @ 2020-01-30 8:49 ` Klaus Jensen 2020-02-03 21:43 ` Omar Sandoval 0 siblings, 1 reply; 4+ messages in thread From: Klaus Jensen @ 2020-01-30 8:49 UTC (permalink / raw) To: linux-block; +Cc: osandov, its As per the fio documentation, using norandommap with an async I/O engine and I/O depth > 1, can cause verification errors. Signed-off-by: Klaus Jensen <k.jensen@samsung.com> --- common/fio | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/fio b/common/fio index 2e81b26b50f1..8bfad4238dda 100644 --- a/common/fio +++ b/common/fio @@ -180,7 +180,7 @@ _run_fio_rand_io() { _run_fio_verify_io() { _run_fio --name=verify --rw=randwrite --direct=1 --ioengine=libaio --bs=4k \ - --norandommap --iodepth=16 --verify=crc32c "$@" + --iodepth=16 --verify=crc32c "$@" } _fio_perf_report() { -- 2.25.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH blktests] common/fio: do not use norandommap with verify 2020-01-30 8:49 ` [PATCH blktests] common/fio: do not use norandommap with verify Klaus Jensen @ 2020-02-03 21:43 ` Omar Sandoval 2020-04-02 11:25 ` Klaus Birkelund Jensen 0 siblings, 1 reply; 4+ messages in thread From: Omar Sandoval @ 2020-02-03 21:43 UTC (permalink / raw) To: Klaus Jensen; +Cc: linux-block, osandov, its On Thu, Jan 30, 2020 at 09:49:41AM +0100, Klaus Jensen wrote: > As per the fio documentation, using norandommap with an async I/O engine > and I/O depth > 1, can cause verification errors. > > Signed-off-by: Klaus Jensen <k.jensen@samsung.com> Good catch, applied. Thanks! ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH blktests] common/fio: do not use norandommap with verify 2020-02-03 21:43 ` Omar Sandoval @ 2020-04-02 11:25 ` Klaus Birkelund Jensen 2020-04-03 18:20 ` Omar Sandoval 0 siblings, 1 reply; 4+ messages in thread From: Klaus Birkelund Jensen @ 2020-04-02 11:25 UTC (permalink / raw) To: Omar Sandoval; +Cc: Klaus Jensen, linux-block, osandov On Feb 3 13:43, Omar Sandoval wrote: > On Thu, Jan 30, 2020 at 09:49:41AM +0100, Klaus Jensen wrote: > > As per the fio documentation, using norandommap with an async I/O engine > > and I/O depth > 1, can cause verification errors. > > > > Signed-off-by: Klaus Jensen <k.jensen@samsung.com> > > Good catch, applied. Thanks! Hi Omar, Looks like this got lost somewhere? Klaus ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH blktests] common/fio: do not use norandommap with verify 2020-04-02 11:25 ` Klaus Birkelund Jensen @ 2020-04-03 18:20 ` Omar Sandoval 0 siblings, 0 replies; 4+ messages in thread From: Omar Sandoval @ 2020-04-03 18:20 UTC (permalink / raw) To: Klaus Birkelund Jensen; +Cc: Klaus Jensen, linux-block, osandov On Thu, Apr 02, 2020 at 01:25:09PM +0200, Klaus Birkelund Jensen wrote: > On Feb 3 13:43, Omar Sandoval wrote: > > On Thu, Jan 30, 2020 at 09:49:41AM +0100, Klaus Jensen wrote: > > > As per the fio documentation, using norandommap with an async I/O engine > > > and I/O depth > 1, can cause verification errors. > > > > > > Signed-off-by: Klaus Jensen <k.jensen@samsung.com> > > > > Good catch, applied. Thanks! > > Hi Omar, > > Looks like this got lost somewhere? You're right, not sure what happened there. Applied and pushed this time. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-03 18:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20200130084950eucas1p2dac69024658d531d5f69ea0bdbd2be81@eucas1p2.samsung.com>
2020-01-30 8:49 ` [PATCH blktests] common/fio: do not use norandommap with verify Klaus Jensen
2020-02-03 21:43 ` Omar Sandoval
2020-04-02 11:25 ` Klaus Birkelund Jensen
2020-04-03 18:20 ` Omar Sandoval
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox