* [PATCH] docs: sysfs-block: document size sysfs entry
@ 2024-04-05 16:54 Tokunori Ikegami
2024-04-05 17:42 ` Bart Van Assche
0 siblings, 1 reply; 3+ messages in thread
From: Tokunori Ikegami @ 2024-04-05 16:54 UTC (permalink / raw)
To: linux-block; +Cc: Tokunori Ikegami
Document it since /sys/block/<disk>/size is undocumented.
Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
---
Documentation/ABI/stable/sysfs-block | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/ABI/stable/sysfs-block b/Documentation/ABI/stable/sysfs-block
index 7718ed34777e..881049419054 100644
--- a/Documentation/ABI/stable/sysfs-block
+++ b/Documentation/ABI/stable/sysfs-block
@@ -707,6 +707,13 @@ Description:
zoned will report "none".
+What: /sys/block/<disk>/size
+Date: April 2024
+Contact: linux-block@vger.kernel.org
+Description:
+ [RO] This is the 512 bytes size sector number.
+
+
What: /sys/block/<disk>/stat
Date: February 2008
Contact: Jerome Marchand <jmarchan@redhat.com>
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: sysfs-block: document size sysfs entry
2024-04-05 16:54 [PATCH] docs: sysfs-block: document size sysfs entry Tokunori Ikegami
@ 2024-04-05 17:42 ` Bart Van Assche
2024-04-05 21:26 ` Tokunori Ikegami
0 siblings, 1 reply; 3+ messages in thread
From: Bart Van Assche @ 2024-04-05 17:42 UTC (permalink / raw)
To: Tokunori Ikegami, linux-block
On 4/5/24 09:54, Tokunori Ikegami wrote:
> Document it since /sys/block/<disk>/size is undocumented.
>
> Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
> ---
> Documentation/ABI/stable/sysfs-block | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/ABI/stable/sysfs-block b/Documentation/ABI/stable/sysfs-block
> index 7718ed34777e..881049419054 100644
> --- a/Documentation/ABI/stable/sysfs-block
> +++ b/Documentation/ABI/stable/sysfs-block
> @@ -707,6 +707,13 @@ Description:
> zoned will report "none".
>
>
> +What: /sys/block/<disk>/size
> +Date: April 2024
> +Contact: linux-block@vger.kernel.org
> +Description:
> + [RO] This is the 512 bytes size sector number.
What is a "sector number"? Please change the description into something
like the following:
[RO] Size of the block device in units of 512 bytes.
Thanks,
Bart.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: sysfs-block: document size sysfs entry
2024-04-05 17:42 ` Bart Van Assche
@ 2024-04-05 21:26 ` Tokunori Ikegami
0 siblings, 0 replies; 3+ messages in thread
From: Tokunori Ikegami @ 2024-04-05 21:26 UTC (permalink / raw)
To: Bart Van Assche, linux-block
On 2024/04/06 2:42, Bart Van Assche wrote:
> On 4/5/24 09:54, Tokunori Ikegami wrote:
>> Document it since /sys/block/<disk>/size is undocumented.
>>
>> Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
>> ---
>> Documentation/ABI/stable/sysfs-block | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/ABI/stable/sysfs-block
>> b/Documentation/ABI/stable/sysfs-block
>> index 7718ed34777e..881049419054 100644
>> --- a/Documentation/ABI/stable/sysfs-block
>> +++ b/Documentation/ABI/stable/sysfs-block
>> @@ -707,6 +707,13 @@ Description:
>> zoned will report "none".
>> +What: /sys/block/<disk>/size
>> +Date: April 2024
>> +Contact: linux-block@vger.kernel.org
>> +Description:
>> + [RO] This is the 512 bytes size sector number.
>
> What is a "sector number"? Please change the description into
> something like the following:
>
> [RO] Size of the block device in units of 512 bytes.
Thanks for your suggestion. Just fixed by the version 2 patch as mentioned.
>
> Thanks,
>
> Bart.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-05 21:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-05 16:54 [PATCH] docs: sysfs-block: document size sysfs entry Tokunori Ikegami
2024-04-05 17:42 ` Bart Van Assche
2024-04-05 21:26 ` Tokunori Ikegami
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox