* Re: [PATCH 6.12 0534/1756] block: remove BLK_MQ_F_SHOULD_MERGE [not found] <20261118150030.389817521@linuxfoundation.org> @ 2026-11-19 14:08 ` Miguel Ojeda 2026-11-20 2:09 ` Sasha Levin 0 siblings, 1 reply; 2+ messages in thread From: Miguel Ojeda @ 2026-11-19 14:08 UTC (permalink / raw) To: gregkh Cc: axboe, hch, patches, sashal, stable, Andreas Hindborg, Boqun Feng, linux-block, rust-for-linux On Wed, 18 Nov 2026 15:44:21 +0100 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > BLK_MQ_F_SHOULD_MERGE is set for all tag_sets except those that purely > process passthrough commands (bsg-lib, ufs tmf, various nvme admin > queues) and thus don't even check the flag. Remove it to simplify the > driver interface. > enum { > - BLK_MQ_F_SHOULD_MERGE = 1 << 0, > BLK_MQ_F_TAG_QUEUE_SHARED = 1 << 1, This causes: error[E0425]: cannot find value `BLK_MQ_F_SHOULD_MERGE` in crate `bindings` --> rust/kernel/block/mq/tag_set.rs:55:38 | 55 | flags: bindings::BLK_MQ_F_SHOULD_MERGE, | ^^^^^^^^^^^^^^^^^^^^^ not found in `bindings` We need: 31d813a3b8cb ("rust: block: fix use of BLK_MQ_F_SHOULD_MERGE") Cc: Christoph Hellwig <hch@lst.de> Cc: Jens Axboe <axboe@kernel.dk> Cc: Sasha Levin <sashal@kernel.org> Cc: Andreas Hindborg <a.hindborg@kernel.org> Cc: Boqun Feng <boqun@kernel.org> Cc: linux-block@vger.kernel.org Cc: rust-for-linux@vger.kernel.org I hope that helps! Cheers, Miguel ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 6.12 0534/1756] block: remove BLK_MQ_F_SHOULD_MERGE 2026-11-19 14:08 ` [PATCH 6.12 0534/1756] block: remove BLK_MQ_F_SHOULD_MERGE Miguel Ojeda @ 2026-11-20 2:09 ` Sasha Levin 0 siblings, 0 replies; 2+ messages in thread From: Sasha Levin @ 2026-11-20 2:09 UTC (permalink / raw) To: Miguel Ojeda Cc: Sasha Levin, gregkh, axboe, hch, patches, stable, Andreas Hindborg, Boqun Feng, linux-block, rust-for-linux On Thu, Nov 19, 2026 at 03:08:30PM +0100, Miguel Ojeda wrote: > error[E0425]: cannot find value `BLK_MQ_F_SHOULD_MERGE` in crate `bindings` Dropped cc76ace465d6 ("block: remove BLK_MQ_F_SHOULD_MERGE") from the 6.12 queue, along with the swim patches it was queued for: 92353a047637 ("swim: Convert to blocking queue") and the swim patches after it (04cb277e6841, b736189c93c9, abae04f5bed9 and bbcd3e38a4f3), plus b9c109504853 ("swim: Add track zero recalibration delay"). Thanks for the pointer to 31d813a3b8cb. -- Thanks, Sasha ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-20 2:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20261118150030.389817521@linuxfoundation.org>
2026-11-19 14:08 ` [PATCH 6.12 0534/1756] block: remove BLK_MQ_F_SHOULD_MERGE Miguel Ojeda
2026-11-20 2:09 ` Sasha Levin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox