Linux block layer
 help / color / mirror / Atom feed
* [PATCH] block: remove redundant passthrough check in blk_mq_need_time_stamp()
@ 2024-10-02 20:11 Jens Axboe
  2024-10-02 20:14 ` Keith Busch
  2024-10-03  8:20 ` Anuj gupta
  0 siblings, 2 replies; 3+ messages in thread
From: Jens Axboe @ 2024-10-02 20:11 UTC (permalink / raw)
  To: linux-block@vger.kernel.org

Simply checking the rq_flags is enough to determine if accounting is
being done for this request.

Signed-off-by: Jens Axboe <axboe@kernel.dk>

---

diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index 4fecf46ef681..59e9adf815a4 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -857,12 +857,6 @@ void blk_mq_end_request_batch(struct io_comp_batch *ib);
  */
 static inline bool blk_mq_need_time_stamp(struct request *rq)
 {
-	/*
-	 * passthrough io doesn't use iostat accounting, cgroup stats
-	 * and io scheduler functionalities.
-	 */
-	if (blk_rq_is_passthrough(rq))
-		return false;
 	return (rq->rq_flags & (RQF_IO_STAT | RQF_STATS | RQF_USE_SCHED));
 }
 
-- 
Jens Axboe


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-10-03  8:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-02 20:11 [PATCH] block: remove redundant passthrough check in blk_mq_need_time_stamp() Jens Axboe
2024-10-02 20:14 ` Keith Busch
2024-10-03  8:20 ` Anuj gupta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox