Re: [PATCH blktests 1/7] common/rc: add _min()

[John Garry <john.g.garry@oracle.com>]

On 18/09/2025 05:08, Shinichiro Kawasaki wrote:
> On Sep 12, 2025 / 09:57, John Garry wrote:
>> Add a helper to find the minimum of two numbers.
>>
>> A similar helper is being added in xfstests:
>> https://lore.kernel.org/linux-xfs/cover.1755849134.git.ojaswin@linux.ibm.com/T/#m962683d8115979e57342d2644660230ee978c803
>>
>> Signed-off-by: John Garry <john.g.garry@oracle.com>
>> ---
>>   common/rc | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/common/rc b/common/rc
>> index 946dee1..77a0f45 100644
>> --- a/common/rc
>> +++ b/common/rc
>> @@ -700,3 +700,14 @@ _real_dev()
>>   	fi
>>   	echo "$dev"
>>   }
>> +
>> +_min() {
>> +	local ret
>> +
>> +	for arg in "$@"; do
>> +		if [ -z "$ret" ] || (( $arg < $ret )); then
> 
> The line above and,
> 
>> +			ret="$arg"
>> +		fi
>> +	done
>> +	echo $ret
> 
> this line above caused shellcheck warnings below.
> 
> $ make check
> shellcheck -x -e SC2119 -f gcc check common/* \
>          tests/*/rc tests/*/[0-9]*[0-9] src/*.sh
> common/rc:708:26: note: $/${} is unnecessary on arithmetic variables. [SC2004]
> common/rc:708:33: note: $/${} is unnecessary on arithmetic variables. [SC2004]
> common/rc:712:7: note: Double quote to prevent globbing and word splitting. [SC2086]
> tests/md/rc:28:12: note: $/${} is unnecessary on arithmetic variables. [SC2004]
> tests/md/rc:28:21: note: $/${} is unnecessary on arithmetic variables. [SC2004]
> ...
> 
> Other patches caused other shellcheck warnings. Could you run "make check" and
> address them?

sure, will fix

thanks