Re: [PATCH blktests 0/7] Further stacked device atomic writes testing

[John Garry <john.g.garry@oracle.com>]

On 16/09/2025 11:20, John Garry wrote:
>> also modified md/003 to adapt to the change [2].
>>
>> [1] https://urldefense.com/v3/__https://github.com/kawasaki/blktests/ 
>> commit/7db35a16d7410cae728da8d6b9b2483e33e9c99b__;!!ACWV5N9M2RV99hQ! 
>> Lm9AlQ3T9qSGDEjCR0nGmjCGC_2wfuAbkP6zN9EfZD7L2Y7mgpKPah_fYZh6L_OPkH9IIxP4f9n1Q9dRRRJxbZQeqRtr$
>> [2] https://urldefense.com/v3/__https://github.com/kawasaki/blktests/ 
>> commit/278e6c74deba68e3044abf0e6c3ec350c0bc4a40__;!!ACWV5N9M2RV99hQ! 
>> Lm9AlQ3T9qSGDEjCR0nGmjCGC_2wfuAbkP6zN9EfZD7L2Y7mgpKPah_fYZh6L_OPkH9IIxP4f9n1Q9dRRRJxbSlcsw0E$
>>
>> Please let me know your thoughts on the two approaches.
> 
> Let me check it, thanks!

I gave it a spin for 003 and it looks to work ok - thanks!

I further comment I have on my own code is about this snippet from 003:

	for ((i = 0; i < ${#NVME_TEST_DEVS[@]}; ++i)); do
		TEST_DEV_SYSFS="${NVME_TEST_DEVS_SYSFS[$i]}"
		TEST_DEV="${NVME_TEST_DEVS[$i]}"
		_require_device_support_atomic_writes
		_require_test_dev_size 16m
	done

Notice that I set TEST_DEV_SYSFS and TEST_DEV, as these are required for 
the _require_device_support_atomic_writes and _require_test_dev_size 
calls. I'm just trying to reuse helpers normally used for test_device(). 
Is this ok to do so? I'm not sure if it is a bit of a bodge...

John