From: Finn Thain <fthain@linux-m68k.org>
To: Jens Axboe <axboe@kernel.dk>, Laurent Vivier <laurent@vivier.eu>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Joshua Thompson <funaho@jurai.org>,
linux-block@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 32/32] swim: Unexport global symbols
Date: Mon, 17 Aug 2026 11:17:10 +1000 [thread overview]
Message-ID: <771c797816910eac8e89646dbe35fc0604c64c5b.1786929430.git.fthain@linux-m68k.org> (raw)
In-Reply-To: <cover.1786929430.git.fthain@linux-m68k.org>
These symbols aren't used outside of this file so use local ones.
No functional change.
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Finn Thain <fthain@linux-m68k.org>
---
drivers/block/swim_asm.S | 218 ++++++++++++++++++++-------------------
1 file changed, 112 insertions(+), 106 deletions(-)
diff --git a/drivers/block/swim_asm.S b/drivers/block/swim_asm.S
index c78efc30082a..c3f1476948b5 100644
--- a/drivers/block/swim_asm.S
+++ b/drivers/block/swim_asm.S
@@ -14,33 +14,33 @@
* 2008-11-05 (lv) - add get_swim_mode
*/
- .equ write_data, 0x0000
- .equ write_mark, 0x0200
- .equ write_CRC, 0x0400
- .equ write_parameter,0x0600
- .equ write_phase, 0x0800
- .equ write_setup, 0x0a00
- .equ write_mode0, 0x0c00
- .equ write_mode1, 0x0e00
- .equ read_data, 0x1000
- .equ read_mark, 0x1200
- .equ read_error, 0x1400
- .equ read_parameter, 0x1600
- .equ read_phase, 0x1800
- .equ read_setup, 0x1a00
- .equ read_status, 0x1c00
- .equ read_handshake, 0x1e00
-
- .equ o_side, 0
- .equ o_track, 1
- .equ o_sector, 2
- .equ o_size, 3
- .equ o_crc0, 4
- .equ o_crc1, 5
-
- .equ seek_time, 30000
- .equ max_retry, 40
- .equ sector_size, 512
+ .equ .Lwrite_data, 0x0000
+ .equ .Lwrite_mark, 0x0200
+ .equ .Lwrite_CRC, 0x0400
+ .equ .Lwrite_parameter, 0x0600
+ .equ .Lwrite_phase, 0x0800
+ .equ .Lwrite_setup, 0x0a00
+ .equ .Lwrite_mode0, 0x0c00
+ .equ .Lwrite_mode1, 0x0e00
+ .equ .Lread_data, 0x1000
+ .equ .Lread_mark, 0x1200
+ .equ .Lread_error, 0x1400
+ .equ .Lread_parameter, 0x1600
+ .equ .Lread_phase, 0x1800
+ .equ .Lread_setup, 0x1a00
+ .equ .Lread_status, 0x1c00
+ .equ .Lread_handshake, 0x1e00
+
+ .equ .Lo_side, 0
+ .equ .Lo_track, 1
+ .equ .Lo_sector, 2
+ .equ .Lo_size, 3
+ .equ .Lo_crc0, 4
+ .equ .Lo_crc1, 5
+
+ .equ .Lseek_time, 30000
+ .equ .Lmax_retry, 40
+ .equ .Lsector_size, 512
.equ .Lmark_sequence_len, 4
.equ .Lmr_clear_fifo, 0x01
@@ -63,7 +63,7 @@
moveq #-1, %d1
subq #1, %d4
- movew #seek_time, %d2
+ movew #.Lseek_time, %d2
5: tstb %a2@
dbmi %d2, 5b
@@ -88,80 +88,86 @@ swim_read_sector_header:
unlk %a6
rts
-sector_address_mark:
+.Lsector_address_mark:
.byte 0xa1, 0xa1, 0xa1, 0xfe
-sector_data_mark:
+.Lsector_data_mark:
.byte 0xa1, 0xa1, 0xa1, 0xfb
.Lmfm_read_header:
movel %a6@(0x08), %a3
- lea %a3@(read_handshake), %a2
- lea %a3@(read_data), %a5
- lea %a3@(read_mark), %a3
+ lea %a3@(.Lread_handshake), %a2
+ lea %a3@(.Lread_data), %a5
+ lea %a3@(.Lread_mark), %a3
- moveb #.Lmr_write_action, %a3@(write_mode0 - read_mark)
- moveb #.Lmr_clear_fifo, %a3@(write_mode1 - read_mark)
- moveb #.Lmr_clear_fifo, %a3@(write_mode0 - read_mark)
- tstb %a3@(read_error - read_mark)
- moveb #.Lmr_action, %a3@(write_mode1 - read_mark)
+ moveb #.Lmr_write_action, %a3@(.Lwrite_mode0 - .Lread_mark)
+ moveb #.Lmr_clear_fifo, %a3@(.Lwrite_mode1 - .Lread_mark)
+ moveb #.Lmr_clear_fifo, %a3@(.Lwrite_mode0 - .Lread_mark)
+ tstb %a3@(.Lread_error - .Lread_mark)
+ moveb #.Lmr_action, %a3@(.Lwrite_mode1 - .Lread_mark)
- lea sector_address_mark, %a1
+ lea .Lsector_address_mark, %a1
moveq #.Lmark_sequence_len, %d4
bsr .Lmfm_mark_check
tstl %d1
- bne signal_nonyb
+ bne .Lsignal_nonyb
/* read header */
- moveq #max_retry, %d2
-amark0: tstb %a2@
- dbmi %d2, amark0
- bpl signal_nonyb
+ moveq #.Lmax_retry, %d2
+.Lamark0:
+ tstb %a2@
+ dbmi %d2, .Lamark0
+ bpl .Lsignal_nonyb
- moveb %a5@, %a4@(o_track)
+ moveb %a5@, %a4@(.Lo_track)
- moveq #max_retry, %d2
-amark1: tstb %a2@
- dbmi %d2, amark1
- bpl signal_nonyb
+ moveq #.Lmax_retry, %d2
+.Lamark1:
+ tstb %a2@
+ dbmi %d2, .Lamark1
+ bpl .Lsignal_nonyb
- moveb %a5@, %a4@(o_side)
+ moveb %a5@, %a4@(.Lo_side)
- moveq #max_retry, %d2
-amark2: tstb %a2@
- dbmi %d2, amark2
- bpl signal_nonyb
+ moveq #.Lmax_retry, %d2
+.Lamark2:
+ tstb %a2@
+ dbmi %d2, .Lamark2
+ bpl .Lsignal_nonyb
- moveb %a5@, %a4@(o_sector)
+ moveb %a5@, %a4@(.Lo_sector)
- moveq #max_retry, %d2
-amark3: tstb %a2@
- dbmi %d2, amark3
- bpl signal_nonyb
+ moveq #.Lmax_retry, %d2
+.Lamark3:
+ tstb %a2@
+ dbmi %d2, .Lamark3
+ bpl .Lsignal_nonyb
- moveb %a5@, %a4@(o_size)
+ moveb %a5@, %a4@(.Lo_size)
- moveq #max_retry, %d2
-crc0: tstb %a2@
- dbmi %d2, crc0
- bpl signal_nonyb
+ moveq #.Lmax_retry, %d2
+.Lcrc0:
+ tstb %a2@
+ dbmi %d2, .Lcrc0
+ bpl .Lsignal_nonyb
- moveb %a5@, %a4@(o_crc0)
+ moveb %a5@, %a4@(.Lo_crc0)
- moveq #max_retry, %d2
-crc1: moveb %a2@, %d5
- dbmi %d2, crc1
- bpl signal_nonyb
+ moveq #.Lmax_retry, %d2
+.Lcrc1:
+ moveb %a2@, %d5
+ dbmi %d2, .Lcrc1
+ bpl .Lsignal_nonyb
- moveb %a5@, %a4@(o_crc1)
+ moveb %a5@, %a4@(.Lo_crc1)
moveb %a2@, %d5
andb #.Lhr_crc_error, %d5
- bne signal_nonyb
+ bne .Lsignal_nonyb
moveq #0, %d0
-signal_nonyb:
- moveb #.Lmr_write_action, %a3@(write_mode0 - read_mark)
+.Lsignal_nonyb:
+ moveb #.Lmr_write_action, %a3@(.Lwrite_mode0 - .Lread_mark)
rts
.global swim_read_sector_data
@@ -170,80 +176,80 @@ swim_read_sector_data:
moveml %d1-%d5/%a0-%a5,%sp@-
movel %a6@(0x0c), %a4
moveq #-1, %d0
- bsr mfm_read_data
+ bsr .Lmfm_read_data
moveml %sp@+, %d1-%d5/%a0-%a5
unlk %a6
rts
-mfm_read_data:
+.Lmfm_read_data:
movel %a6@(0x08), %a3
- lea %a3@(read_handshake), %a2
- lea %a3@(read_data), %a5
- lea %a3@(read_mark), %a3
+ lea %a3@(.Lread_handshake), %a2
+ lea %a3@(.Lread_data), %a5
+ lea %a3@(.Lread_mark), %a3
- moveb #.Lmr_write_action, %a3@(write_mode0 - read_mark)
- moveb #.Lmr_clear_fifo, %a3@(write_mode1 - read_mark)
- moveb #.Lmr_clear_fifo, %a3@(write_mode0 - read_mark)
- tstb %a3@(read_error - read_mark)
- moveb #.Lmr_action, %a3@(write_mode1 - read_mark)
+ moveb #.Lmr_write_action, %a3@(.Lwrite_mode0 - .Lread_mark)
+ moveb #.Lmr_clear_fifo, %a3@(.Lwrite_mode1 - .Lread_mark)
+ moveb #.Lmr_clear_fifo, %a3@(.Lwrite_mode0 - .Lread_mark)
+ tstb %a3@(.Lread_error - .Lread_mark)
+ moveb #.Lmr_action, %a3@(.Lwrite_mode1 - .Lread_mark)
- lea sector_data_mark, %a1
+ lea .Lsector_data_mark, %a1
moveq #.Lmark_sequence_len, %d4
bsr .Lmfm_mark_check
tstl %d1
- bne data_exit
+ bne .Ldata_exit
/* read data */
- movel #sector_size - 1, %d4 /* sector size */
- movew #max_retry, %d2
-read_data_loop:
+ movel #.Lsector_size - 1, %d4 /* sector size */
+ movew #.Lmax_retry, %d2
+.Lread_data_loop:
moveb %a2@, %d5
andb #(.Lhr_fifo_1byte + .Lhr_fifo_2bytes), %d5
- dbne %d2, read_data_loop
- beq data_exit
+ dbne %d2, .Lread_data_loop
+ beq .Ldata_exit
- moveq #max_retry, %d2
+ moveq #.Lmax_retry, %d2
moveb %a5@, %d3
bsr .Lmaybe_store
dbra %d4, 1f
- bra data_crc0
+ bra .Ldata_crc0
1: andb #.Lhr_fifo_2bytes, %d5
- beq read_data_loop
+ beq .Lread_data_loop
moveb %a5@, %d3
bsr .Lmaybe_store
- dbra %d4, read_data_loop
+ dbra %d4, .Lread_data_loop
/* read CRC */
- movew #max_retry, %d2
-data_crc0:
+ movew #.Lmax_retry, %d2
+.Ldata_crc0:
tstb %a2@
- dbmi %d2, data_crc0
- bpl data_exit
+ dbmi %d2, .Ldata_crc0
+ bpl .Ldata_exit
moveb %a5@, %d2
- moveq #max_retry, %d2
-data_crc1:
+ moveq #.Lmax_retry, %d2
+.Ldata_crc1:
moveb %a2@, %d5
- dbmi %d2, data_crc1
- bpl data_exit
+ dbmi %d2, .Ldata_crc1
+ bpl .Ldata_exit
moveb %a5@, %d2
moveb %a2@, %d5
andb #.Lhr_crc_error, %d5
- bne data_exit
+ bne .Ldata_exit
/* return number of bytes read */
- movel #sector_size, %d0
+ movel #.Lsector_size, %d0
addw #1, %d4
subl %d4, %d0
-data_exit:
- moveb #.Lmr_write_action, %a3@(write_mode0 - read_mark)
+.Ldata_exit:
+ moveb #.Lmr_write_action, %a3@(.Lwrite_mode0 - .Lread_mark)
rts
.Lmaybe_store:
--
2.52.0
next prev parent reply other threads:[~2026-08-17 1:59 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 1:17 [PATCH v2 00/32] block/swim: Fixes and improvements Finn Thain
2026-08-17 1:17 ` [PATCH v2 22/32] swim: Remove pointless mode0 register write Finn Thain
2026-08-17 1:17 ` [PATCH v2 30/32] swim: Define macros for constants Finn Thain
2026-08-17 1:17 ` [PATCH v2 05/32] swim: Perform ISM/IWM mode switching according to specs Finn Thain
2026-08-17 1:17 ` [PATCH v2 02/32] swim: Select appropriate drive once only Finn Thain
2026-08-17 1:17 ` [PATCH v2 08/32] swim: Don't start motor until medium is present Finn Thain
2026-08-17 1:17 ` [PATCH v2 15/32] swim: Don't use the mark register to read data Finn Thain
2026-08-17 1:17 ` [PATCH v2 29/32] swim: Clean up whitespace Finn Thain
2026-08-17 1:17 ` [PATCH v2 18/32] swim: Remove redundant RELAX actions Finn Thain
2026-08-17 1:17 ` [PATCH v2 14/32] swim: Check error register during sector read Finn Thain
2026-08-17 1:17 ` [PATCH v2 21/32] swim: Revisit delays Finn Thain
2026-08-17 1:17 ` [PATCH v2 10/32] swim: Add track zero recalibration delay Finn Thain
2026-08-17 1:17 ` [PATCH v2 06/32] swim: Configure parameter memory Finn Thain
2026-08-17 1:17 ` [PATCH v2 09/32] swim: Recalibrate when drive is probed Finn Thain
2026-08-17 1:17 ` [PATCH v2 07/32] swim: Enable clock divider only where appropriate Finn Thain
2026-08-31 7:38 ` Geert Uytterhoeven
2026-09-01 7:56 ` Finn Thain
2026-09-01 9:10 ` Geert Uytterhoeven
2026-08-17 1:17 ` [PATCH v2 17/32] swim: Convert to blocking queue Finn Thain
2026-08-17 1:17 ` [PATCH v2 01/32] swim: Assert strobe with stable outputs Finn Thain
2026-08-17 1:17 ` [PATCH v2 12/32] swim: Simplify return value initialization Finn Thain
2026-08-17 1:17 ` [PATCH v2 31/32] swim: Define symbols for constants Finn Thain
2026-08-17 1:17 ` [PATCH v2 23/32] swim: Don't needlessly re-read sectors Finn Thain
2026-08-17 1:17 ` [PATCH v2 26/32] swim: Move swd initialization Finn Thain
2026-08-17 1:17 ` [PATCH v2 16/32] swim: Fix buffer overflow Finn Thain
2026-08-17 1:17 ` [PATCH v2 27/32] swim: Add some helpful references Finn Thain
2026-08-17 1:17 ` [PATCH v2 20/32] swim: Check drive ready bit Finn Thain
2026-08-17 1:17 ` [PATCH v2 28/32] swim: Remove unused macro definitions Finn Thain
2026-08-17 1:17 ` Finn Thain [this message]
2026-08-17 1:17 ` [PATCH v2 11/32] swim: Handle FIFO timeout error Finn Thain
2026-08-17 1:17 ` [PATCH v2 19/32] swim: Deduplicate polling loops Finn Thain
2026-08-17 1:17 ` [PATCH v2 04/32] swim: Don't disable drive after every sector Finn Thain
2026-08-17 1:17 ` [PATCH v2 03/32] swim: Enable the drive when probing Finn Thain
2026-08-17 1:17 ` [PATCH v2 24/32] swim: Don't search beyond the first data mark Finn Thain
2026-08-17 1:17 ` [PATCH v2 13/32] swim: Check for CRC errors Finn Thain
2026-08-17 1:17 ` [PATCH v2 25/32] swim: Remove pointless specifiers Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=771c797816910eac8e89646dbe35fc0604c64c5b.1786929430.git.fthain@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=axboe@kernel.dk \
--cc=funaho@jurai.org \
--cc=geert@linux-m68k.org \
--cc=laurent@vivier.eu \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox