Linux block layer
 help / color / mirror / Atom feed
From: Finn Thain <fthain@linux-m68k.org>
To: Jens Axboe <axboe@kernel.dk>, Laurent Vivier <laurent@vivier.eu>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	linux-block@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 05/32] swim: Perform ISM/IWM mode switching according to specs
Date: Mon, 17 Aug 2026 11:17:10 +1000	[thread overview]
Message-ID: <873207193565455585f3116bb0d4ce95b600ce3e.1786929430.git.fthain@linux-m68k.org> (raw)
In-Reply-To: <cover.1786929430.git.fthain@linux-m68k.org>

The SWIM spec says, "MOTOREN must be low to switch modes" and "after
switching from ISM to IWM, the very first command must be a clear L7".

The ISM spec says, MOTOREN "must not be cleared until after the Action
bit is cleared". Perform those operations in the correct sequence.

When switching to ISM mode, the Mode register has to be selected with a
particular sequence of bit flips. Set q7 low then q6 low then mtrOff.

Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Fixes: 8852ecd97488 ("m68k: mac - Add SWIM floppy support")
Signed-off-by: Finn Thain <fthain@linux-m68k.org>
---
 drivers/block/swim.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/block/swim.c b/drivers/block/swim.c
index 3f92677ad127..190b2e1b5b0e 100644
--- a/drivers/block/swim.c
+++ b/drivers/block/swim.c
@@ -149,6 +149,7 @@ struct iwm {
 #define ACTION		0x08
 #define WRITE_MODE	0x10
 #define HEDSEL		0x20
+#define ISM_SELECT	0x40
 #define MOTON		0x80
 
 /*----------------------------------------------------------------------------*/
@@ -223,18 +224,21 @@ extern int swim_read_sector_data(struct swim __iomem *base,
 static DEFINE_MUTEX(swim_mutex);
 static inline void set_swim_mode(struct swim __iomem *base, int enable)
 {
-	struct iwm __iomem *iwm_base;
+	struct iwm __iomem *iwm_base = (struct iwm __iomem *)base;
 	unsigned long flags;
 
 	if (!enable) {
-		swim_write(base, mode0, 0xf8);
+		swim_write(base, mode0, ACTION);
+		swim_write(base, mode0, ENBL1 | ENBL2 | MOTON);
+		swim_write(base, mode0, ISM_SELECT);
+		iwm_read(iwm_base, q7L);
 		return;
 	}
 
-	iwm_base = (struct iwm __iomem *)base;
 	local_irq_save(flags);
 
 	iwm_read(iwm_base, q7L);
+	iwm_read(iwm_base, q6L);
 	iwm_read(iwm_base, mtrOff);
 	iwm_read(iwm_base, q6H);
 
-- 
2.52.0


  parent reply	other threads:[~2026-08-17  1:55 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-17  1:17 [PATCH v2 00/32] block/swim: Fixes and improvements Finn Thain
2026-08-17  1:17 ` [PATCH v2 16/32] swim: Fix buffer overflow Finn Thain
2026-08-17  1:17 ` [PATCH v2 27/32] swim: Add some helpful references Finn Thain
2026-08-17  1:17 ` [PATCH v2 20/32] swim: Check drive ready bit Finn Thain
2026-08-17  1:17 ` [PATCH v2 01/32] swim: Assert strobe with stable outputs Finn Thain
2026-08-17  1:17 ` [PATCH v2 31/32] swim: Define symbols for constants Finn Thain
2026-08-17  1:17 ` [PATCH v2 12/32] swim: Simplify return value initialization Finn Thain
2026-08-17  1:17 ` [PATCH v2 23/32] swim: Don't needlessly re-read sectors Finn Thain
2026-08-17  1:17 ` [PATCH v2 26/32] swim: Move swd initialization Finn Thain
2026-08-17  1:17 ` [PATCH v2 24/32] swim: Don't search beyond the first data mark Finn Thain
2026-08-17  1:17 ` [PATCH v2 03/32] swim: Enable the drive when probing Finn Thain
2026-08-17  1:17 ` [PATCH v2 13/32] swim: Check for CRC errors Finn Thain
2026-08-17  1:17 ` [PATCH v2 25/32] swim: Remove pointless specifiers Finn Thain
2026-08-17  1:17 ` [PATCH v2 28/32] swim: Remove unused macro definitions Finn Thain
2026-08-17  1:17 ` [PATCH v2 32/32] swim: Unexport global symbols Finn Thain
2026-08-17  1:17 ` [PATCH v2 04/32] swim: Don't disable drive after every sector Finn Thain
2026-08-17  1:17 ` [PATCH v2 19/32] swim: Deduplicate polling loops Finn Thain
2026-08-17  1:17 ` [PATCH v2 11/32] swim: Handle FIFO timeout error Finn Thain
2026-08-17  1:17 ` [PATCH v2 29/32] swim: Clean up whitespace Finn Thain
2026-08-17  1:17 ` [PATCH v2 18/32] swim: Remove redundant RELAX actions Finn Thain
2026-08-17  1:17 ` [PATCH v2 30/32] swim: Define macros for constants Finn Thain
2026-08-17  1:17 ` [PATCH v2 22/32] swim: Remove pointless mode0 register write Finn Thain
2026-08-17  1:17 ` Finn Thain [this message]
2026-08-17  1:17 ` [PATCH v2 08/32] swim: Don't start motor until medium is present Finn Thain
2026-08-17  1:17 ` [PATCH v2 02/32] swim: Select appropriate drive once only Finn Thain
2026-08-17  1:17 ` [PATCH v2 15/32] swim: Don't use the mark register to read data Finn Thain
2026-08-17  1:17 ` [PATCH v2 09/32] swim: Recalibrate when drive is probed Finn Thain
2026-08-17  1:17 ` [PATCH v2 06/32] swim: Configure parameter memory Finn Thain
2026-08-17  1:17 ` [PATCH v2 07/32] swim: Enable clock divider only where appropriate Finn Thain
2026-08-31  7:38   ` Geert Uytterhoeven
2026-09-01  7:56     ` Finn Thain
2026-09-01  9:10       ` Geert Uytterhoeven
2026-08-17  1:17 ` [PATCH v2 17/32] swim: Convert to blocking queue Finn Thain
2026-08-17  1:17 ` [PATCH v2 21/32] swim: Revisit delays Finn Thain
2026-08-17  1:17 ` [PATCH v2 14/32] swim: Check error register during sector read Finn Thain
2026-08-17  1:17 ` [PATCH v2 10/32] swim: Add track zero recalibration delay Finn Thain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873207193565455585f3116bb0d4ce95b600ce3e.1786929430.git.fthain@linux-m68k.org \
    --to=fthain@linux-m68k.org \
    --cc=axboe@kernel.dk \
    --cc=funaho@jurai.org \
    --cc=geert@linux-m68k.org \
    --cc=laurent@vivier.eu \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox