* confusion about bio_split
@ 2018-01-15 3:25 Wang Sheng-Hui
2018-01-23 7:00 ` NeilBrown
0 siblings, 1 reply; 3+ messages in thread
From: Wang Sheng-Hui @ 2018-01-15 3:25 UTC (permalink / raw)
To: NeilBrown, axboe, linux-block
RGVhciwKClNvcnJ5IHRvIHRyb3VibGUgeW91LgoKSSdtIGNvbmZ1c2VkIGJ5IHRoZSBmb2xs
b3dpbmcgY29kZSBpbiBiaW8uYy9iaW9fc3BsaXQ6Ci0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0Kc3RydWN0IGJpbyAqYmlvX3NwbGl0KHN0cnVjdCBiaW8gKmJpbywg
aW50IHNlY3RvcnMsCi4uLgoJaWYgKGJpb19mbGFnZ2VkKGJpbywgQklPX1RSQUNFX0NPTVBM
RVRJT04pKQoJCWJpb19zZXRfZmxhZyhiaW8sIEJJT19UUkFDRV9DT01QTEVUSU9OKTsgICAg
ICAgICAKLi4uCn0KRVhQT1JUX1NZTUJPTChiaW9fc3BsaXQpOwotLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0KCkkgdGhpbmsgaXQgbWF5YmUgZmxhZyBvbiB0aGUgbmV3
IHNwbGl0IHNldCwgcmlnaHQ/CgoKUmVnYXJkcywKc2hlbmdodWk=
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: confusion about bio_split
2018-01-15 3:25 confusion about bio_split Wang Sheng-Hui
@ 2018-01-23 7:00 ` NeilBrown
2018-01-23 16:12 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: NeilBrown @ 2018-01-23 7:00 UTC (permalink / raw)
To: Wang Sheng-Hui, axboe, linux-block; +Cc: Goldwyn Rodrigues
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
On Mon, Jan 15 2018, Wang Sheng-Hui wrote:
> Dear,
>
> Sorry to trouble you.
>
> I'm confused by the following code in bio.c/bio_split:
> -------------------------------------
> struct bio *bio_split(struct bio *bio, int sectors,
> ...
> if (bio_flagged(bio, BIO_TRACE_COMPLETION))
> bio_set_flag(bio, BIO_TRACE_COMPLETION);
> ...
> }
> EXPORT_SYMBOL(bio_split);
> ------------------------------------
>
> I think it maybe flag on the new split set, right?
Goldwyn Rodrigues posted a patch to fix this a couple of
months ago.
Jens - can you apply that? Do you need it resent?
https://www.mail-archive.com/linux-block@vger.kernel.org/msg16039.html
Thanks,
NeilBrown
>
>
> Regards,
> shenghui
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: confusion about bio_split
2018-01-23 7:00 ` NeilBrown
@ 2018-01-23 16:12 ` Jens Axboe
0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2018-01-23 16:12 UTC (permalink / raw)
To: NeilBrown, Wang Sheng-Hui, linux-block; +Cc: Goldwyn Rodrigues
On 1/23/18 12:00 AM, NeilBrown wrote:
> On Mon, Jan 15 2018, Wang Sheng-Hui wrote:
>
>> Dear,
>>
>> Sorry to trouble you.
>>
>> I'm confused by the following code in bio.c/bio_split:
>> -------------------------------------
>> struct bio *bio_split(struct bio *bio, int sectors,
>> ...
>> if (bio_flagged(bio, BIO_TRACE_COMPLETION))
>> bio_set_flag(bio, BIO_TRACE_COMPLETION);
>> ...
>> }
>> EXPORT_SYMBOL(bio_split);
>> ------------------------------------
>>
>> I think it maybe flag on the new split set, right?
>
> Goldwyn Rodrigues posted a patch to fix this a couple of
> months ago.
> Jens - can you apply that? Do you need it resent?
>
> https://www.mail-archive.com/linux-block@vger.kernel.org/msg16039.html
I got it now, applied. Thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-23 16:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-15 3:25 confusion about bio_split Wang Sheng-Hui
2018-01-23 7:00 ` NeilBrown
2018-01-23 16:12 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox