* [PATCH] blk-cgroup: clean up after commit f1c006f1c685
@ 2024-01-04 18:00 Daniel Vacek
2024-01-04 21:57 ` Tejun Heo
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Daniel Vacek @ 2024-01-04 18:00 UTC (permalink / raw)
To: Tejun Heo, Josef Bacik, Jens Axboe
Cc: Daniel Vacek, cgroups, linux-block, linux-kernel
Commit f1c006f1c685 moved deletion of the list blkg->q_node
from blkg_destroy() to blkg_free_workfn(). Clean up the now
useless variable.
Signed-off-by: Daniel Vacek <neelx@redhat.com>
---
block/blk-cgroup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 4b48c2c440981..2f39bd7cb6db5 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -575,13 +575,13 @@ static void blkg_destroy(struct blkcg_gq *blkg)
static void blkg_destroy_all(struct gendisk *disk)
{
struct request_queue *q = disk->queue;
- struct blkcg_gq *blkg, *n;
+ struct blkcg_gq *blkg;
int count = BLKG_DESTROY_BATCH_SIZE;
int i;
restart:
spin_lock_irq(&q->queue_lock);
- list_for_each_entry_safe(blkg, n, &q->blkg_list, q_node) {
+ list_for_each_entry(blkg, &q->blkg_list, q_node) {
struct blkcg *blkcg = blkg->blkcg;
if (hlist_unhashed(&blkg->blkcg_node))
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] blk-cgroup: clean up after commit f1c006f1c685
2024-01-04 18:00 [PATCH] blk-cgroup: clean up after commit f1c006f1c685 Daniel Vacek
@ 2024-01-04 21:57 ` Tejun Heo
2024-01-04 23:06 ` Jens Axboe
2024-01-04 23:10 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2024-01-04 21:57 UTC (permalink / raw)
To: Daniel Vacek; +Cc: Josef Bacik, Jens Axboe, cgroups, linux-block, linux-kernel
On Thu, Jan 04, 2024 at 07:00:30PM +0100, Daniel Vacek wrote:
> Commit f1c006f1c685 moved deletion of the list blkg->q_node
> from blkg_destroy() to blkg_free_workfn(). Clean up the now
> useless variable.
>
> Signed-off-by: Daniel Vacek <neelx@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] blk-cgroup: clean up after commit f1c006f1c685
2024-01-04 18:00 [PATCH] blk-cgroup: clean up after commit f1c006f1c685 Daniel Vacek
2024-01-04 21:57 ` Tejun Heo
@ 2024-01-04 23:06 ` Jens Axboe
2024-01-04 23:10 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2024-01-04 23:06 UTC (permalink / raw)
To: Daniel Vacek, Tejun Heo, Josef Bacik; +Cc: cgroups, linux-block, linux-kernel
On 1/4/24 11:00 AM, Daniel Vacek wrote:
> Commit f1c006f1c685 moved deletion of the list blkg->q_node
> from blkg_destroy() to blkg_free_workfn(). Clean up the now
> useless variable.
I'll fix up your commit this time, but please take a look at
your title and tell me if you think it's a good one? Not
very descriptive, is it.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] blk-cgroup: clean up after commit f1c006f1c685
2024-01-04 18:00 [PATCH] blk-cgroup: clean up after commit f1c006f1c685 Daniel Vacek
2024-01-04 21:57 ` Tejun Heo
2024-01-04 23:06 ` Jens Axboe
@ 2024-01-04 23:10 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2024-01-04 23:10 UTC (permalink / raw)
To: Tejun Heo, Josef Bacik, Daniel Vacek; +Cc: cgroups, linux-block, linux-kernel
On Thu, 04 Jan 2024 19:00:30 +0100, Daniel Vacek wrote:
> Commit f1c006f1c685 moved deletion of the list blkg->q_node
> from blkg_destroy() to blkg_free_workfn(). Clean up the now
> useless variable.
>
>
Applied, thanks!
[1/1] blk-cgroup: clean up after commit f1c006f1c685
commit: fab4c16c527e24c804efa4992b3cf40438c9b227
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-04 23:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-04 18:00 [PATCH] blk-cgroup: clean up after commit f1c006f1c685 Daniel Vacek
2024-01-04 21:57 ` Tejun Heo
2024-01-04 23:06 ` Jens Axboe
2024-01-04 23:10 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox