Linux block layer
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>,
	linux-block@vger.kernel.org, Pankaj Raghav <p.raghav@samsung.com>,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Subject: brd in a memdesc world
Date: Tue, 12 Mar 2024 17:40:13 +0000	[thread overview]
Message-ID: <ZfCTfa9gfZwnCie0@casper.infradead.org> (raw)

Hi Jens,

I'm looking for an architecture-level decision on what the brd driver
should look like once struct page has been shrunk to a minimal size
(more detail at https://kernelnewbies.org/MatthewWilcox/Memdescs )

Currently brd uses page->index as a debugging check.  In the memdesc
future, struct page has no members (you could store a small amount of
information in it, but I'm not willing to commit to more than a few bits).

brd doesn't use anything else from struct page, as far as I can tell.
It just calls kmap_atomic() / __free_page() / flush_dcache_page() (and
it doesn't need to call flush_dcache_page() because you can't mmap the
pages in the brd's array).

Now if you have plans to, eg, support page migration, you're going to need
a bit more infrastructure than just allocating pages, but for what you
have at the moment, just removing the debugging checks that page->index ==
idx would make you entirely compatible with the memdesc future.

Any problem with that?

             reply	other threads:[~2024-03-12 17:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240312174020eucas1p29cf41360c934c674fd1f36a808078e25@eucas1p2.samsung.com>
2024-03-12 17:40 ` Matthew Wilcox [this message]
2024-03-13 17:15   ` brd in a memdesc world Pankaj Raghav
2024-03-13 18:28     ` Matthew Wilcox
2024-03-13 18:36       ` Pankaj Raghav
2024-03-13 19:17         ` Matthew Wilcox
2024-03-14 11:11       ` Hannes Reinecke
2024-03-14 14:15         ` Matthew Wilcox
2024-03-13 19:40   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZfCTfa9gfZwnCie0@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=p.raghav@samsung.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox