Linux block layer
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Pankaj Raghav <p.raghav@samsung.com>,
	Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	linux-block@vger.kernel.org,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Subject: Re: brd in a memdesc world
Date: Thu, 14 Mar 2024 14:15:47 +0000	[thread overview]
Message-ID: <ZfMGk_bu4wFRWJUZ@casper.infradead.org> (raw)
In-Reply-To: <886d8bde-e608-4e15-b13d-c891b4689b4f@suse.de>

On Thu, Mar 14, 2024 at 12:11:18PM +0100, Hannes Reinecke wrote:
> On 3/13/24 19:28, Matthew Wilcox wrote:
> > None of those things are needed for brd's uses.  All brd needs is to
> > be able to allocate, kmap and free chunks of memory.  Unless there are
> > plans to do more than this.
> 
> The primary goal of my patchset is to make brd a test-bed for the LBS work;
> devices with a sector size larger than 4k are really hard to come
> by. But really, it's just a testbed, and I'm not sure whether there's
> a need for that in the general audience.
> I can resubmit if you want ...
> 
> As for the memory overhead, I guess it only makes a noticable difference
> when moving to hugepages, and have brd allocate hugepages only.
> But that is future work for sure.

As I said, this is talking about a memdesc future where struct page is a
mere 8 bytes and most of its contents are reserved to the MM.  At this
point, there's no extra overhead to your patch, but there would be when
we get there.

So I don't think the folio conversion is necessary, but I think
supporting larger sector sizes in brd is a worthwhile extension.

  reply	other threads:[~2024-03-14 14:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240312174020eucas1p29cf41360c934c674fd1f36a808078e25@eucas1p2.samsung.com>
2024-03-12 17:40 ` brd in a memdesc world Matthew Wilcox
2024-03-13 17:15   ` Pankaj Raghav
2024-03-13 18:28     ` Matthew Wilcox
2024-03-13 18:36       ` Pankaj Raghav
2024-03-13 19:17         ` Matthew Wilcox
2024-03-14 11:11       ` Hannes Reinecke
2024-03-14 14:15         ` Matthew Wilcox [this message]
2024-03-13 19:40   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZfMGk_bu4wFRWJUZ@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=p.raghav@samsung.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox