Linux block layer
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Pankaj Raghav <p.raghav@samsung.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	linux-block@vger.kernel.org,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	Hannes Reinecke <hare@suse.de>
Subject: Re: brd in a memdesc world
Date: Wed, 13 Mar 2024 19:17:48 +0000	[thread overview]
Message-ID: <ZfH73MgTAK2BOFK6@casper.infradead.org> (raw)
In-Reply-To: <4605ebb7-2fcf-4570-b849-7aaa80a21954@samsung.com>

On Wed, Mar 13, 2024 at 07:36:01PM +0100, Pankaj Raghav wrote:
> Got it! Probably moving to folios just for the sake of retaining the
> debugging checks is not enough.

That would be my assessment, but maybe Jens has a different preference.

> > None of those things are needed for brd's uses.  All brd needs is to
> > be able to allocate, kmap and free chunks of memory.  Unless there are
> > plans to do more than this.
> 
> I remember he mentioned he wanted to support bigger logical block sizes
> in brd, in which case moving to folios might be justified.

Using folios (or some other data structure that embedded the order of
the allocation) would be justified if there was a proposal on the table
to support variable sized allocations in the brd XArray.  Hannes wasn't
suggesting that; his patch series used a fixed size per block device
(which honestly makes sense; I don't see the advantage to supporting
variable sized allocations).

  reply	other threads:[~2024-03-13 19:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240312174020eucas1p29cf41360c934c674fd1f36a808078e25@eucas1p2.samsung.com>
2024-03-12 17:40 ` brd in a memdesc world Matthew Wilcox
2024-03-13 17:15   ` Pankaj Raghav
2024-03-13 18:28     ` Matthew Wilcox
2024-03-13 18:36       ` Pankaj Raghav
2024-03-13 19:17         ` Matthew Wilcox [this message]
2024-03-14 11:11       ` Hannes Reinecke
2024-03-14 14:15         ` Matthew Wilcox
2024-03-13 19:40   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZfH73MgTAK2BOFK6@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=p.raghav@samsung.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox