* [PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro
@ 2024-06-03 0:23 Jeff Johnson
2024-06-03 0:53 ` Ming Lei
2024-07-10 6:23 ` Jens Axboe
0 siblings, 2 replies; 4+ messages in thread
From: Jeff Johnson @ 2024-06-03 0:23 UTC (permalink / raw)
To: Ming Lei, Jens Axboe
Cc: linux-block, linux-kernel, kernel-janitors, Jeff Johnson
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ublk_drv.o
Add the missing invocation of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/block/ublk_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
index 4e159948c912..59916895ee2e 100644
--- a/drivers/block/ublk_drv.c
+++ b/drivers/block/ublk_drv.c
@@ -3017,4 +3017,5 @@ module_param_cb(ublks_max, &ublk_max_ublks_ops, &ublks_max, 0644);
MODULE_PARM_DESC(ublks_max, "max number of ublk devices allowed to add(default: 64)");
MODULE_AUTHOR("Ming Lei <ming.lei@redhat.com>");
+MODULE_DESCRIPTION("Userspace block device");
MODULE_LICENSE("GPL");
---
base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
change-id: 20240602-md-block-ublk_drv-01507a0ba6fb
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro
2024-06-03 0:23 [PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro Jeff Johnson
@ 2024-06-03 0:53 ` Ming Lei
2024-07-09 20:00 ` Jeff Johnson
2024-07-10 6:23 ` Jens Axboe
1 sibling, 1 reply; 4+ messages in thread
From: Ming Lei @ 2024-06-03 0:53 UTC (permalink / raw)
To: Jeff Johnson; +Cc: Jens Axboe, linux-block, linux-kernel, kernel-janitors
On Sun, Jun 02, 2024 at 05:23:26PM -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ublk_drv.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/block/ublk_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
> index 4e159948c912..59916895ee2e 100644
> --- a/drivers/block/ublk_drv.c
> +++ b/drivers/block/ublk_drv.c
> @@ -3017,4 +3017,5 @@ module_param_cb(ublks_max, &ublk_max_ublks_ops, &ublks_max, 0644);
> MODULE_PARM_DESC(ublks_max, "max number of ublk devices allowed to add(default: 64)");
>
> MODULE_AUTHOR("Ming Lei <ming.lei@redhat.com>");
> +MODULE_DESCRIPTION("Userspace block device");
> MODULE_LICENSE("GPL");
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks,
Ming
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro
2024-06-03 0:53 ` Ming Lei
@ 2024-07-09 20:00 ` Jeff Johnson
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Johnson @ 2024-07-09 20:00 UTC (permalink / raw)
To: Ming Lei, Jens Axboe; +Cc: linux-block, linux-kernel, kernel-janitors
On 6/2/2024 5:53 PM, Ming Lei wrote:
> On Sun, Jun 02, 2024 at 05:23:26PM -0700, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ublk_drv.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>> drivers/block/ublk_drv.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
>> index 4e159948c912..59916895ee2e 100644
>> --- a/drivers/block/ublk_drv.c
>> +++ b/drivers/block/ublk_drv.c
>> @@ -3017,4 +3017,5 @@ module_param_cb(ublks_max, &ublk_max_ublks_ops, &ublks_max, 0644);
>> MODULE_PARM_DESC(ublks_max, "max number of ublk devices allowed to add(default: 64)");
>>
>> MODULE_AUTHOR("Ming Lei <ming.lei@redhat.com>");
>> +MODULE_DESCRIPTION("Userspace block device");
>> MODULE_LICENSE("GPL");
>
> Reviewed-by: Ming Lei <ming.lei@redhat.com>
I don't see this in linux-next yet so following up to see if anything else is
needed to get this merged.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro
2024-06-03 0:23 [PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-06-03 0:53 ` Ming Lei
@ 2024-07-10 6:23 ` Jens Axboe
1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2024-07-10 6:23 UTC (permalink / raw)
To: Ming Lei, Jeff Johnson; +Cc: linux-block, linux-kernel, kernel-janitors
On Sun, 02 Jun 2024 17:23:26 -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ublk_drv.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
>
Applied, thanks!
[1/1] ublk_drv: add missing MODULE_DESCRIPTION() macro
commit: c25a271c294b8f064f5628ea4fc3c6b8d47bf227
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-10 6:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-03 0:23 [PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-06-03 0:53 ` Ming Lei
2024-07-09 20:00 ` Jeff Johnson
2024-07-10 6:23 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox