* [PATCH] block: partitions: Use seq_buf_putc() in cmdline_partition()
@ 2026-06-25 8:08 Markus Elfring
2026-06-25 8:18 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2026-06-25 8:08 UTC (permalink / raw)
To: linux-block, Jens Axboe, Josh Law, Kees Cook
Cc: LKML, kernel-janitors, Andy Shevchenko, Woradorn Laodhanadhaworn
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 25 Jun 2026 09:50:33 +0200
A single line break should be put into a sequence buffer.
Thus use the corresponding function “seq_buf_putc”.
The source code was transformed by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
All affected source code places could be adjusted at once
if the change acceptance would evolve accordingly.
18 source files are left over for similar development considerations.
block/partitions/cmdline.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/block/partitions/cmdline.c b/block/partitions/cmdline.c
index 4fd52ed154b4..ce7488b3d2db 100644
--- a/block/partitions/cmdline.c
+++ b/block/partitions/cmdline.c
@@ -376,8 +376,6 @@ int cmdline_partition(struct parsed_partitions *state)
cmdline_parts_set(parts, disk_size, state);
cmdline_parts_verifier(1, state);
-
- seq_buf_puts(&state->pp_buf, "\n");
-
+ seq_buf_putc(&state->pp_buf, '\n');
return 1;
}
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] block: partitions: Use seq_buf_putc() in cmdline_partition()
2026-06-25 8:08 [PATCH] block: partitions: Use seq_buf_putc() in cmdline_partition() Markus Elfring
@ 2026-06-25 8:18 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-06-25 8:18 UTC (permalink / raw)
To: Markus Elfring
Cc: linux-block, Jens Axboe, Josh Law, Kees Cook, LKML,
kernel-janitors, Woradorn Laodhanadhaworn
On Thu, Jun 25, 2026 at 10:08:01AM +0200, Markus Elfring wrote:
>
> A single line break should be put into a sequence buffer.
> Thus use the corresponding function “seq_buf_putc”.
“seq_buf_putc()”.
> The source code was transformed by using the Coccinelle software.
...
> cmdline_parts_set(parts, disk_size, state);
> cmdline_parts_verifier(1, state);
> -
> - seq_buf_puts(&state->pp_buf, "\n");
> -
> + seq_buf_putc(&state->pp_buf, '\n');
Why did you remove blank lines?
> return 1;
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-25 8:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-25 8:08 [PATCH] block: partitions: Use seq_buf_putc() in cmdline_partition() Markus Elfring
2026-06-25 8:18 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox