* [PATCH] block: print symbolic error name instead of error code
@ 2024-01-11 23:15 Christian Heusel
2024-01-11 23:37 ` Damien Le Moal
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Christian Heusel @ 2024-01-11 23:15 UTC (permalink / raw)
To: Jens Axboe, Dave Chinner, Jan Kara, Thomas Weißschuh,
Christian Brauner, Min Li, Christian Heusel, Greg Kroah-Hartman,
Damien Le Moal, linux-block, linux-kernel
Cc: dan.carpenter, kernel-janitors
Utilize the %pe print specifier to get the symbolic error name as a
string (i.e "-ENOMEM") in the log message instead of the error code to
increase its readablility.
This change was suggested in
https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
Signed-off-by: Christian Heusel <christian@heusel.eu>
---
block/partitions/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/partitions/core.c b/block/partitions/core.c
index f47ffcfdfcec..932df4db76f1 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -570,8 +570,8 @@ static bool blk_add_partition(struct gendisk *disk,
part = add_partition(disk, p, from, size, state->parts[p].flags,
&state->parts[p].info);
if (IS_ERR(part) && PTR_ERR(part) != -ENXIO) {
- printk(KERN_ERR " %s: p%d could not be added: %ld\n",
- disk->disk_name, p, -PTR_ERR(part));
+ printk(KERN_ERR " %s: p%d could not be added: %pe\n",
+ disk->disk_name, p, part);
return true;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] block: print symbolic error name instead of error code
2024-01-11 23:15 [PATCH] block: print symbolic error name instead of error code Christian Heusel
@ 2024-01-11 23:37 ` Damien Le Moal
2024-01-11 23:56 ` Christian Heusel
2024-01-12 4:34 ` Chaitanya Kulkarni
2024-01-12 16:08 ` Jens Axboe
2 siblings, 1 reply; 6+ messages in thread
From: Damien Le Moal @ 2024-01-11 23:37 UTC (permalink / raw)
To: Christian Heusel, Jens Axboe, Dave Chinner, Jan Kara,
Thomas Weißschuh, Christian Brauner, Min Li,
Greg Kroah-Hartman, linux-block, linux-kernel
Cc: dan.carpenter, kernel-janitors
On 1/12/24 08:15, Christian Heusel wrote:
> Utilize the %pe print specifier to get the symbolic error name as a
> string (i.e "-ENOMEM") in the log message instead of the error code to
> increase its readablility.
>
> This change was suggested in
> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
>
> Signed-off-by: Christian Heusel <christian@heusel.eu>
> ---
> block/partitions/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/partitions/core.c b/block/partitions/core.c
> index f47ffcfdfcec..932df4db76f1 100644
> --- a/block/partitions/core.c
> +++ b/block/partitions/core.c
> @@ -570,8 +570,8 @@ static bool blk_add_partition(struct gendisk *disk,
> part = add_partition(disk, p, from, size, state->parts[p].flags,
> &state->parts[p].info);
> if (IS_ERR(part) && PTR_ERR(part) != -ENXIO) {
> - printk(KERN_ERR " %s: p%d could not be added: %ld\n",
> - disk->disk_name, p, -PTR_ERR(part));
> + printk(KERN_ERR " %s: p%d could not be added: %pe\n",
> + disk->disk_name, p, part);
pr_err() ?
> return true;
> }
>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Re: [PATCH] block: print symbolic error name instead of error code
2024-01-11 23:37 ` Damien Le Moal
@ 2024-01-11 23:56 ` Christian Heusel
2024-01-12 0:12 ` Jens Axboe
0 siblings, 1 reply; 6+ messages in thread
From: Christian Heusel @ 2024-01-11 23:56 UTC (permalink / raw)
To: Damien Le Moal
Cc: Jens Axboe, Dave Chinner, Jan Kara, Thomas Weißschuh,
Christian Brauner, Min Li, Greg Kroah-Hartman, linux-block,
linux-kernel, dan.carpenter, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 594 bytes --]
On 24/01/12 08:37AM, Damien Le Moal wrote:
> On 1/12/24 08:15, Christian Heusel wrote:
> > - printk(KERN_ERR " %s: p%d could not be added: %ld\n",
> > - disk->disk_name, p, -PTR_ERR(part));
> > + printk(KERN_ERR " %s: p%d could not be added: %pe\n",
> > + disk->disk_name, p, part);
>
> pr_err() ?
If desired I can send a v2 containing another patch which refactors the
usages of printk into their respective pr_* aliases, but I wanted to
keep this consistent to the usages in rest of the file and do one change
at a time.
Cheers,
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] block: print symbolic error name instead of error code
2024-01-11 23:56 ` Christian Heusel
@ 2024-01-12 0:12 ` Jens Axboe
0 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2024-01-12 0:12 UTC (permalink / raw)
To: Christian Heusel, Damien Le Moal
Cc: Dave Chinner, Jan Kara, Thomas Weißschuh, Christian Brauner,
Min Li, Greg Kroah-Hartman, linux-block, linux-kernel,
dan.carpenter, kernel-janitors
On 1/11/24 4:56 PM, Christian Heusel wrote:
> On 24/01/12 08:37AM, Damien Le Moal wrote:
>> On 1/12/24 08:15, Christian Heusel wrote:
>>> - printk(KERN_ERR " %s: p%d could not be added: %ld\n",
>>> - disk->disk_name, p, -PTR_ERR(part));
>>> + printk(KERN_ERR " %s: p%d could not be added: %pe\n",
>>> + disk->disk_name, p, part);
>>
>> pr_err() ?
>
> If desired I can send a v2 containing another patch which refactors the
> usages of printk into their respective pr_* aliases, but I wanted to
> keep this consistent to the usages in rest of the file and do one change
> at a time.
Yes let's please keep that separate, not a huge fan of conversions of that
anyway as it just causes backports or stable kernel issues.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] block: print symbolic error name instead of error code
2024-01-11 23:15 [PATCH] block: print symbolic error name instead of error code Christian Heusel
2024-01-11 23:37 ` Damien Le Moal
@ 2024-01-12 4:34 ` Chaitanya Kulkarni
2024-01-12 16:08 ` Jens Axboe
2 siblings, 0 replies; 6+ messages in thread
From: Chaitanya Kulkarni @ 2024-01-12 4:34 UTC (permalink / raw)
To: Christian Heusel, Jens Axboe, Dave Chinner, Jan Kara,
Thomas Weißschuh, Christian Brauner, Min Li,
Greg Kroah-Hartman, Damien Le Moal, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org
On 1/11/24 15:15, Christian Heusel wrote:
> Utilize the %pe print specifier to get the symbolic error name as a
> string (i.e "-ENOMEM") in the log message instead of the error code to
> increase its readablility.
>
> This change was suggested in
> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
>
> Signed-off-by: Christian Heusel <christian@heusel.eu>
> ---
>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] block: print symbolic error name instead of error code
2024-01-11 23:15 [PATCH] block: print symbolic error name instead of error code Christian Heusel
2024-01-11 23:37 ` Damien Le Moal
2024-01-12 4:34 ` Chaitanya Kulkarni
@ 2024-01-12 16:08 ` Jens Axboe
2 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2024-01-12 16:08 UTC (permalink / raw)
To: Dave Chinner, Jan Kara, Thomas Weißschuh, Christian Brauner,
Min Li, Greg Kroah-Hartman, Damien Le Moal, linux-block,
linux-kernel, Christian Heusel
Cc: dan.carpenter, kernel-janitors
On Fri, 12 Jan 2024 00:15:18 +0100, Christian Heusel wrote:
> Utilize the %pe print specifier to get the symbolic error name as a
> string (i.e "-ENOMEM") in the log message instead of the error code to
> increase its readablility.
>
> This change was suggested in
> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
>
> [...]
Applied, thanks!
[1/1] block: print symbolic error name instead of error code
commit: 25c1772a0493463408489b1fae65cf77fe46cac1
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-01-12 16:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-11 23:15 [PATCH] block: print symbolic error name instead of error code Christian Heusel
2024-01-11 23:37 ` Damien Le Moal
2024-01-11 23:56 ` Christian Heusel
2024-01-12 0:12 ` Jens Axboe
2024-01-12 4:34 ` Chaitanya Kulkarni
2024-01-12 16:08 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox