Linux block layer
 help / color / mirror / Atom feed
* [PATCH] scsi: core: update cdrom.h coments
@ 2026-10-20 17:06 Randy Dunlap
  2026-10-23 21:16 ` Phillip Potter
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Randy Dunlap @ 2026-10-20 17:06 UTC (permalink / raw)
  To: linux-scsi
  Cc: Randy Dunlap, James E.J. Bottomley, Martin K. Petersen,
	Phillip Potter, Jens Axboe, linux-block

Update the location and ending value of the cdrom ioctls.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: "Martin K. Petersen" <mkp@kernel.org>
Cc: Phillip Potter <phil@philpotter.co.uk>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org

 include/scsi/scsi.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20261019.orig/include/scsi/scsi.h
+++ linux-next-20261019/include/scsi/scsi.h
@@ -176,7 +176,7 @@ enum scsi_qc_status {
 /*
  * Here are some scsi specific ioctl commands which are sometimes useful.
  *
- * Note that include/linux/cdrom.h also defines IOCTL 0x5300 - 0x5395
+ * Note that include/uapi/linux/cdrom.h also defines IOCTL 0x5300 - 0x5396.
  */
 
 /* Used to obtain PUN and LUN info.  Conflicts with CDROMAUDIOBUFSIZ */

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: core: update cdrom.h coments
  2026-10-20 17:06 [PATCH] scsi: core: update cdrom.h coments Randy Dunlap
@ 2026-10-23 21:16 ` Phillip Potter
  2026-10-24  2:58 ` Martin K. Petersen
  2026-10-29  2:02 ` Martin K. Petersen (Oracle)
  2 siblings, 0 replies; 4+ messages in thread
From: Phillip Potter @ 2026-10-23 21:16 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: James E.J. Bottomley, Martin K. Petersen, Phillip Potter,
	Jens Axboe, linux-block

On Tue, Oct 20, 2026 at 10:06:03AM -0700, Randy Dunlap wrote:
> Update the location and ending value of the cdrom ioctls.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
> Cc: "Martin K. Petersen" <mkp@kernel.org>
> Cc: Phillip Potter <phil@philpotter.co.uk>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: linux-block@vger.kernel.org
> 
>  include/scsi/scsi.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20261019.orig/include/scsi/scsi.h
> +++ linux-next-20261019/include/scsi/scsi.h
> @@ -176,7 +176,7 @@ enum scsi_qc_status {
>  /*
>   * Here are some scsi specific ioctl commands which are sometimes useful.
>   *
> - * Note that include/linux/cdrom.h also defines IOCTL 0x5300 - 0x5395
> + * Note that include/uapi/linux/cdrom.h also defines IOCTL 0x5300 - 0x5396.
>   */
>  
>  /* Used to obtain PUN and LUN info.  Conflicts with CDROMAUDIOBUFSIZ */

Hi Randy,

Thanks for the patch. That said, without meaning to be too picky,
strictly speaking the quoted UAPI header file actually defines from
0x5301 onwards unless I'm missing something - perhaps we should change
the start of the range as well? Happy to adjust and forward on with your
other patch if you're happy with that?

Regards,
Phil

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: core: update cdrom.h coments
  2026-10-20 17:06 [PATCH] scsi: core: update cdrom.h coments Randy Dunlap
  2026-10-23 21:16 ` Phillip Potter
@ 2026-10-24  2:58 ` Martin K. Petersen
  2026-10-29  2:02 ` Martin K. Petersen (Oracle)
  2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2026-10-24  2:58 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-scsi, James E.J. Bottomley, Martin K. Petersen,
	Phillip Potter, Jens Axboe, linux-block


Randy,

> Update the location and ending value of the cdrom ioctls.

Adjusted start value and applied to 7.4/scsi-staging, thanks!

-- 
Martin K. Petersen

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: core: update cdrom.h coments
  2026-10-20 17:06 [PATCH] scsi: core: update cdrom.h coments Randy Dunlap
  2026-10-23 21:16 ` Phillip Potter
  2026-10-24  2:58 ` Martin K. Petersen
@ 2026-10-29  2:02 ` Martin K. Petersen (Oracle)
  2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen (Oracle) @ 2026-10-29  2:02 UTC (permalink / raw)
  To: linux-scsi, Randy Dunlap
  Cc: Martin K . Petersen, James E.J. Bottomley, Phillip Potter,
	Jens Axboe, linux-block

On Tue, 20 Oct 2026 10:06:03 -0700, Randy Dunlap wrote:

> Update the location and ending value of the cdrom ioctls.

Applied to 7.4/scsi-queue, thanks!

[1/1] scsi: core: update cdrom.h coments
      https://git.kernel.org/mkp/scsi/c/5b0d568e183e

-- 
Martin K. Petersen

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-10-29  2:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-20 17:06 [PATCH] scsi: core: update cdrom.h coments Randy Dunlap
2026-10-23 21:16 ` Phillip Potter
2026-10-24  2:58 ` Martin K. Petersen
2026-10-29  2:02 ` Martin K. Petersen (Oracle)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox