Re: [2.6 patch] net/bluetooth/: misc possible cleanups

Re: [2.6 patch] net/bluetooth/: misc possible cleanups

[Marcel Holtmann]

Hi Adrian,

> The patch below contains the following possible cleanups:
> - make needlessly global code static
> - remove the following EXPORT_SYMBOL'ed but unused functions in 
>   hci_core.c:
>   - hci_suspend_dev
>   - hci_resume_dev
>   - hci_register_cb
>   - hci_unregister_cb

these functions must stay. They have users outside the mainline kernel
that are not merged back yet. Otherwise they won't be exported ;)

> Please comment on which of these changes are correct and which conflict 
> with pending patches.

Please send a separate patch for all the RFCOMM changes, because these
conflicts with some pending patches and then it will make it easier for
me to merge them.

The rest of the changes are fine with me, but I like to see also a
separate patch for the CMTP stuff and cmtp_send_capimsg() don't need a
forward declaration. Simply move the function to another place in the
source code.

Regards

Marcel

Re: [2.6 patch] net/bluetooth/: misc possible cleanups

[Christoph Hellwig]

On Tue, Dec 14, 2004 at 08:34:08AM +0100, Marcel Holtmann wrote:
> these functions must stay. They have users outside the mainline kernel
> that are not merged back yet. Otherwise they won't be exported ;)

But we traditionally don't keep APIs only for the sake of external modules.
Exceptions are made if you have short- to mid-term plans to merge them.

Re: [2.6 patch] net/bluetooth/: misc possible cleanups

[Marcel Holtmann]

Hi Christoph,

> > these functions must stay. They have users outside the mainline kernel
> > that are not merged back yet. Otherwise they won't be exported ;)
> 
> But we traditionally don't keep APIs only for the sake of external modules.
> Exceptions are made if you have short- to mid-term plans to merge them.

it is a short term plan, because otherwise I won't have submitted it in
the first place. And as I said, they are not merged back yet. They are
not tested enough for mainline at the moment.

Regards

Marcel

Re: [2.6 patch] net/bluetooth/: misc possible cleanups

[Marcel Holtmann]

Hi Adrian,

> > > Please comment on which of these changes are correct and which conflict 
> > > with pending patches.
> > 
> > Please send a separate patch for all the RFCOMM changes, because these
> > conflicts with some pending patches and then it will make it easier for
> > me to merge them.
> > 
> > The rest of the changes are fine with me, but I like to see also a
> > separate patch for the CMTP stuff and cmtp_send_capimsg() don't need a
> > forward declaration. Simply move the function to another place in the
> > source code.
> 
> splitted patches follow as reply to this email.

all of them are applied to my tree now. Thanks.

Regards

Marcel