* Re: [2.6 patch] net/bluetooth/: misc possible cleanups
[not found] <20041214041352.GZ23151@stusta.de>
@ 2004-12-14 7:34 ` Marcel Holtmann
2004-12-14 9:45 ` Christoph Hellwig
[not found] ` <20041219160758.GY21288@stusta.de>
0 siblings, 2 replies; 4+ messages in thread
From: Marcel Holtmann @ 2004-12-14 7:34 UTC (permalink / raw)
To: Adrian Bunk
Cc: Max Krasnyansky, bluez-devel, Linux Kernel Mailing List,
Network Development Mailing List
Hi Adrian,
> The patch below contains the following possible cleanups:
> - make needlessly global code static
> - remove the following EXPORT_SYMBOL'ed but unused functions in
> hci_core.c:
> - hci_suspend_dev
> - hci_resume_dev
> - hci_register_cb
> - hci_unregister_cb
these functions must stay. They have users outside the mainline kernel
that are not merged back yet. Otherwise they won't be exported ;)
> Please comment on which of these changes are correct and which conflict
> with pending patches.
Please send a separate patch for all the RFCOMM changes, because these
conflicts with some pending patches and then it will make it easier for
me to merge them.
The rest of the changes are fine with me, but I like to see also a
separate patch for the CMTP stuff and cmtp_send_capimsg() don't need a
forward declaration. Simply move the function to another place in the
source code.
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [2.6 patch] net/bluetooth/: misc possible cleanups
2004-12-14 7:34 ` [2.6 patch] net/bluetooth/: misc possible cleanups Marcel Holtmann
@ 2004-12-14 9:45 ` Christoph Hellwig
2004-12-14 9:54 ` Marcel Holtmann
[not found] ` <20041219160758.GY21288@stusta.de>
1 sibling, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2004-12-14 9:45 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Adrian Bunk, Max Krasnyansky, bluez-devel,
Linux Kernel Mailing List, Network Development Mailing List
On Tue, Dec 14, 2004 at 08:34:08AM +0100, Marcel Holtmann wrote:
> these functions must stay. They have users outside the mainline kernel
> that are not merged back yet. Otherwise they won't be exported ;)
But we traditionally don't keep APIs only for the sake of external modules.
Exceptions are made if you have short- to mid-term plans to merge them.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [2.6 patch] net/bluetooth/: misc possible cleanups
2004-12-14 9:45 ` Christoph Hellwig
@ 2004-12-14 9:54 ` Marcel Holtmann
0 siblings, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2004-12-14 9:54 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Adrian Bunk, Max Krasnyansky, BlueZ Mailing List,
Linux Kernel Mailing List, Network Development Mailing List
Hi Christoph,
> > these functions must stay. They have users outside the mainline kernel
> > that are not merged back yet. Otherwise they won't be exported ;)
>
> But we traditionally don't keep APIs only for the sake of external modules.
> Exceptions are made if you have short- to mid-term plans to merge them.
it is a short term plan, because otherwise I won't have submitted it in
the first place. And as I said, they are not merged back yet. They are
not tested enough for mainline at the moment.
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20041219160758.GY21288@stusta.de>]
* Re: [2.6 patch] net/bluetooth/: misc possible cleanups
[not found] ` <20041219160758.GY21288@stusta.de>
@ 2004-12-26 11:20 ` Marcel Holtmann
0 siblings, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2004-12-26 11:20 UTC (permalink / raw)
To: Adrian Bunk
Cc: Max Krasnyansky, bluez-devel, Linux Kernel Mailing List,
Network Development Mailing List
Hi Adrian,
> > > Please comment on which of these changes are correct and which conflict
> > > with pending patches.
> >
> > Please send a separate patch for all the RFCOMM changes, because these
> > conflicts with some pending patches and then it will make it easier for
> > me to merge them.
> >
> > The rest of the changes are fine with me, but I like to see also a
> > separate patch for the CMTP stuff and cmtp_send_capimsg() don't need a
> > forward declaration. Simply move the function to another place in the
> > source code.
>
> splitted patches follow as reply to this email.
all of them are applied to my tree now. Thanks.
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-12-26 11:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20041214041352.GZ23151@stusta.de>
2004-12-14 7:34 ` [2.6 patch] net/bluetooth/: misc possible cleanups Marcel Holtmann
2004-12-14 9:45 ` Christoph Hellwig
2004-12-14 9:54 ` Marcel Holtmann
[not found] ` <20041219160758.GY21288@stusta.de>
2004-12-26 11:20 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox