From: Marcel Holtmann <marcel@holtmann.org>
To: Johan Hedberg <johan.hedberg@nokia.com>
Cc: BlueZ development <bluez-devel@lists.sourceforge.net>,
Fabien Chevalier <fchevalier@silicom.fr>
Subject: Re: [Bluez-devel] [PATCH] Fix bogus avdtp error codes management
Date: Tue, 18 Sep 2007 10:27:07 +0200 [thread overview]
Message-ID: <1190104027.5525.128.camel@aeonflux.holtmann.net> (raw)
In-Reply-To: <20070918081557.GA13401@localhost>
Hi Johan,
> > While trying to fix this cross case issue, i came with an issue with the
> > way error codes are handled
> > in avdtp.c.
> > The issue is basically that the part of the code that retrieves the
> > exact error value is never executed
> > due to premature return.
>
> Looks fine to me if it works. However, I'd like to hear some comment
> from Marcel as well. At least my connect(2) manpage implies that a
> non-blocking connect should always produce a POLLOUT on connection
> completion regardless if the result was failure or success. So it seems
> bluez may be behaving differently than other socket types in this
> respect.
if that is so, then we have to fix the kernel. Can someone write me a
simple reproducer or better send me a patch for the kernel.
Regards
Marcel
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
next prev parent reply other threads:[~2007-09-18 8:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 17:41 [PATCH] Fix bogus avdtp error codes management Fabien Chevalier
2007-09-18 8:15 ` Johan Hedberg
2007-09-18 8:27 ` Marcel Holtmann [this message]
2007-09-18 8:57 ` Fabien Chevalier
2007-09-18 9:09 ` Johan Hedberg
2007-09-18 12:00 ` [Bluez-devel] " Fabien Chevalier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190104027.5525.128.camel@aeonflux.holtmann.net \
--to=marcel@holtmann.org \
--cc=bluez-devel@lists.sourceforge.net \
--cc=fchevalier@silicom.fr \
--cc=johan.hedberg@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox