Re: [PATCH] Fix bogus avdtp error codes management

[Johan Hedberg <johan.hedberg@nokia.com>]

Hi Fabien,

On Mon, Sep 17, 2007, Fabien Chevalier wrote:
> While trying to fix this cross case issue, i came with an issue with the 
> way error codes are handled
> in avdtp.c.
> The issue is basically that the part of the code that retrieves the 
> exact error value is never executed
> due to premature return.

Looks fine to me if it works. However, I'd like to hear some comment
from Marcel as well. At least my connect(2) manpage implies that a
non-blocking connect should always produce a POLLOUT on connection
completion regardless if the result was failure or success. So it seems
bluez may be behaving differently than other socket types in this
respect.

We had a similar issue with the EAGAIN/EINPROGRESS mixup with
non-blocking connect's so maybe this issue should also be fixed on the
kernel side (however a userspace work-around such as your patch is
probably also desirable).

Johan