From: Johan Hedberg <johan.hedberg@nokia.com>
To: Fabien Chevalier <fchevalier@silicom.fr>
Cc: Marcel Holtmann <marcel@holtmann.org>,
BlueZ development <bluez-devel@lists.sourceforge.net>
Subject: Re: [PATCH] Fix bogus avdtp error codes management
Date: Tue, 18 Sep 2007 12:09:12 +0300 [thread overview]
Message-ID: <20070918090912.GA15007@localhost> (raw)
In-Reply-To: <46EF9302.50403@silicom.fr>
On Tue, Sep 18, 2007, Fabien Chevalier wrote:
> As for the POLLOUT thing, i must say i'm confused..., and don't really
> see the link with the patch :-(
> I guess it works already as the GIOChannels heavily rely on it.
GLib maps POLLOUT to G_IO_OUT, POLLHUP to G_IO_HUP, etc. I was saying
that to conform to how other socket types behave[1] the callback should
*not* be getting a HUP or ERR in this case but a OUT instead. As for
applying the patch, I'm fine with it even though it in essence is a
work-around for a kernel side problem. However, it's Marcel's call in
the end.
[1] I have yet to verify this but that's what the connect(2) manpage
implies (in the section about EINPROGRESS)
Johan
next prev parent reply other threads:[~2007-09-18 9:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 17:41 [PATCH] Fix bogus avdtp error codes management Fabien Chevalier
2007-09-18 8:15 ` Johan Hedberg
2007-09-18 8:27 ` [Bluez-devel] " Marcel Holtmann
2007-09-18 8:57 ` Fabien Chevalier
2007-09-18 9:09 ` Johan Hedberg [this message]
2007-09-18 12:00 ` [Bluez-devel] " Fabien Chevalier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070918090912.GA15007@localhost \
--to=johan.hedberg@nokia.com \
--cc=bluez-devel@lists.sourceforge.net \
--cc=fchevalier@silicom.fr \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox