[Bluez-devel] [PATCH] Add an ellipsis to the preferences menu item

[Bluez-devel] [PATCH] Add an ellipsis to the preferences menu item

[Chris Rivera]

[-- Attachment #1.1: Type: text/plain, Size: 165 bytes --]

Since the Preferences menu entry in the applet opens a new window it should
probably have an ellipsis in the label.  Attached is a trivial patch to add
this.

Chris

[-- Attachment #1.2: Type: text/html, Size: 185 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: bluez-gnome-pref-menu-item.patch --]
[-- Type: text/x-patch; name=bluez-gnome-pref-menu-item.patch, Size: 846 bytes --]

Index: applet/main.c
===================================================================
RCS file: /cvsroot/bluez/gnome/applet/main.c,v
retrieving revision 1.87
diff -u -r1.87 main.c
--- applet/main.c	29 Aug 2007 20:42:18 -0000	1.87
+++ applet/main.c	25 Oct 2007 19:13:47 -0000
@@ -1675,12 +1675,15 @@
 {
 	GtkWidget *menu;
 	GtkWidget *item;
+	GtkWidget *image;
 
 	menu = gtk_menu_new();
 
-	item = gtk_image_menu_item_new_from_stock(GTK_STOCK_PREFERENCES, NULL);
+	item = gtk_image_menu_item_new_with_mnemonic (_("_Preferences..."));
 	g_signal_connect(item, "activate",
 				G_CALLBACK(settings_callback), NULL);
+	image = gtk_image_new_from_stock (GTK_STOCK_PREFERENCES, GTK_ICON_SIZE_MENU);
+	gtk_image_menu_item_set_image (GTK_IMAGE_MENU_ITEM (item), image);
 	gtk_widget_show(item);
 	gtk_menu_shell_append(GTK_MENU_SHELL(menu), item);
 

[-- Attachment #3: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Add an ellipsis to the preferences menu item

[Marcel Holtmann]

Hi Chris,

> Since the Preferences menu entry in the applet opens a new window it
> should probably have an ellipsis in the label.  Attached is a trivial
> patch to add this.

what does the HIG recommend for applet menus. I wanna follow the HIG.
Currently I simply did what all other applets do that I have running.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Add an ellipsis to the preferences menu item

[Chris Rivera]

[-- Attachment #1.1: Type: text/plain, Size: 1172 bytes --]

Agreed.  We need to follow the HIG.  According to:

http://developer.gnome.org/projects/gup/hig/hig-diff/menus-design.html

the ellipsis should be in place only if it _requires_ further input from the
user.  I guess the ellipsis isn't necessary.

Chris

On 10/25/07, Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Chris,
>
> > Since the Preferences menu entry in the applet opens a new window it
> > should probably have an ellipsis in the label.  Attached is a trivial
> > patch to add this.
>
> what does the HIG recommend for applet menus. I wanna follow the HIG.
> Currently I simply did what all other applets do that I have running.
>
> Regards
>
> Marcel
>
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> _______________________________________________
> Bluez-devel mailing list
> Bluez-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bluez-devel
>

[-- Attachment #1.2: Type: text/html, Size: 1800 bytes --]

[-- Attachment #2: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Add an ellipsis to the preferences menu item

[Bastien Nocera]

On Fri, 2007-10-26 at 00:44 +0200, Marcel Holtmann wrote:
> Hi Chris,
> 
> > Since the Preferences menu entry in the applet opens a new window it
> > should probably have an ellipsis in the label.  Attached is a trivial
> > patch to add this.
> 
> what does the HIG recommend for applet menus. I wanna follow the HIG.
> Currently I simply did what all other applets do that I have running.

This one is a toss-up between what's right, and what GTK+ implements. It
doesn't have separate strings for menus, so you don't get the ellipsis.

I'm sure there's a GTK+ bug opened somewhere about "doing the right
thing" in the case of stock items.

So it's really up to you. Personally, I'd stick with the stock item,
unless you have a wide-ranging amount of translations (which you'd get
if you moved bluez-gnome to GNOME SVN, hint hint :)


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Add an ellipsis to the preferences menu item

[Marcel Holtmann]

Hi Bastien,

> > > Since the Preferences menu entry in the applet opens a new window it
> > > should probably have an ellipsis in the label.  Attached is a trivial
> > > patch to add this.
> > 
> > what does the HIG recommend for applet menus. I wanna follow the HIG.
> > Currently I simply did what all other applets do that I have running.
> 
> This one is a toss-up between what's right, and what GTK+ implements. It
> doesn't have separate strings for menus, so you don't get the ellipsis.
> 
> I'm sure there's a GTK+ bug opened somewhere about "doing the right
> thing" in the case of stock items.
> 
> So it's really up to you. Personally, I'd stick with the stock item,
> unless you have a wide-ranging amount of translations (which you'd get
> if you moved bluez-gnome to GNOME SVN, hint hint :)

I stick with the stock item. Makes stuff simpler.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel