public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: BlueZ development <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] [PATCH] [RESEND] make bluez GNOME UIs singletons
Date: Mon, 17 Dec 2007 19:53:03 +0100	[thread overview]
Message-ID: <1197917583.8050.87.camel@aeonflux> (raw)
In-Reply-To: <5f84803c0712170754n14d401a7l225d3d9b2f413850@mail.gmail.com>

Hi Chris,

> Updated patches attached.

I added the generic singleton instance patch to the CVS. I did some
minor modifications. The interface name is org.bluez.Instance. No need
to duplicate the word Bluetooth here. And I removed the retval parameter
from the register function. It is useless. Use the return value for it.
If it is TRUE, everything is okay. If FALSE, cleanup and exit(1).

Please update the application patches and resend them. And double check
the whitespace stuff. I had to fix some of them in your other patch. Use
an editor that has a visual representation of tabs and whitespaces. It
really helps.

Regards

Marcel



-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

  reply	other threads:[~2007-12-17 18:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-03 15:33 [Bluez-devel] [PATCH] [RESEND] make bluez GNOME UIs singletons Chris Rivera
2007-12-03 16:25 ` Marcel Holtmann
2007-12-03 16:50   ` Chris Rivera
2007-12-03 16:59     ` Marcel Holtmann
2007-12-06 17:59       ` Chris Rivera
2007-12-17  3:08         ` Chris Rivera
2007-12-17  5:47         ` Marcel Holtmann
2007-12-17 15:54           ` Chris Rivera
2007-12-17 18:53             ` Marcel Holtmann [this message]
2007-12-17 19:29               ` Chris Rivera
2007-12-17 20:17                 ` Marcel Holtmann
2007-12-17 20:47                   ` Chris Rivera
2007-12-17 21:01                     ` Marcel Holtmann
2007-12-18 18:37                       ` Chris Rivera
2007-12-18 19:10                         ` Marcel Holtmann
2007-12-18 19:51                           ` Chris Rivera
2007-12-18 19:58                             ` Marcel Holtmann
2007-12-18 20:52                               ` Bastien Nocera
2007-12-18 21:00                                 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1197917583.8050.87.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox