[Bluez-devel] [PATCH] Use new tango icon for bluez gnome

[Bluez-devel] [PATCH] Use new tango icon for bluez gnome

[Jaap A. Haitsma]

Hi Marcel,

Andreas Nilson has made new tango icons for bluez-gnome. (The
stock_bluetooth icon will be removed from gnome-icon-theme, because
it's deprecated)

I've added the Makefiles and made a patch for the code changes. You
can find everything overhere


http://bugzilla.gnome.org/show_bug.cgi?id=506133


Jaap

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Use new tango icon for bluez gnome

[Marcel Holtmann]

Hi Jaap,

> Andreas Nilson has made new tango icons for bluez-gnome. (The
> stock_bluetooth icon will be removed from gnome-icon-theme, because
> it's deprecated)

do icons really should belong in the package itself. I was under the
impression that it is better to have them in a common package and the
applications are going to reference them only. I am happy to follow the
GNOME policy here, but someone has to tell me what is the current way to
go for these.

If we are re-working the icon anyway, then I like to request a grayed
out icon (for disabled or inactive adapters) and one that indicates an
active state. For example with yellow instead of white for the bind
rune.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Use new tango icon for bluez gnome

[Jaap A. Haitsma]

On Feb 10, 2008 5:01 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Jaap,
>
> > Andreas Nilson has made new tango icons for bluez-gnome. (The
> > stock_bluetooth icon will be removed from gnome-icon-theme, because
> > it's deprecated)
>
> do icons really should belong in the package itself. I was under the
> impression that it is better to have them in a common package and the
> applications are going to reference them only. I am happy to follow the
> GNOME policy here, but someone has to tell me what is the current way to
> go for these.

The GNOME policy is that only the icons of the icon naming
specification [1] will be in gnome icon theme. Apps have to ship there
own icons.


> If we are re-working the icon anyway, then I like to request a grayed
> out icon (for disabled or inactive adapters) and one that indicates an
> active state. For example with yellow instead of white for the bind
> rune.
>
Shall we start with applying this patch? It makes bluez-gnome blend in
better with current desktops and we don't depend on gnome-icon-theme
anymore. There is already a request to remove the stock_bluetooth icon
[2]

I'll ask Andreas if he can cook up bluetooth-enabled and
bluetooth-disabled icons

Jaap

[1] http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html
[2] http://bugzilla.gnome.org/show_bug.cgi?id=505116

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Use new tango icon for bluez gnome

[Marcel Holtmann]

Hi Jaap,

> > > Andreas Nilson has made new tango icons for bluez-gnome. (The
> > > stock_bluetooth icon will be removed from gnome-icon-theme, because
> > > it's deprecated)
> >
> > do icons really should belong in the package itself. I was under the
> > impression that it is better to have them in a common package and the
> > applications are going to reference them only. I am happy to follow the
> > GNOME policy here, but someone has to tell me what is the current way to
> > go for these.
> 
> The GNOME policy is that only the icons of the icon naming
> specification [1] will be in gnome icon theme. Apps have to ship there
> own icons.

why don't we make the Bluetooth icons then part of the icon naming
specification?

> > If we are re-working the icon anyway, then I like to request a grayed
> > out icon (for disabled or inactive adapters) and one that indicates an
> > active state. For example with yellow instead of white for the bind
> > rune.
> >
> Shall we start with applying this patch? It makes bluez-gnome blend in
> better with current desktops and we don't depend on gnome-icon-theme
> anymore. There is already a request to remove the stock_bluetooth icon
> [2]
> 
> I'll ask Andreas if he can cook up bluetooth-enabled and
> bluetooth-disabled icons

I would like to do it all in one run. Since we depend now on the
notifications, we can actually better use the blinking capability and
create better visibility for the end user.

Ask Andreas how long it would take. I am not an graphics guy at all. So
I would have no clue.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Use new tango icon for bluez gnome

[Jaap A. Haitsma]

On Feb 10, 2008 5:42 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Jaap,
>
> > > > Andreas Nilson has made new tango icons for bluez-gnome. (The
> > > > stock_bluetooth icon will be removed from gnome-icon-theme, because
> > > > it's deprecated)
> > >
> > > do icons really should belong in the package itself. I was under the
> > > impression that it is better to have them in a common package and the
> > > applications are going to reference them only. I am happy to follow the
> > > GNOME policy here, but someone has to tell me what is the current way to
> > > go for these.
> >
> > The GNOME policy is that only the icons of the icon naming
> > specification [1] will be in gnome icon theme. Apps have to ship there
> > own icons.
>
> why don't we make the Bluetooth icons then part of the icon naming
> specification?
>

I agree with you that it makes sense, but Rodney Dawes the icon naming
spec and gnome icon theme maintainer thinks it doesn't make sense. See
http://bugzilla.gnome.org/show_bug.cgi?id=505116
I've tried to convince him several times of including some icons, but
he's very keen on keeping the icon set as minimal as possible. You can
try if you want.


> > > If we are re-working the icon anyway, then I like to request a grayed
> > > out icon (for disabled or inactive adapters) and one that indicates an
> > > active state. For example with yellow instead of white for the bind
> > > rune.
> > >
> > Shall we start with applying this patch? It makes bluez-gnome blend in
> > better with current desktops and we don't depend on gnome-icon-theme
> > anymore. There is already a request to remove the stock_bluetooth icon
> > [2]
> >
> > I'll ask Andreas if he can cook up bluetooth-enabled and
> > bluetooth-disabled icons

Done

>
> I would like to do it all in one run. Since we depend now on the
> notifications, we can actually better use the blinking capability and
> create better visibility for the end user.
>
> Ask Andreas how long it would take. I am not an graphics guy at all. So
> I would have no clue.
>

You could do me a favor by applying the patch. Now and then I have to
feel that the time I put in patches is appreciated.

Patches have the tendency not to apply cleanly anymore after a while
and thus lead to more work.

Even with your suggested enhancements (having enabled/disabled icons)
this patch still applies. If you manage to convince Rodney to get the
icons in gnome-icon-theme I'll send you the necessary patch.

Thanks
Jaap

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Use new tango icon for bluez gnome

[Marcel Holtmann]

Hi Jaap,

> > > > > Andreas Nilson has made new tango icons for bluez-gnome. (The
> > > > > stock_bluetooth icon will be removed from gnome-icon-theme, because
> > > > > it's deprecated)
> > > >
> > > > do icons really should belong in the package itself. I was under the
> > > > impression that it is better to have them in a common package and the
> > > > applications are going to reference them only. I am happy to follow the
> > > > GNOME policy here, but someone has to tell me what is the current way to
> > > > go for these.
> > >
> > > The GNOME policy is that only the icons of the icon naming
> > > specification [1] will be in gnome icon theme. Apps have to ship there
> > > own icons.
> >
> > why don't we make the Bluetooth icons then part of the icon naming
> > specification?
> >
> 
> I agree with you that it makes sense, but Rodney Dawes the icon naming
> spec and gnome icon theme maintainer thinks it doesn't make sense. See
> http://bugzilla.gnome.org/show_bug.cgi?id=505116
> I've tried to convince him several times of including some icons, but
> he's very keen on keeping the icon set as minimal as possible. You can
> try if you want.

I don't even bother. Eventually they change their mind back and I am not
getting in their way. I couldn't care less.

> > I would like to do it all in one run. Since we depend now on the
> > notifications, we can actually better use the blinking capability and
> > create better visibility for the end user.
> >
> > Ask Andreas how long it would take. I am not an graphics guy at all. So
> > I would have no clue.
> >
> 
> You could do me a favor by applying the patch. Now and then I have to
> feel that the time I put in patches is appreciated.
> 
> Patches have the tendency not to apply cleanly anymore after a while
> and thus lead to more work.
> 
> Even with your suggested enhancements (having enabled/disabled icons)
> this patch still applies. If you manage to convince Rodney to get the
> icons in gnome-icon-theme I'll send you the necessary patch.

I did my own patch to handle the update-icon-cache thing properly in
cases of distcheck and the maintainers.

For now I also only included the 22x22 icons. Still have to re-think the
file structure. Would be nice if we had some nice templates for doing
this properly within one directory.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Use new tango icon for bluez gnome

[Jaap A. Haitsma]

>
> I did my own patch to handle the update-icon-cache thing properly in
> cases of distcheck and the maintainers.
>
> For now I also only included the 22x22 icons. Still have to re-think the
> file structure. Would be nice if we had some nice templates for doing
> this properly within one directory.
>
Here's a template
Take a look at how vinagre does this

http://svn.gnome.org/viewvc/vinagre/trunk/data/icons/

Jaap

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Use new tango icon for bluez gnome

[Jaap A. Haitsma]

>
> I did my own patch to handle the update-icon-cache thing properly in
> cases of distcheck and the maintainers.
>
> For now I also only included the 22x22 icons. Still have to re-think the
> file structure. Would be nice if we had some nice templates for doing
> this properly within one directory.
>
Hi Marcel,

Just looked in CVS to your patch you are installing the an SVG of
22x22 into the scalable directory. That SVG should not be installed.
It should be just in CVS such that artists can make updates to the
icons. You need to install the SVG which in my tarball is in the
scalable directory (it has a size of 48x48)

Jaap

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Use new tango icon for bluez gnome

[Marcel Holtmann]

Hi Jaap,

> > I did my own patch to handle the update-icon-cache thing properly in
> > cases of distcheck and the maintainers.
> >
> > For now I also only included the 22x22 icons. Still have to re-think the
> > file structure. Would be nice if we had some nice templates for doing
> > this properly within one directory.
> >
> Here's a template
> Take a look at how vinagre does this
> 
> http://svn.gnome.org/viewvc/vinagre/trunk/data/icons/

did it this way. Some nice autoconf/automake macros for it in some
generic way would be nice. Found actually some bugs talking about it,
but nobody did it.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Use new tango icon for bluez gnome

[Marcel Holtmann]

Hi Jaap,

> > I did my own patch to handle the update-icon-cache thing properly in
> > cases of distcheck and the maintainers.
> >
> > For now I also only included the 22x22 icons. Still have to re-think the
> > file structure. Would be nice if we had some nice templates for doing
> > this properly within one directory.
> >
> Hi Marcel,
> 
> Just looked in CVS to your patch you are installing the an SVG of
> 22x22 into the scalable directory. That SVG should not be installed.
> It should be just in CVS such that artists can make updates to the
> icons. You need to install the SVG which in my tarball is in the
> scalable directory (it has a size of 48x48)

fixed that. However I am not happy with the status icon. I think it
looks ugly. Kinda blurry. The other icons look great.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Use new tango icon for bluez gnome

[Jaap A. Haitsma]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

>
> fixed that. However I am not happy with the status icon. I think it
> looks ugly. Kinda blurry. The other icons look great.
>
Hi Marcel

Great you fixed it. I looks fine here. See attachment. I prefer this
icon over the old because it uses the
same palette and styling as the other icons

Jaap

[-- Attachment #2: Screenshot.png --]
[-- Type: image/png, Size: 6678 bytes --]

[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #4: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Use new tango icon for bluez gnome

[Marcel Holtmann]

Hi Jaap,

> > fixed that. However I am not happy with the status icon. I think it
> > looks ugly. Kinda blurry. The other icons look great.
> >
>
> Great you fixed it. I looks fine here. See attachment. I prefer this
> icon over the old because it uses the
> same palette and styling as the other icons

as I said, I like the new icon. However in my system it looks pretty
bad. However it is only the status icon. The others look fine.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel