* [PATCH 3/7] bluetooth: Add quirks for a few hci_usb devices [not found] <24762.90.138.930.038.1036103001.ben.collins@canonical.com> @ 2008-07-21 1:45 ` Ben Collins 2008-07-21 5:08 ` Marcel Holtmann 0 siblings, 1 reply; 5+ messages in thread From: Ben Collins @ 2008-07-21 1:45 UTC (permalink / raw) To: linux-kernel; +Cc: linux-bluetooth When the Dell 370 and 410 BT adapters are put into BT radio mode, they need to be prepared like many other Broadcom adapters. Also, add quirk Broadcom 2046 devices with HCI_RESET. CC: linux-bluetooth@vger.kernel.org Signed-off-by: Michael Frey <michael.frey@canonical.com> Signed-off-by: Mario Limonciello <Mario_Limonciello@Dell.com> Signed-off-by: Tim Gardner <tim.gardner@canonical.com> Signed-off-by: Ben Collins <ben.collins@canonical.com> --- drivers/bluetooth/hci_usb.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/bluetooth/hci_usb.c b/drivers/bluetooth/hci_usb.c index 192522e..0254a6b 100644 --- a/drivers/bluetooth/hci_usb.c +++ b/drivers/bluetooth/hci_usb.c @@ -134,6 +134,13 @@ static struct usb_device_id blacklist_ids[] = { /* Dell laptop with Broadcom chip */ { USB_DEVICE(0x413c, 0x8126), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU }, + /* Dell Wireless 370 */ + { USB_DEVICE(0x413c, 0x8156), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU }, + /* Dell Wireless 410 */ + { USB_DEVICE(0x413c, 0x8152), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU }, + + /* Broadcom 2046 */ + { USB_DEVICE(0x0a5c, 0x2151), .driver_info = HCI_RESET }, /* Microsoft Wireless Transceiver for Bluetooth 2.0 */ { USB_DEVICE(0x045e, 0x009c), .driver_info = HCI_RESET }, -- 1.5.4.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 3/7] bluetooth: Add quirks for a few hci_usb devices 2008-07-21 1:45 ` [PATCH 3/7] bluetooth: Add quirks for a few hci_usb devices Ben Collins @ 2008-07-21 5:08 ` Marcel Holtmann 2008-07-21 5:54 ` Ben Collins 2008-07-21 16:00 ` Ben Collins 0 siblings, 2 replies; 5+ messages in thread From: Marcel Holtmann @ 2008-07-21 5:08 UTC (permalink / raw) To: Ben Collins; +Cc: linux-kernel, linux-bluetooth Hi Ben, > When the Dell 370 and 410 BT adapters are put into BT radio mode, they > need to be prepared like many other Broadcom adapters. > > Also, add quirk Broadcom 2046 devices with HCI_RESET. > > CC: linux-bluetooth@vger.kernel.org > Signed-off-by: Michael Frey <michael.frey@canonical.com> > Signed-off-by: Mario Limonciello <Mario_Limonciello@Dell.com> > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > Signed-off-by: Ben Collins <ben.collins@canonical.com> > --- > drivers/bluetooth/hci_usb.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/bluetooth/hci_usb.c b/drivers/bluetooth/hci_usb.c > index 192522e..0254a6b 100644 > --- a/drivers/bluetooth/hci_usb.c > +++ b/drivers/bluetooth/hci_usb.c > @@ -134,6 +134,13 @@ static struct usb_device_id blacklist_ids[] = { > > /* Dell laptop with Broadcom chip */ > { USB_DEVICE(0x413c, 0x8126), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU }, > + /* Dell Wireless 370 */ > + { USB_DEVICE(0x413c, 0x8156), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU }, > + /* Dell Wireless 410 */ > + { USB_DEVICE(0x413c, 0x8152), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU }, > + > + /* Broadcom 2046 */ > + { USB_DEVICE(0x0a5c, 0x2151), .driver_info = HCI_RESET }, do me a favor and use tabs and not whitespaces here. And is this the latest Apple machine that has a Broadcom instead of a CSR chip in it. If so, then let the comment reflect this. Regards Marcel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/7] bluetooth: Add quirks for a few hci_usb devices 2008-07-21 5:08 ` Marcel Holtmann @ 2008-07-21 5:54 ` Ben Collins 2008-07-21 16:00 ` Ben Collins 1 sibling, 0 replies; 5+ messages in thread From: Ben Collins @ 2008-07-21 5:54 UTC (permalink / raw) To: Marcel Holtmann; +Cc: linux-kernel, linux-bluetooth On Mon, 2008-07-21 at 07:08 +0200, Marcel Holtmann wrote: > Hi Ben, > > > When the Dell 370 and 410 BT adapters are put into BT radio mode, they > > need to be prepared like many other Broadcom adapters. > > > > Also, add quirk Broadcom 2046 devices with HCI_RESET. > > > > CC: linux-bluetooth@vger.kernel.org > > Signed-off-by: Michael Frey <michael.frey@canonical.com> > > Signed-off-by: Mario Limonciello <Mario_Limonciello@Dell.com> > > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > > Signed-off-by: Ben Collins <ben.collins@canonical.com> > > --- > > drivers/bluetooth/hci_usb.c | 7 +++++++ > > 1 files changed, 7 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/bluetooth/hci_usb.c b/drivers/bluetooth/hci_usb.c > > index 192522e..0254a6b 100644 > > --- a/drivers/bluetooth/hci_usb.c > > +++ b/drivers/bluetooth/hci_usb.c > > @@ -134,6 +134,13 @@ static struct usb_device_id blacklist_ids[] = { > > > > /* Dell laptop with Broadcom chip */ > > { USB_DEVICE(0x413c, 0x8126), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU }, > > + /* Dell Wireless 370 */ > > + { USB_DEVICE(0x413c, 0x8156), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU }, > > + /* Dell Wireless 410 */ > > + { USB_DEVICE(0x413c, 0x8152), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU }, > > + > > + /* Broadcom 2046 */ > > + { USB_DEVICE(0x0a5c, 0x2151), .driver_info = HCI_RESET }, > > do me a favor and use tabs and not whitespaces here. And is this the > latest Apple machine that has a Broadcom instead of a CSR chip in it. If > so, then let the comment reflect this. Whoops. That slipped through. I've no idea what system that device actually came from. I'd have to ask Michael, since he was the one who reported it. I'll resend a corrected patch in the morning. Thanks Marcel. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/7] bluetooth: Add quirks for a few hci_usb devices 2008-07-21 5:08 ` Marcel Holtmann 2008-07-21 5:54 ` Ben Collins @ 2008-07-21 16:00 ` Ben Collins 2008-07-21 23:30 ` Marcel Holtmann 1 sibling, 1 reply; 5+ messages in thread From: Ben Collins @ 2008-07-21 16:00 UTC (permalink / raw) To: Marcel Holtmann; +Cc: linux-kernel, linux-bluetooth Preface: The "Broadcom" device is on unreleased hardware, so I can't disclose the actual model. When the Dell 370 and 410 BT adapters are put into BT radio mode, they need to be prepared like many other Broadcom adapters. Also, add quirk Broadcom 2046 devices with HCI_RESET. Reference for this bug: https://launchpad.net/bugs/249448 CC: linux-bluetooth@vger.kernel.org Signed-off-by: Michael Frey <michael.frey@canonical.com> Signed-off-by: Mario Limonciello <Mario_Limonciello@Dell.com> Signed-off-by: Tim Gardner <tim.gardner@canonical.com> Signed-off-by: Ben Collins <ben.collins@canonical.com> diff --git a/drivers/bluetooth/hci_usb.c b/drivers/bluetooth/hci_usb.c index 192522e..c33bb59 100644 --- a/drivers/bluetooth/hci_usb.c +++ b/drivers/bluetooth/hci_usb.c @@ -134,6 +134,13 @@ static struct usb_device_id blacklist_ids[] = { /* Dell laptop with Broadcom chip */ { USB_DEVICE(0x413c, 0x8126), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU }, + /* Dell Wireless 370 */ + { USB_DEVICE(0x413c, 0x8156), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU }, + /* Dell Wireless 410 */ + { USB_DEVICE(0x413c, 0x8152), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU }, + + /* Broadcom 2046 */ + { USB_DEVICE(0x0a5c, 0x2151), .driver_info = HCI_RESET }, /* Microsoft Wireless Transceiver for Bluetooth 2.0 */ { USB_DEVICE(0x045e, 0x009c), .driver_info = HCI_RESET }, ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 3/7] bluetooth: Add quirks for a few hci_usb devices 2008-07-21 16:00 ` Ben Collins @ 2008-07-21 23:30 ` Marcel Holtmann 0 siblings, 0 replies; 5+ messages in thread From: Marcel Holtmann @ 2008-07-21 23:30 UTC (permalink / raw) To: Ben Collins; +Cc: linux-kernel, linux-bluetooth Hi Ben, > Preface: The "Broadcom" device is on unreleased hardware, so I can't > disclose the actual model. then put on your todo list to update this entry once you can. > When the Dell 370 and 410 BT adapters are put into BT radio mode, they > need to be prepared like many other Broadcom adapters. > > Also, add quirk Broadcom 2046 devices with HCI_RESET. Reference for > this > bug: https://launchpad.net/bugs/249448 > > CC: linux-bluetooth@vger.kernel.org > Signed-off-by: Michael Frey <michael.frey@canonical.com> > Signed-off-by: Mario Limonciello <Mario_Limonciello@Dell.com> > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > Signed-off-by: Ben Collins <ben.collins@canonical.com> Acked-by: Marcel Holtmann <marcel@holtmann.org> Regards Marcel ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-07-21 23:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <24762.90.138.930.038.1036103001.ben.collins@canonical.com>
2008-07-21 1:45 ` [PATCH 3/7] bluetooth: Add quirks for a few hci_usb devices Ben Collins
2008-07-21 5:08 ` Marcel Holtmann
2008-07-21 5:54 ` Ben Collins
2008-07-21 16:00 ` Ben Collins
2008-07-21 23:30 ` Marcel Holtmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox