[PATCH] Advertise telephony service class for handsfree AG role, for Nokia 616 support.

[PATCH] Advertise telephony service class for handsfree AG role, for Nokia 616 support.

[Nick Pelly]

The Nokia 616 incorrectly requires the telehony bit to be set to make a
handsfree connection.
---
 src/sdpd-service.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/src/sdpd-service.c b/src/sdpd-service.c
index 30aad32..f138d22 100644
--- a/src/sdpd-service.c
+++ b/src/sdpd-service.c
@@ -121,6 +121,13 @@ static void update_svclass_list(void)
 		case HANDSFREE_SVCLASS_ID:
 			val |= 0x20;	/* Audio */
 			break;
+		/* For Nokia 616 carkit compatability - it incorrectly requires
+		 * the telephony bit set for handsfree usage, despite this not
+		 * being a requirement of the handsfree spec.
+		 */
+		case HANDSFREE_SVCLASS_ID:
+			val |= 0x40;    /* Telephony */
+			break;
 		case CORDLESS_TELEPHONY_SVCLASS_ID:
 		case INTERCOM_SVCLASS_ID:
 		case FAX_SVCLASS_ID:
-- 
1.5.5

[PATCH] Advertise telephony service class for handsfree AG role, for Nokia 616 support.

[Nick Pelly]

The Nokia 616 incorrectly requires the telehony bit to be set to make a
handsfree connection.
---
 src/sdpd-service.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/src/sdpd-service.c b/src/sdpd-service.c
index 30aad32..12c999c 100644
--- a/src/sdpd-service.c
+++ b/src/sdpd-service.c
@@ -121,6 +121,13 @@ static void update_svclass_list(void)
 		case HANDSFREE_SVCLASS_ID:
 			val |= 0x20;	/* Audio */
 			break;
+		/* For Nokia 616 carkit compatability - it incorrectly requires
+		 * the telephony bit set on the HFP AG, despite this not
+		 * being a requirement of the handsfree spec.
+		 */
+		case HANDSFREE_AGW_SVCLASS_ID:
+			val |= 0x40;    /* Telephony */
+			break;
 		case CORDLESS_TELEPHONY_SVCLASS_ID:
 		case INTERCOM_SVCLASS_ID:
 		case FAX_SVCLASS_ID:
-- 
1.5.5

Re: [PATCH] Advertise telephony service class for handsfree AG role, for Nokia 616 support.

[Nick Pelly]

The first patch used HANDSFREE_SVCLASS_ID - wrong. Please use the
second patch. Sorry about that.

On Tue, Sep 23, 2008 at 11:25 AM, Nick Pelly <npelly@google.com> wrote:
> The Nokia 616 incorrectly requires the telehony bit to be set to make a
> handsfree connection.
> ---
>  src/sdpd-service.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/src/sdpd-service.c b/src/sdpd-service.c
> index 30aad32..12c999c 100644
> --- a/src/sdpd-service.c
> +++ b/src/sdpd-service.c
> @@ -121,6 +121,13 @@ static void update_svclass_list(void)
>                case HANDSFREE_SVCLASS_ID:
>                        val |= 0x20;    /* Audio */
>                        break;
> +               /* For Nokia 616 carkit compatability - it incorrectly requires
> +                * the telephony bit set on the HFP AG, despite this not
> +                * being a requirement of the handsfree spec.
> +                */
> +               case HANDSFREE_AGW_SVCLASS_ID:
> +                       val |= 0x40;    /* Telephony */
> +                       break;
>                case CORDLESS_TELEPHONY_SVCLASS_ID:
>                case INTERCOM_SVCLASS_ID:
>                case FAX_SVCLASS_ID:
> --
> 1.5.5
>
>