[PATCH] Add udev rules to start bluetooth on-demand

[PATCH] Add udev rules to start bluetooth on-demand

[Bastien Nocera]

[-- Attachment #1: Type: text/plain, Size: 40 bytes --]

As discussed in previous mails.

Cheers

[-- Attachment #2: 0001-Add-udev-rules-to-start-bluetooth-on-demand.patch --]
[-- Type: text/x-patch, Size: 1094 bytes --]

>From 830639ae0f3421a9d7c7366854925e32001771b5 Mon Sep 17 00:00:00 2001
From: Bastien Nocera <hadess@hadess.net>
Date: Sun, 21 Jun 2009 14:37:32 +0100
Subject: [PATCH] Add udev rules to start bluetooth on-demand

Those rules call bluetoothd --udev when a new dongle is inserted.
---
 scripts/96-bluez.rules |    5 +++++
 scripts/Makefile.am    |    2 ++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 scripts/96-bluez.rules

diff --git a/scripts/96-bluez.rules b/scripts/96-bluez.rules
new file mode 100644
index 0000000..f3034b5
--- /dev/null
+++ b/scripts/96-bluez.rules
@@ -0,0 +1,5 @@
+# Run helper every time a Bluetooth device appears
+# On remove actions, bluetoothd should go away by itself
+
+ACTION=="add", SUBSYSTEM=="bluetooth",		RUN+="/usr/sbin/bluetoothd --udev"
+
diff --git a/scripts/Makefile.am b/scripts/Makefile.am
index 494a9c2..d87295d 100644
--- a/scripts/Makefile.am
+++ b/scripts/Makefile.am
@@ -11,6 +11,8 @@ endif
 if PCMCIARULES
 rules_DATA += bluetooth-serial.rules
 endif
+
+rules_DATA += 96-bluez.rules
 endif
 
 if PCMCIARULES
-- 
1.6.2.2

Re: [PATCH] Add udev rules to start bluetooth on-demand

[Marcel Holtmann]

Hi Bastien,

> As discussed in previous mails.

please name it bluetooth.rules. The daemon is also called bluetoothd and
not bluezd.

Also you need to have the EXTRA_DIST part in it since _DATA doesn't get
added to the distribution automatically. For all this changes, you have
to check with make distcheck.

Regards

Marcel

Re: [PATCH] Add udev rules to start bluetooth on-demand

[Bastien Nocera]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

On Sun, 2009-06-21 at 15:50 +0200, Marcel Holtmann wrote:
> Hi Bastien,
> 
> > As discussed in previous mails.
> 
> please name it bluetooth.rules. The daemon is also called bluetoothd and
> not bluezd.
> 
> Also you need to have the EXTRA_DIST part in it since _DATA doesn't get
> added to the distribution automatically. For all this changes, you have
> to check with make distcheck.

Fixed version attached

[-- Attachment #2: 0001-Add-udev-rules-to-start-bluetooth-on-demand.patch --]
[-- Type: text/x-patch, Size: 1381 bytes --]

>From f723fb9f588a987bfaba94cfb2c1acb6c89c926c Mon Sep 17 00:00:00 2001
From: Bastien Nocera <hadess@hadess.net>
Date: Sun, 21 Jun 2009 14:37:32 +0100
Subject: [PATCH] Add udev rules to start bluetooth on-demand

Those rules call bluetoothd --udev when a new dongle is inserted.
---
 scripts/Makefile.am     |    4 +++-
 scripts/bluetooth.rules |    5 +++++
 2 files changed, 8 insertions(+), 1 deletions(-)
 create mode 100644 scripts/bluetooth.rules

diff --git a/scripts/Makefile.am b/scripts/Makefile.am
index 494a9c2..d06f95e 100644
--- a/scripts/Makefile.am
+++ b/scripts/Makefile.am
@@ -11,6 +11,8 @@ endif
 if PCMCIARULES
 rules_DATA += bluetooth-serial.rules
 endif
+
+rules_DATA += bluetooth.rules
 endif
 
 if PCMCIARULES
@@ -20,7 +22,7 @@ udev_SCRIPTS = bluetooth_serial
 endif
 
 EXTRA_DIST = bluetooth.init bluetooth.default bluetooth-hid2hci.rules \
-				bluetooth-serial.rules bluetooth_serial
+				bluetooth-serial.rules bluetooth_serial bluetooth.rules
 
 MAINTAINERCLEANFILES = Makefile.in
 
diff --git a/scripts/bluetooth.rules b/scripts/bluetooth.rules
new file mode 100644
index 0000000..f3034b5
--- /dev/null
+++ b/scripts/bluetooth.rules
@@ -0,0 +1,5 @@
+# Run helper every time a Bluetooth device appears
+# On remove actions, bluetoothd should go away by itself
+
+ACTION=="add", SUBSYSTEM=="bluetooth",		RUN+="/usr/sbin/bluetoothd --udev"
+
-- 
1.6.2.2

Re: [PATCH] Add udev rules to start bluetooth on-demand

[Marcel Holtmann]

Hi Bastien,

> > > As discussed in previous mails.
> > 
> > please name it bluetooth.rules. The daemon is also called bluetoothd and
> > not bluezd.
> > 
> > Also you need to have the EXTRA_DIST part in it since _DATA doesn't get
> > added to the distribution automatically. For all this changes, you have
> > to check with make distcheck.
> 
> Fixed version attached

we might need to put this into ifndef INITSCRIPTS since it makes no
sense to install the init script and the udev rule at the same time.

Regards

Marcel

Re: [PATCH] Add udev rules to start bluetooth on-demand

[Bastien Nocera]

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

On Sun, 2009-06-21 at 16:10 +0200, Marcel Holtmann wrote:
> Hi Bastien,
> 
> > > > As discussed in previous mails.
> > > 
> > > please name it bluetooth.rules. The daemon is also called bluetoothd and
> > > not bluezd.
> > > 
> > > Also you need to have the EXTRA_DIST part in it since _DATA doesn't get
> > > added to the distribution automatically. For all this changes, you have
> > > to check with make distcheck.
> > 
> > Fixed version attached
> 
> we might need to put this into ifndef INITSCRIPTS since it makes no
> sense to install the init script and the udev rule at the same time.

Revised patch attached

[-- Attachment #2: 0001-Add-udev-rules-to-start-bluetooth-on-demand.patch --]
[-- Type: text/x-patch, Size: 1406 bytes --]

>From 0024e48166073f05ae233113eee2119ccd2e3f71 Mon Sep 17 00:00:00 2001
From: Bastien Nocera <hadess@hadess.net>
Date: Sun, 21 Jun 2009 14:37:32 +0100
Subject: [PATCH] Add udev rules to start bluetooth on-demand

Those rules call bluetoothd --udev when a new dongle is inserted.
---
 scripts/Makefile.am     |    6 +++++-
 scripts/bluetooth.rules |    5 +++++
 2 files changed, 10 insertions(+), 1 deletions(-)
 create mode 100644 scripts/bluetooth.rules

diff --git a/scripts/Makefile.am b/scripts/Makefile.am
index 494a9c2..e5683b2 100644
--- a/scripts/Makefile.am
+++ b/scripts/Makefile.am
@@ -11,6 +11,10 @@ endif
 if PCMCIARULES
 rules_DATA += bluetooth-serial.rules
 endif
+
+if INISCRIPTS
+else
+rules_DATA += bluetooth.rules
 endif
 
 if PCMCIARULES
@@ -20,7 +24,7 @@ udev_SCRIPTS = bluetooth_serial
 endif
 
 EXTRA_DIST = bluetooth.init bluetooth.default bluetooth-hid2hci.rules \
-				bluetooth-serial.rules bluetooth_serial
+				bluetooth-serial.rules bluetooth_serial bluetooth.rules
 
 MAINTAINERCLEANFILES = Makefile.in
 
diff --git a/scripts/bluetooth.rules b/scripts/bluetooth.rules
new file mode 100644
index 0000000..f3034b5
--- /dev/null
+++ b/scripts/bluetooth.rules
@@ -0,0 +1,5 @@
+# Run helper every time a Bluetooth device appears
+# On remove actions, bluetoothd should go away by itself
+
+ACTION=="add", SUBSYSTEM=="bluetooth",		RUN+="/usr/sbin/bluetoothd --udev"
+
-- 
1.6.2.2

Re: [PATCH] Add udev rules to start bluetooth on-demand

[Marcel Holtmann]

On Wed, 2009-06-24 at 12:35 +0100, Bastien Nocera wrote:
> On Sun, 2009-06-21 at 16:10 +0200, Marcel Holtmann wrote:
> > Hi Bastien,
> > 
> > > > > As discussed in previous mails.
> > > > 
> > > > please name it bluetooth.rules. The daemon is also called bluetoothd and
> > > > not bluezd.
> > > > 
> > > > Also you need to have the EXTRA_DIST part in it since _DATA doesn't get
> > > > added to the distribution automatically. For all this changes, you have
> > > > to check with make distcheck.
> > > 
> > > Fixed version attached
> > 
> > we might need to put this into ifndef INITSCRIPTS since it makes no
> > sense to install the init script and the udev rule at the same time.
> 
> Revised patch attached

+
+if INISCRIPTS
+else
+rules_DATA += bluetooth.rules
 endif

???

Regards

Marcel

Re: [PATCH] Add udev rules to start bluetooth on-demand

[Bastien Nocera]

On Wed, 2009-06-24 at 18:43 +0200, Marcel Holtmann wrote:
> On Wed, 2009-06-24 at 12:35 +0100, Bastien Nocera wrote:
> > On Sun, 2009-06-21 at 16:10 +0200, Marcel Holtmann wrote:
> > > Hi Bastien,
> > > 
> > > > > > As discussed in previous mails.
> > > > > 
> > > > > please name it bluetooth.rules. The daemon is also called bluetoothd and
> > > > > not bluezd.
> > > > > 
> > > > > Also you need to have the EXTRA_DIST part in it since _DATA doesn't get
> > > > > added to the distribution automatically. For all this changes, you have
> > > > > to check with make distcheck.
> > > > 
> > > > Fixed version attached
> > > 
> > > we might need to put this into ifndef INITSCRIPTS since it makes no
> > > sense to install the init script and the udev rule at the same time.
> > 
> > Revised patch attached
> 
> +
> +if INISCRIPTS
> +else
> +rules_DATA += bluetooth.rules
>  endif

ifndef isn't an automake construct.

Re: [PATCH] Add udev rules to start bluetooth on-demand

[Marcel Holtmann]

Hi Bastien,

> > > > > > > As discussed in previous mails.
> > > > > > 
> > > > > > please name it bluetooth.rules. The daemon is also called bluetoothd and
> > > > > > not bluezd.
> > > > > > 
> > > > > > Also you need to have the EXTRA_DIST part in it since _DATA doesn't get
> > > > > > added to the distribution automatically. For all this changes, you have
> > > > > > to check with make distcheck.
> > > > > 
> > > > > Fixed version attached
> > > > 
> > > > we might need to put this into ifndef INITSCRIPTS since it makes no
> > > > sense to install the init script and the udev rule at the same time.
> > > 
> > > Revised patch attached
> > 
> > +
> > +if INISCRIPTS
> > +else
> > +rules_DATA += bluetooth.rules
> >  endif
> 
> ifndef isn't an automake construct.
> 

then if !INITSCRIPTS should do it. However I was more asking about the
spelling mistake. You forgot a T ;)

Regards

Marcel

Re: [PATCH] Add udev rules to start bluetooth on-demand

[Bastien Nocera]

On Wed, 2009-06-24 at 18:46 +0200, Marcel Holtmann wrote:
> Hi Bastien,
> 
> > > > > > > > As discussed in previous mails.
> > > > > > > 
> > > > > > > please name it bluetooth.rules. The daemon is also called bluetoothd and
> > > > > > > not bluezd.
> > > > > > > 
> > > > > > > Also you need to have the EXTRA_DIST part in it since _DATA doesn't get
> > > > > > > added to the distribution automatically. For all this changes, you have
> > > > > > > to check with make distcheck.
> > > > > > 
> > > > > > Fixed version attached
> > > > > 
> > > > > we might need to put this into ifndef INITSCRIPTS since it makes no
> > > > > sense to install the init script and the udev rule at the same time.
> > > > 
> > > > Revised patch attached
> > > 
> > > +
> > > +if INISCRIPTS
> > > +else
> > > +rules_DATA += bluetooth.rules
> > >  endif
> > 
> > ifndef isn't an automake construct.
> > 
> 
> then if !INITSCRIPTS should do it. However I was more asking about the
> spelling mistake. You forgot a T ;)

Well, that's embarrassing...

Re: [PATCH] Add udev rules to start bluetooth on-demand

[Marcel Holtmann]

Hi Bastien,

> > > > > > > > > As discussed in previous mails.
> > > > > > > > 
> > > > > > > > please name it bluetooth.rules. The daemon is also called bluetoothd and
> > > > > > > > not bluezd.
> > > > > > > > 
> > > > > > > > Also you need to have the EXTRA_DIST part in it since _DATA doesn't get
> > > > > > > > added to the distribution automatically. For all this changes, you have
> > > > > > > > to check with make distcheck.
> > > > > > > 
> > > > > > > Fixed version attached
> > > > > > 
> > > > > > we might need to put this into ifndef INITSCRIPTS since it makes no
> > > > > > sense to install the init script and the udev rule at the same time.
> > > > > 
> > > > > Revised patch attached
> > > > 
> > > > +
> > > > +if INISCRIPTS
> > > > +else
> > > > +rules_DATA += bluetooth.rules
> > > >  endif
> > > 
> > > ifndef isn't an automake construct.
> > > 
> > 
> > then if !INITSCRIPTS should do it. However I was more asking about the
> > spelling mistake. You forgot a T ;)
> 
> Well, that's embarrassing...

are you sending a new patch :)

Regards

Marcel

Re: [PATCH] Add udev rules to start bluetooth on-demand

[Bastien Nocera]

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

On Sat, 2009-06-27 at 12:27 +0200, Marcel Holtmann wrote:
> Hi Bastien,
> 
> > > > > > > > > > As discussed in previous mails.
> > > > > > > > > 
> > > > > > > > > please name it bluetooth.rules. The daemon is also called bluetoothd and
> > > > > > > > > not bluezd.
> > > > > > > > > 
> > > > > > > > > Also you need to have the EXTRA_DIST part in it since _DATA doesn't get
> > > > > > > > > added to the distribution automatically. For all this changes, you have
> > > > > > > > > to check with make distcheck.
> > > > > > > > 
> > > > > > > > Fixed version attached
> > > > > > > 
> > > > > > > we might need to put this into ifndef INITSCRIPTS since it makes no
> > > > > > > sense to install the init script and the udev rule at the same time.
> > > > > > 
> > > > > > Revised patch attached
> > > > > 
> > > > > +
> > > > > +if INISCRIPTS
> > > > > +else
> > > > > +rules_DATA += bluetooth.rules
> > > > >  endif
> > > > 
> > > > ifndef isn't an automake construct.
> > > > 
> > > 
> > > then if !INITSCRIPTS should do it. However I was more asking about the
> > > spelling mistake. You forgot a T ;)
> > 
> > Well, that's embarrassing...
> 
> are you sending a new patch :)

Thought you'd fix the typo, and commit.

Patch attached.

[-- Attachment #2: 0001-Add-udev-rules-to-start-bluetooth-on-demand.patch --]
[-- Type: text/x-patch, Size: 1062 bytes --]

>From 9602419da57953b91e4fcb7a6e3770744154dbef Mon Sep 17 00:00:00 2001
From: Bastien Nocera <hadess@hadess.net>
Date: Mon, 29 Jun 2009 15:54:46 +0100
Subject: [PATCH] Add udev rules to start bluetooth on-demand

Those rules call bluetoothd --udev when a new dongle is inserted.
---
 scripts/Makefile.am |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/scripts/Makefile.am b/scripts/Makefile.am
index 494a9c2..d97b309 100644
--- a/scripts/Makefile.am
+++ b/scripts/Makefile.am
@@ -11,6 +11,10 @@ endif
 if PCMCIARULES
 rules_DATA += bluetooth-serial.rules
 endif
+
+if INITSCRIPTS
+else
+rules_DATA += bluetooth.rules
 endif
 
 if PCMCIARULES
@@ -19,8 +23,13 @@ udevdir = $(libexecdir)/udev
 udev_SCRIPTS = bluetooth_serial
 endif
 
+if INITSCRIPTS
+else
+rules_DATA += bluetooth.rules
+endif
+
 EXTRA_DIST = bluetooth.init bluetooth.default bluetooth-hid2hci.rules \
-				bluetooth-serial.rules bluetooth_serial
+				bluetooth-serial.rules bluetooth_serial bluetooth.rules
 
 MAINTAINERCLEANFILES = Makefile.in
 
-- 
1.6.2.2

Re: [PATCH] Add udev rules to start bluetooth on-demand

[Marcel Holtmann]

Hi Bastien,

> > > > > > > > > > > As discussed in previous mails.
> > > > > > > > > > 
> > > > > > > > > > please name it bluetooth.rules. The daemon is also called bluetoothd and
> > > > > > > > > > not bluezd.
> > > > > > > > > > 
> > > > > > > > > > Also you need to have the EXTRA_DIST part in it since _DATA doesn't get
> > > > > > > > > > added to the distribution automatically. For all this changes, you have
> > > > > > > > > > to check with make distcheck.
> > > > > > > > > 
> > > > > > > > > Fixed version attached
> > > > > > > > 
> > > > > > > > we might need to put this into ifndef INITSCRIPTS since it makes no
> > > > > > > > sense to install the init script and the udev rule at the same time.
> > > > > > > 
> > > > > > > Revised patch attached
> > > > > > 
> > > > > > +
> > > > > > +if INISCRIPTS
> > > > > > +else
> > > > > > +rules_DATA += bluetooth.rules
> > > > > >  endif
> > > > > 
> > > > > ifndef isn't an automake construct.
> > > > > 
> > > > 
> > > > then if !INITSCRIPTS should do it. However I was more asking about the
> > > > spelling mistake. You forgot a T ;)
> > > 
> > > Well, that's embarrassing...
> > 
> > are you sending a new patch :)
> 
> Thought you'd fix the typo, and commit.

not if you wanna keep your author name on the patch.

Also does if !INITSCRIPTS not work?

And why does your patch now has two statements for rules_DATA?

Regards

Marcel