From: Bastien Nocera <hadess@hadess.net>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Add rfkill plugin
Date: Tue, 28 Jul 2009 21:12:20 +0100 [thread overview]
Message-ID: <1248811940.23466.12248.camel@localhost.localdomain> (raw)
In-Reply-To: <1248811593.28545.227.camel@violet>
On Tue, 2009-07-28 at 22:06 +0200, Marcel Holtmann wrote:
> Hi Bastien,
>
> > The plugin allows us to restore the previous power state on
> > adapters when the killswitch on them has been unblocked.
> >
> > Otherwise we end up with the adapter disabled when coming back from a
> > soft killswitch.
>
> I think that having this as a plugin is overkill. I would just integrate
> this as src/rfkill.c. Especially since it has no dependencies.
It would mean it's harder to change its behaviour. Surely, it would make
more sense for this to be a plugin than for HCI operations to be.
Given that you don't use an object system with typing, it's probably one
or 2 function calls off. To me, it makes sense to have parts of the core
as plugins if it means that the core is leaner because of it.
next prev parent reply other threads:[~2009-07-28 20:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 16:34 [PATCH] Add rfkill plugin Bastien Nocera
2009-07-28 20:06 ` Marcel Holtmann
2009-07-28 20:12 ` Bastien Nocera [this message]
2009-07-28 20:21 ` Marcel Holtmann
2009-07-29 15:13 ` Bastien Nocera
2009-07-29 19:49 ` Marcel Holtmann
2009-07-29 20:15 ` Bastien Nocera
2009-07-29 20:23 ` Marcel Holtmann
2009-07-29 20:40 ` Bastien Nocera
2009-07-29 21:44 ` Johan Hedberg
2009-07-29 21:45 ` Bastien Nocera
2009-07-30 2:10 ` Luiz Augusto von Dentz
2009-07-30 2:27 ` Marcel Holtmann
2009-07-30 2:30 ` Marcel Holtmann
2009-07-30 10:23 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248811940.23466.12248.camel@localhost.localdomain \
--to=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox