public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Bastien Nocera <hadess@hadess.net>,
	BlueZ development <linux-bluetooth@vger.kernel.org>,
	David.Weinehall@nokia.com
Subject: Re: [PATCH] Add rfkill plugin
Date: Thu, 30 Jul 2009 13:23:21 +0300	[thread overview]
Message-ID: <20090730102321.GB6082@jh-x301> (raw)
In-Reply-To: <1248921041.28545.248.camel@violet>

Hi Marcel,

On Thu, Jul 30, 2009, Marcel Holtmann wrote:
> > So having a btd_adapter_set_powered exported to plugins (which is what
> > Bastien's patch seems to do) makes sense to me in this case. I might
> > actually need something similar for maemo in order to handle our offline
> > mode better (maemo specific plugin to catch the MCE offline mode signal
> > and then call btd_adapter_set_powered).
> 
> then I leave this with you to export that function correctly. It should
> be a separate patch anyway.

Ok. Maybe Bastien can split this out from his original patch? Note that
the function should probably have the btd_ prefix since the idea has been
that only functions like that get exported to plugins (not sure if it's
actually enforced yet though).

> I would disagree with the MCE offline handling as a plugin. First off
> all, why is it not integrated into RFKILL. Second off all, it could just
> use RFKILL or RememberPowered=false and change Powered by itself. The
> listening to offline signal is the wrong design.

You're probably right, however this is what I have to live with in the
current maemo version. I've added David to CC so he can comment on the
possibility of replacing MCE offline/normal mode signals with rfkill in
the future.

Johan

      reply	other threads:[~2009-07-30 10:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-28 16:34 [PATCH] Add rfkill plugin Bastien Nocera
2009-07-28 20:06 ` Marcel Holtmann
2009-07-28 20:12   ` Bastien Nocera
2009-07-28 20:21     ` Marcel Holtmann
2009-07-29 15:13 ` Bastien Nocera
2009-07-29 19:49   ` Marcel Holtmann
2009-07-29 20:15     ` Bastien Nocera
2009-07-29 20:23       ` Marcel Holtmann
2009-07-29 20:40         ` Bastien Nocera
2009-07-29 21:44         ` Johan Hedberg
2009-07-29 21:45           ` Bastien Nocera
2009-07-30  2:10           ` Luiz Augusto von Dentz
2009-07-30  2:27             ` Marcel Holtmann
2009-07-30  2:30           ` Marcel Holtmann
2009-07-30 10:23             ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090730102321.GB6082@jh-x301 \
    --to=johan.hedberg@gmail.com \
    --cc=David.Weinehall@nokia.com \
    --cc=hadess@hadess.net \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox