From: Marcel Holtmann <marcel@holtmann.org>
To: Bastien Nocera <hadess@hadess.net>
Cc: BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Add rfkill plugin
Date: Wed, 29 Jul 2009 21:49:27 +0200 [thread overview]
Message-ID: <1248896967.28545.236.camel@violet> (raw)
In-Reply-To: <1248880408.28327.906.camel@localhost.localdomain>
Hi Bastien,
> > The plugin allows us to restore the previous power state on
> > adapters when the killswitch on them has been unblocked.
> >
> > Otherwise we end up with the adapter disabled when coming back from a
> > soft killswitch.
>
> Just a note that __u32 causes failures with newer GCCs (not sure why),
> using uint32_t instead fixes the problem.
>
> I'll send another patch when this one gets committed.
I didn't commit this patch, because it should be part of bluetoothd and
not a plugin and as I mentioned before honor the RememberPowered setting
for system where other entities control that.
However I did push a RFKILL skeleton that that all the lifting except
bringing the adapter up. Hijacking the set_powered D-Bus command is the
wrong approach. We need a properly exported adapter_up() function for
this.
Regards
Marcel
next prev parent reply other threads:[~2009-07-29 19:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 16:34 [PATCH] Add rfkill plugin Bastien Nocera
2009-07-28 20:06 ` Marcel Holtmann
2009-07-28 20:12 ` Bastien Nocera
2009-07-28 20:21 ` Marcel Holtmann
2009-07-29 15:13 ` Bastien Nocera
2009-07-29 19:49 ` Marcel Holtmann [this message]
2009-07-29 20:15 ` Bastien Nocera
2009-07-29 20:23 ` Marcel Holtmann
2009-07-29 20:40 ` Bastien Nocera
2009-07-29 21:44 ` Johan Hedberg
2009-07-29 21:45 ` Bastien Nocera
2009-07-30 2:10 ` Luiz Augusto von Dentz
2009-07-30 2:27 ` Marcel Holtmann
2009-07-30 2:30 ` Marcel Holtmann
2009-07-30 10:23 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248896967.28545.236.camel@violet \
--to=marcel@holtmann.org \
--cc=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox