From: Mat Martineau <mathewm@codeaurora.org>
To: linux-bluetooth@vger.kernel.org
Cc: padovan@profusion.mobi, pkrystad@codeaurora.org,
andrei.emeltchenko@intel.com,
Mat Martineau <mathewm@codeaurora.org>
Subject: [PATCHv2 9/9] Bluetooth: Guarantee BR-EDR device will be registered as hci0
Date: Wed, 19 Oct 2011 10:44:07 -0700 [thread overview]
Message-ID: <1319046247-3391-10-git-send-email-mathewm@codeaurora.org> (raw)
In-Reply-To: <1319046247-3391-1-git-send-email-mathewm@codeaurora.org>
It's convenient to use the HCI device index the AMP controller id, but
the spec requires that an AMP controller never has id 0.
Signed-off-by: Mat Martineau <mathewm@codeaurora.org>
---
net/bluetooth/hci_core.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index fdcbf8f..78e6b05 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -1426,7 +1426,7 @@ int hci_add_adv_entry(struct hci_dev *hdev,
int hci_register_dev(struct hci_dev *hdev)
{
struct list_head *head = &hci_dev_list, *p;
- int i, id = 0, error;
+ int i, id, error;
BT_DBG("%p name %s bus %d owner %p", hdev, hdev->name,
hdev->bus, hdev->owner);
@@ -1434,6 +1434,8 @@ int hci_register_dev(struct hci_dev *hdev)
if (!hdev->open || !hdev->close || !hdev->destruct)
return -EINVAL;
+ id = (hdev->dev_type == HCI_BREDR) ? 0 : 1;
+
write_lock_bh(&hci_dev_list_lock);
/* Find first available device id */
--
1.7.7
--
Mat Martineau
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
next prev parent reply other threads:[~2011-10-19 17:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 17:43 [PATCHv2 0/9] AMP interface and signal framework Mat Martineau
2011-10-19 17:43 ` [PATCHv2 1/9] Bluetooth: Add BT_CHANNEL_POLICY socket option Mat Martineau
2011-10-19 18:55 ` Marcel Holtmann
2011-10-19 17:44 ` [PATCHv2 2/9] Bluetooth: Change scope of the enable_hs module parameter Mat Martineau
2011-10-19 19:18 ` Marcel Holtmann
2011-10-19 17:44 ` [PATCHv2 3/9] Bluetooth: Add channel policy to getsockopt/setsockopt Mat Martineau
2011-10-19 18:54 ` Marcel Holtmann
2011-10-19 20:39 ` Mat Martineau
2011-10-19 17:44 ` [PATCHv2 4/9] Bluetooth: Add AMP-related data and structures for channel signals Mat Martineau
2011-10-19 18:58 ` Marcel Holtmann
2011-10-19 17:44 ` [PATCHv2 5/9] Bluetooth: Add signal handlers for channel creation Mat Martineau
2011-10-19 19:02 ` Marcel Holtmann
2011-10-19 20:53 ` Mat Martineau
2011-10-19 17:44 ` [PATCHv2 6/9] Bluetooth: Add definitions for L2CAP fixed channels Mat Martineau
2011-10-19 19:03 ` Marcel Holtmann
2011-10-19 21:25 ` Mat Martineau
2011-10-19 22:02 ` Marcel Holtmann
2011-10-19 17:44 ` [PATCHv2 7/9] Bluetooth: Use symbolic values for the fixed channel map Mat Martineau
2011-10-19 19:09 ` Marcel Holtmann
2011-10-19 21:44 ` Mat Martineau
2011-10-19 22:05 ` Marcel Holtmann
2011-10-19 17:44 ` [PATCHv2 8/9] Bluetooth: Add signal handlers for channel moves Mat Martineau
2011-10-19 19:11 ` Marcel Holtmann
2011-10-19 17:44 ` Mat Martineau [this message]
2011-10-19 19:17 ` [PATCHv2 9/9] Bluetooth: Guarantee BR-EDR device will be registered as hci0 Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319046247-3391-10-git-send-email-mathewm@codeaurora.org \
--to=mathewm@codeaurora.org \
--cc=andrei.emeltchenko@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=padovan@profusion.mobi \
--cc=pkrystad@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox