From: Marcel Holtmann <marcel@holtmann.org>
To: Mat Martineau <mathewm@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, padovan@profusion.mobi,
pkrystad@codeaurora.org, andrei.emeltchenko@intel.com
Subject: Re: [PATCHv2 6/9] Bluetooth: Add definitions for L2CAP fixed channels
Date: Wed, 19 Oct 2011 12:03:58 -0700 [thread overview]
Message-ID: <1319051041.15441.167.camel@aeonflux> (raw)
In-Reply-To: <1319046247-3391-7-git-send-email-mathewm@codeaurora.org>
Hi Mat,
> Symbolic fixed channel IDs will be used instead of magic numbers.
>
> Signed-off-by: Mat Martineau <mathewm@codeaurora.org>
> ---
> include/net/bluetooth/l2cap.h | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
> index 4f4f318..b8b25f6 100644
> --- a/include/net/bluetooth/l2cap.h
> +++ b/include/net/bluetooth/l2cap.h
> @@ -119,6 +119,10 @@ struct l2cap_conninfo {
> #define L2CAP_FCS_NONE 0x00
> #define L2CAP_FCS_CRC16 0x01
>
> +/* L2CAP fixed channels */
> +#define L2CAP_FC_L2CAP 0x02
> +#define L2CAP_FC_A2MP 0x08
> +
while you are at it, please add the known fixed channels for SMP and LE
signaling here. They should be in use already somewhere ;)
> /* L2CAP Control Field bit masks */
> #define L2CAP_CTRL_SAR 0xC000
> #define L2CAP_CTRL_REQSEQ 0x3F00
Regards
Marcel
next prev parent reply other threads:[~2011-10-19 19:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 17:43 [PATCHv2 0/9] AMP interface and signal framework Mat Martineau
2011-10-19 17:43 ` [PATCHv2 1/9] Bluetooth: Add BT_CHANNEL_POLICY socket option Mat Martineau
2011-10-19 18:55 ` Marcel Holtmann
2011-10-19 17:44 ` [PATCHv2 2/9] Bluetooth: Change scope of the enable_hs module parameter Mat Martineau
2011-10-19 19:18 ` Marcel Holtmann
2011-10-19 17:44 ` [PATCHv2 3/9] Bluetooth: Add channel policy to getsockopt/setsockopt Mat Martineau
2011-10-19 18:54 ` Marcel Holtmann
2011-10-19 20:39 ` Mat Martineau
2011-10-19 17:44 ` [PATCHv2 4/9] Bluetooth: Add AMP-related data and structures for channel signals Mat Martineau
2011-10-19 18:58 ` Marcel Holtmann
2011-10-19 17:44 ` [PATCHv2 5/9] Bluetooth: Add signal handlers for channel creation Mat Martineau
2011-10-19 19:02 ` Marcel Holtmann
2011-10-19 20:53 ` Mat Martineau
2011-10-19 17:44 ` [PATCHv2 6/9] Bluetooth: Add definitions for L2CAP fixed channels Mat Martineau
2011-10-19 19:03 ` Marcel Holtmann [this message]
2011-10-19 21:25 ` Mat Martineau
2011-10-19 22:02 ` Marcel Holtmann
2011-10-19 17:44 ` [PATCHv2 7/9] Bluetooth: Use symbolic values for the fixed channel map Mat Martineau
2011-10-19 19:09 ` Marcel Holtmann
2011-10-19 21:44 ` Mat Martineau
2011-10-19 22:05 ` Marcel Holtmann
2011-10-19 17:44 ` [PATCHv2 8/9] Bluetooth: Add signal handlers for channel moves Mat Martineau
2011-10-19 19:11 ` Marcel Holtmann
2011-10-19 17:44 ` [PATCHv2 9/9] Bluetooth: Guarantee BR-EDR device will be registered as hci0 Mat Martineau
2011-10-19 19:17 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319051041.15441.167.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=andrei.emeltchenko@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mathewm@codeaurora.org \
--cc=padovan@profusion.mobi \
--cc=pkrystad@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox