* [PATCH] Bluetooth: Fix mgmt_stop_discovery_failed()
@ 2012-01-02 19:50 Andre Guedes
2012-01-02 22:25 ` Marcel Holtmann
2012-01-03 0:44 ` Gustavo Padovan
0 siblings, 2 replies; 4+ messages in thread
From: Andre Guedes @ 2012-01-02 19:50 UTC (permalink / raw)
To: linux-bluetooth
Stop Discovery Command Status Event should use mgmt status code.
Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
---
net/bluetooth/mgmt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 2540944..fb0b15e 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -2756,7 +2756,7 @@ int mgmt_stop_discovery_failed(struct hci_dev *hdev, u8 status)
if (!cmd)
return -ENOENT;
- err = cmd_status(cmd->sk, hdev->id, cmd->opcode, status);
+ err = cmd_status(cmd->sk, hdev->id, cmd->opcode, mgmt_status(status));
mgmt_pending_remove(cmd);
return err;
--
1.7.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Bluetooth: Fix mgmt_stop_discovery_failed()
2012-01-02 19:50 [PATCH] Bluetooth: Fix mgmt_stop_discovery_failed() Andre Guedes
@ 2012-01-02 22:25 ` Marcel Holtmann
2012-01-02 22:48 ` Johan Hedberg
2012-01-03 0:44 ` Gustavo Padovan
1 sibling, 1 reply; 4+ messages in thread
From: Marcel Holtmann @ 2012-01-02 22:25 UTC (permalink / raw)
To: Andre Guedes; +Cc: linux-bluetooth
Hi Andre,
> Stop Discovery Command Status Event should use mgmt status code.
>
> Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
> ---
> net/bluetooth/mgmt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 2540944..fb0b15e 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -2756,7 +2756,7 @@ int mgmt_stop_discovery_failed(struct hci_dev *hdev, u8 status)
> if (!cmd)
> return -ENOENT;
>
> - err = cmd_status(cmd->sk, hdev->id, cmd->opcode, status);
> + err = cmd_status(cmd->sk, hdev->id, cmd->opcode, mgmt_status(status));
> mgmt_pending_remove(cmd);
patch does look reasonable to me, but I am not this is the expected
behavior. I leave this up to Johan to ACK or NAK.
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Bluetooth: Fix mgmt_stop_discovery_failed()
2012-01-02 22:25 ` Marcel Holtmann
@ 2012-01-02 22:48 ` Johan Hedberg
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hedberg @ 2012-01-02 22:48 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: Andre Guedes, linux-bluetooth
On Mon, Jan 02, 2012, Marcel Holtmann wrote:
> > Stop Discovery Command Status Event should use mgmt status code.
> >
> > Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
> > ---
> > net/bluetooth/mgmt.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> > index 2540944..fb0b15e 100644
> > --- a/net/bluetooth/mgmt.c
> > +++ b/net/bluetooth/mgmt.c
> > @@ -2756,7 +2756,7 @@ int mgmt_stop_discovery_failed(struct hci_dev *hdev, u8 status)
> > if (!cmd)
> > return -ENOENT;
> >
> > - err = cmd_status(cmd->sk, hdev->id, cmd->opcode, status);
> > + err = cmd_status(cmd->sk, hdev->id, cmd->opcode, mgmt_status(status));
> > mgmt_pending_remove(cmd);
>
> patch does look reasonable to me, but I am not this is the expected
> behavior. I leave this up to Johan to ACK or NAK.
Looks good to me.
Acked-by: Johan Hedberg <johan.hedberg@intel.com>
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Bluetooth: Fix mgmt_stop_discovery_failed()
2012-01-02 19:50 [PATCH] Bluetooth: Fix mgmt_stop_discovery_failed() Andre Guedes
2012-01-02 22:25 ` Marcel Holtmann
@ 2012-01-03 0:44 ` Gustavo Padovan
1 sibling, 0 replies; 4+ messages in thread
From: Gustavo Padovan @ 2012-01-03 0:44 UTC (permalink / raw)
To: Andre Guedes; +Cc: linux-bluetooth
* Andre Guedes <andre.guedes@openbossa.org> [2012-01-02 16:50:53 -0300]:
> Stop Discovery Command Status Event should use mgmt status code.
>
> Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
> ---
> net/bluetooth/mgmt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
Gustavo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-03 0:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-02 19:50 [PATCH] Bluetooth: Fix mgmt_stop_discovery_failed() Andre Guedes
2012-01-02 22:25 ` Marcel Holtmann
2012-01-02 22:48 ` Johan Hedberg
2012-01-03 0:44 ` Gustavo Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox