Linux bluetooth development
 help / color / mirror / Atom feed
From: Jefferson Delfes <jefferson.delfes@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Cc: Jefferson Delfes <jefferson.delfes@openbossa.org>
Subject: [PATCH BlueZ 07/16] attrib: Change g_attrib_cancel/_all return type
Date: Thu, 28 Mar 2013 11:39:11 -0400	[thread overview]
Message-ID: <1364485160-22720-8-git-send-email-jefferson.delfes@openbossa.org> (raw)
In-Reply-To: <1364485160-22720-1-git-send-email-jefferson.delfes@openbossa.org>

These functions doesn't need to use gboolean as return type.
---
 attrib/gattrib.c | 26 +++++++++++++-------------
 attrib/gattrib.h |  4 ++--
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/attrib/gattrib.c b/attrib/gattrib.c
index e9a4557..287f114 100644
--- a/attrib/gattrib.c
+++ b/attrib/gattrib.c
@@ -567,14 +567,14 @@ static gint command_cmp_by_id(gconstpointer a, gconstpointer b)
 	return cmd->id - id;
 }
 
-gboolean g_attrib_cancel(GAttrib *attrib, guint id)
+bool g_attrib_cancel(GAttrib *attrib, guint id)
 {
 	GList *l = NULL;
 	struct command *cmd;
 	GQueue *queue;
 
 	if (attrib == NULL)
-		return FALSE;
+		return false;
 
 	queue = attrib->requests;
 	if (queue)
@@ -583,13 +583,13 @@ gboolean g_attrib_cancel(GAttrib *attrib, guint id)
 	if (l == NULL) {
 		queue = attrib->responses;
 		if (!queue)
-			return FALSE;
+			return false;
 		l = g_queue_find_custom(queue, GUINT_TO_POINTER(id),
 					command_cmp_by_id);
 	}
 
 	if (l == NULL)
-		return FALSE;
+		return false;
 
 	cmd = l->data;
 
@@ -600,16 +600,16 @@ gboolean g_attrib_cancel(GAttrib *attrib, guint id)
 		command_destroy(cmd);
 	}
 
-	return TRUE;
+	return true;
 }
 
-static gboolean cancel_all_per_queue(GQueue *queue)
+static bool cancel_all_per_queue(GQueue *queue)
 {
 	struct command *c, *head = NULL;
-	gboolean first = TRUE;
+	bool first = true;
 
 	if (queue == NULL)
-		return FALSE;
+		return false;
 
 	while ((c = g_queue_pop_head(queue))) {
 		if (first && c->sent) {
@@ -619,7 +619,7 @@ static gboolean cancel_all_per_queue(GQueue *queue)
 			continue;
 		}
 
-		first = FALSE;
+		first = false;
 		command_destroy(c);
 	}
 
@@ -628,15 +628,15 @@ static gboolean cancel_all_per_queue(GQueue *queue)
 		g_queue_push_head(queue, head);
 	}
 
-	return TRUE;
+	return true;
 }
 
-gboolean g_attrib_cancel_all(GAttrib *attrib)
+bool g_attrib_cancel_all(GAttrib *attrib)
 {
-	gboolean ret;
+	bool ret;
 
 	if (attrib == NULL)
-		return FALSE;
+		return false;
 
 	ret = cancel_all_per_queue(attrib->requests);
 	ret = cancel_all_per_queue(attrib->responses) && ret;
diff --git a/attrib/gattrib.h b/attrib/gattrib.h
index 9d6a1c2..fe1ebd8 100644
--- a/attrib/gattrib.h
+++ b/attrib/gattrib.h
@@ -55,8 +55,8 @@ guint g_attrib_send(GAttrib *attrib, guint id, const guint8 *pdu, guint16 len,
 			GAttribResultFunc func, gpointer user_data,
 			GDestroyNotify notify);
 
-gboolean g_attrib_cancel(GAttrib *attrib, guint id);
-gboolean g_attrib_cancel_all(GAttrib *attrib);
+bool g_attrib_cancel(GAttrib *attrib, guint id);
+bool g_attrib_cancel_all(GAttrib *attrib);
 
 gboolean g_attrib_set_debug(GAttrib *attrib,
 		GAttribDebugFunc func, gpointer user_data);
-- 
1.8.2


  parent reply	other threads:[~2013-03-28 15:39 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-28 15:39 [PATCH BlueZ 00/16] attrib: Replace GLib basic data types usage Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 01/16] attrib: Simplify boolean tests Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 02/16] attrib: Change GAttrib->stale type from gboolean Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 03/16] attrib: Change command->sent " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 04/16] attrib: Change is_response return " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 05/16] attrib: Change match_event " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 06/16] attrib: Change g_attrib_set_destroy_function return type Jefferson Delfes
2013-03-28 15:39 ` Jefferson Delfes [this message]
2013-03-28 15:39 ` [PATCH BlueZ 08/16] attrib: Change g_attrib_unregister/_all " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 09/16] attrib: Change g_attrib_set_debug return type from gboolean Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 10/16] attrib: Change g_attrib_set_mtu " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 11/16] attrib: Change g_attrib_is_encrypted " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 12/16] attrib: Change command->opcode type from guint8 Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 13/16] attrib: Change event->handle type from guint16 Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 14/16] attrib: Change command->id type from guint Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 15/16] attrib: Change event->id " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 16/16] attrib: Change command->pdu pointer type from guint8 Jefferson Delfes
2013-04-10 19:16 ` [PATCH BlueZ v2 00/16] attrib: Replace GLib basic data types usage Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 01/16] attrib: Simplify boolean tests Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 02/16] attrib: Change GAttrib->stale type from gboolean Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 03/16] attrib: Change command->sent " Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 04/16] attrib: Change is_response return " Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 05/16] attrib: Change match_event " Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 06/16] attrib: Change g_attrib_set_destroy_function return type Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 07/16] attrib: Change g_attrib_cancel/_all " Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 08/16] attrib: Change g_attrib_unregister/_all " Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 09/16] attrib: Change g_attrib_set_debug return type from gboolean Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 10/16] attrib: Change g_attrib_set_mtu " Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 11/16] attrib: Change g_attrib_is_encrypted " Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 12/16] attrib: Change command->opcode type from guint8 Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 13/16] attrib: Change event->handle type from guint16 Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 14/16] attrib: Change command->id type from guint Jefferson Delfes
2013-04-10 19:17   ` [PATCH BlueZ v2 15/16] attrib: Change event->id " Jefferson Delfes
2013-04-10 19:17   ` [PATCH BlueZ v2 16/16] attrib: Change command->pdu pointer type from guint8 Jefferson Delfes
2013-04-17 14:03   ` [PATCH BlueZ v3 00/16] attrib: Replace GLib basic data types usage Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 01/16] attrib: Simplify boolean tests Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 02/16] attrib: Change GAttrib->stale type from gboolean Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 03/16] attrib: Change command->sent " Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 04/16] attrib: Change is_response return " Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 05/16] attrib: Change match_event " Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 06/16] attrib: Change g_attrib_set_destroy_function return type Jefferson Delfes
2013-04-24 14:02       ` Johan Hedberg
2013-05-02 16:05         ` Marcel Holtmann
2013-04-17 14:03     ` [PATCH BlueZ v3 07/16] attrib: Change g_attrib_cancel/_all " Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 08/16] attrib: Change g_attrib_unregister/_all " Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 09/16] attrib: Change g_attrib_set_debug return type from gboolean Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 10/16] attrib: Change g_attrib_set_mtu " Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 11/16] attrib: Change g_attrib_is_encrypted " Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 12/16] attrib: Change command->opcode type from guint8 Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 13/16] attrib: Change event->handle type from guint16 Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 14/16] attrib: Change command->id type from guint Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 15/16] attrib: Change event->id " Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 16/16] attrib: Change command->pdu pointer type from guint8 Jefferson Delfes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364485160-22720-8-git-send-email-jefferson.delfes@openbossa.org \
    --to=jefferson.delfes@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox