Linux bluetooth development
 help / color / mirror / Atom feed
From: Jefferson Delfes <jefferson.delfes@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Cc: Jefferson Delfes <jefferson.delfes@openbossa.org>
Subject: [PATCH BlueZ v3 01/16] attrib: Simplify boolean tests
Date: Wed, 17 Apr 2013 10:03:04 -0400	[thread overview]
Message-ID: <1366207399-29536-2-git-send-email-jefferson.delfes@openbossa.org> (raw)
In-Reply-To: <1366207399-29536-1-git-send-email-jefferson.delfes@openbossa.org>

Remove unnecessary TRUE/FALSE in boolean tests.
---
 attrib/gattrib.c  | 4 ++--
 attrib/gatttool.c | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/attrib/gattrib.c b/attrib/gattrib.c
index e6d6022..416d17b 100644
--- a/attrib/gattrib.c
+++ b/attrib/gattrib.c
@@ -371,7 +371,7 @@ static gboolean match_event(struct event *evt, const uint8_t *pdu, gsize len)
 	if (evt->expected == GATTRIB_ALL_EVENTS)
 		return TRUE;
 
-	if (is_response(pdu[0]) == FALSE && evt->expected == GATTRIB_ALL_REQS)
+	if (!is_response(pdu[0]) && evt->expected == GATTRIB_ALL_REQS)
 		return TRUE;
 
 	if (evt->expected == pdu[0] && evt->handle == GATTRIB_ALL_HANDLES)
@@ -421,7 +421,7 @@ static gboolean received_data(GIOChannel *io, GIOCondition cond, gpointer data)
 			evt->func(buf, len, evt->user_data);
 	}
 
-	if (is_response(buf[0]) == FALSE)
+	if (!is_response(buf[0]))
 		return TRUE;
 
 	if (attrib->timeout_watch > 0) {
diff --git a/attrib/gatttool.c b/attrib/gatttool.c
index e1d8407..dd0f1e2 100644
--- a/attrib/gatttool.c
+++ b/attrib/gatttool.c
@@ -248,7 +248,7 @@ static void char_read_cb(guint8 status, const guint8 *pdu, guint16 plen,
 	g_print("\n");
 
 done:
-	if (opt_listen == FALSE)
+	if (!opt_listen)
 		g_main_loop_quit(event_loop);
 }
 
@@ -378,7 +378,7 @@ static void char_write_req_cb(guint8 status, const guint8 *pdu, guint16 plen,
 	g_print("Characteristic value was written successfully\n");
 
 done:
-	if (opt_listen == FALSE)
+	if (!opt_listen)
 		g_main_loop_quit(event_loop);
 }
 
@@ -452,7 +452,7 @@ static void char_desc_cb(guint8 status, const guint8 *pdu, guint16 plen,
 	att_data_list_free(list);
 
 done:
-	if (opt_listen == FALSE)
+	if (!opt_listen)
 		g_main_loop_quit(event_loop);
 }
 
@@ -573,7 +573,7 @@ int main(int argc, char *argv[])
 	g_option_context_add_group(context, char_rw_group);
 	g_option_group_add_entries(char_rw_group, char_rw_options);
 
-	if (g_option_context_parse(context, &argc, &argv, &gerr) == FALSE) {
+	if (!g_option_context_parse(context, &argc, &argv, &gerr)) {
 		g_printerr("%s\n", gerr->message);
 		g_clear_error(&gerr);
 	}
-- 
1.8.2


  reply	other threads:[~2013-04-17 14:03 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-28 15:39 [PATCH BlueZ 00/16] attrib: Replace GLib basic data types usage Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 01/16] attrib: Simplify boolean tests Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 02/16] attrib: Change GAttrib->stale type from gboolean Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 03/16] attrib: Change command->sent " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 04/16] attrib: Change is_response return " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 05/16] attrib: Change match_event " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 06/16] attrib: Change g_attrib_set_destroy_function return type Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 07/16] attrib: Change g_attrib_cancel/_all " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 08/16] attrib: Change g_attrib_unregister/_all " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 09/16] attrib: Change g_attrib_set_debug return type from gboolean Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 10/16] attrib: Change g_attrib_set_mtu " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 11/16] attrib: Change g_attrib_is_encrypted " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 12/16] attrib: Change command->opcode type from guint8 Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 13/16] attrib: Change event->handle type from guint16 Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 14/16] attrib: Change command->id type from guint Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 15/16] attrib: Change event->id " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 16/16] attrib: Change command->pdu pointer type from guint8 Jefferson Delfes
2013-04-10 19:16 ` [PATCH BlueZ v2 00/16] attrib: Replace GLib basic data types usage Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 01/16] attrib: Simplify boolean tests Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 02/16] attrib: Change GAttrib->stale type from gboolean Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 03/16] attrib: Change command->sent " Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 04/16] attrib: Change is_response return " Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 05/16] attrib: Change match_event " Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 06/16] attrib: Change g_attrib_set_destroy_function return type Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 07/16] attrib: Change g_attrib_cancel/_all " Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 08/16] attrib: Change g_attrib_unregister/_all " Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 09/16] attrib: Change g_attrib_set_debug return type from gboolean Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 10/16] attrib: Change g_attrib_set_mtu " Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 11/16] attrib: Change g_attrib_is_encrypted " Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 12/16] attrib: Change command->opcode type from guint8 Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 13/16] attrib: Change event->handle type from guint16 Jefferson Delfes
2013-04-10 19:16   ` [PATCH BlueZ v2 14/16] attrib: Change command->id type from guint Jefferson Delfes
2013-04-10 19:17   ` [PATCH BlueZ v2 15/16] attrib: Change event->id " Jefferson Delfes
2013-04-10 19:17   ` [PATCH BlueZ v2 16/16] attrib: Change command->pdu pointer type from guint8 Jefferson Delfes
2013-04-17 14:03   ` [PATCH BlueZ v3 00/16] attrib: Replace GLib basic data types usage Jefferson Delfes
2013-04-17 14:03     ` Jefferson Delfes [this message]
2013-04-17 14:03     ` [PATCH BlueZ v3 02/16] attrib: Change GAttrib->stale type from gboolean Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 03/16] attrib: Change command->sent " Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 04/16] attrib: Change is_response return " Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 05/16] attrib: Change match_event " Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 06/16] attrib: Change g_attrib_set_destroy_function return type Jefferson Delfes
2013-04-24 14:02       ` Johan Hedberg
2013-05-02 16:05         ` Marcel Holtmann
2013-04-17 14:03     ` [PATCH BlueZ v3 07/16] attrib: Change g_attrib_cancel/_all " Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 08/16] attrib: Change g_attrib_unregister/_all " Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 09/16] attrib: Change g_attrib_set_debug return type from gboolean Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 10/16] attrib: Change g_attrib_set_mtu " Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 11/16] attrib: Change g_attrib_is_encrypted " Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 12/16] attrib: Change command->opcode type from guint8 Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 13/16] attrib: Change event->handle type from guint16 Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 14/16] attrib: Change command->id type from guint Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 15/16] attrib: Change event->id " Jefferson Delfes
2013-04-17 14:03     ` [PATCH BlueZ v3 16/16] attrib: Change command->pdu pointer type from guint8 Jefferson Delfes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366207399-29536-2-git-send-email-jefferson.delfes@openbossa.org \
    --to=jefferson.delfes@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox