From: Johan Hedberg <johan.hedberg@gmail.com>
To: Jefferson Delfes <jefferson.delfes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org
Subject: Re: [PATCH BlueZ v3 06/16] attrib: Change g_attrib_set_destroy_function return type
Date: Wed, 24 Apr 2013 17:02:45 +0300 [thread overview]
Message-ID: <20130424140245.GB18679@x220> (raw)
In-Reply-To: <1366207399-29536-7-git-send-email-jefferson.delfes@openbossa.org>
Hi Jefferson,
On Wed, Apr 17, 2013, Jefferson Delfes wrote:
> -gboolean g_attrib_set_destroy_function(GAttrib *attrib,
> - GDestroyNotify destroy, gpointer user_data)
> +bool g_attrib_set_destroy_function(GAttrib *attrib, GDestroyNotify destroy,
> + gpointer user_data)
I've applied patches 1-5 but stopped there since I'm still not sure that
we want to change this for an API which tries to follow GLib conventions
(after all that's why the GAttrib API has G and g_ prefixes). Marcel, do
you have any opinion about this one way or another?
Johan
next prev parent reply other threads:[~2013-04-24 14:02 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 15:39 [PATCH BlueZ 00/16] attrib: Replace GLib basic data types usage Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 01/16] attrib: Simplify boolean tests Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 02/16] attrib: Change GAttrib->stale type from gboolean Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 03/16] attrib: Change command->sent " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 04/16] attrib: Change is_response return " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 05/16] attrib: Change match_event " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 06/16] attrib: Change g_attrib_set_destroy_function return type Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 07/16] attrib: Change g_attrib_cancel/_all " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 08/16] attrib: Change g_attrib_unregister/_all " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 09/16] attrib: Change g_attrib_set_debug return type from gboolean Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 10/16] attrib: Change g_attrib_set_mtu " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 11/16] attrib: Change g_attrib_is_encrypted " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 12/16] attrib: Change command->opcode type from guint8 Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 13/16] attrib: Change event->handle type from guint16 Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 14/16] attrib: Change command->id type from guint Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 15/16] attrib: Change event->id " Jefferson Delfes
2013-03-28 15:39 ` [PATCH BlueZ 16/16] attrib: Change command->pdu pointer type from guint8 Jefferson Delfes
2013-04-10 19:16 ` [PATCH BlueZ v2 00/16] attrib: Replace GLib basic data types usage Jefferson Delfes
2013-04-10 19:16 ` [PATCH BlueZ v2 01/16] attrib: Simplify boolean tests Jefferson Delfes
2013-04-10 19:16 ` [PATCH BlueZ v2 02/16] attrib: Change GAttrib->stale type from gboolean Jefferson Delfes
2013-04-10 19:16 ` [PATCH BlueZ v2 03/16] attrib: Change command->sent " Jefferson Delfes
2013-04-10 19:16 ` [PATCH BlueZ v2 04/16] attrib: Change is_response return " Jefferson Delfes
2013-04-10 19:16 ` [PATCH BlueZ v2 05/16] attrib: Change match_event " Jefferson Delfes
2013-04-10 19:16 ` [PATCH BlueZ v2 06/16] attrib: Change g_attrib_set_destroy_function return type Jefferson Delfes
2013-04-10 19:16 ` [PATCH BlueZ v2 07/16] attrib: Change g_attrib_cancel/_all " Jefferson Delfes
2013-04-10 19:16 ` [PATCH BlueZ v2 08/16] attrib: Change g_attrib_unregister/_all " Jefferson Delfes
2013-04-10 19:16 ` [PATCH BlueZ v2 09/16] attrib: Change g_attrib_set_debug return type from gboolean Jefferson Delfes
2013-04-10 19:16 ` [PATCH BlueZ v2 10/16] attrib: Change g_attrib_set_mtu " Jefferson Delfes
2013-04-10 19:16 ` [PATCH BlueZ v2 11/16] attrib: Change g_attrib_is_encrypted " Jefferson Delfes
2013-04-10 19:16 ` [PATCH BlueZ v2 12/16] attrib: Change command->opcode type from guint8 Jefferson Delfes
2013-04-10 19:16 ` [PATCH BlueZ v2 13/16] attrib: Change event->handle type from guint16 Jefferson Delfes
2013-04-10 19:16 ` [PATCH BlueZ v2 14/16] attrib: Change command->id type from guint Jefferson Delfes
2013-04-10 19:17 ` [PATCH BlueZ v2 15/16] attrib: Change event->id " Jefferson Delfes
2013-04-10 19:17 ` [PATCH BlueZ v2 16/16] attrib: Change command->pdu pointer type from guint8 Jefferson Delfes
2013-04-17 14:03 ` [PATCH BlueZ v3 00/16] attrib: Replace GLib basic data types usage Jefferson Delfes
2013-04-17 14:03 ` [PATCH BlueZ v3 01/16] attrib: Simplify boolean tests Jefferson Delfes
2013-04-17 14:03 ` [PATCH BlueZ v3 02/16] attrib: Change GAttrib->stale type from gboolean Jefferson Delfes
2013-04-17 14:03 ` [PATCH BlueZ v3 03/16] attrib: Change command->sent " Jefferson Delfes
2013-04-17 14:03 ` [PATCH BlueZ v3 04/16] attrib: Change is_response return " Jefferson Delfes
2013-04-17 14:03 ` [PATCH BlueZ v3 05/16] attrib: Change match_event " Jefferson Delfes
2013-04-17 14:03 ` [PATCH BlueZ v3 06/16] attrib: Change g_attrib_set_destroy_function return type Jefferson Delfes
2013-04-24 14:02 ` Johan Hedberg [this message]
2013-05-02 16:05 ` Marcel Holtmann
2013-04-17 14:03 ` [PATCH BlueZ v3 07/16] attrib: Change g_attrib_cancel/_all " Jefferson Delfes
2013-04-17 14:03 ` [PATCH BlueZ v3 08/16] attrib: Change g_attrib_unregister/_all " Jefferson Delfes
2013-04-17 14:03 ` [PATCH BlueZ v3 09/16] attrib: Change g_attrib_set_debug return type from gboolean Jefferson Delfes
2013-04-17 14:03 ` [PATCH BlueZ v3 10/16] attrib: Change g_attrib_set_mtu " Jefferson Delfes
2013-04-17 14:03 ` [PATCH BlueZ v3 11/16] attrib: Change g_attrib_is_encrypted " Jefferson Delfes
2013-04-17 14:03 ` [PATCH BlueZ v3 12/16] attrib: Change command->opcode type from guint8 Jefferson Delfes
2013-04-17 14:03 ` [PATCH BlueZ v3 13/16] attrib: Change event->handle type from guint16 Jefferson Delfes
2013-04-17 14:03 ` [PATCH BlueZ v3 14/16] attrib: Change command->id type from guint Jefferson Delfes
2013-04-17 14:03 ` [PATCH BlueZ v3 15/16] attrib: Change event->id " Jefferson Delfes
2013-04-17 14:03 ` [PATCH BlueZ v3 16/16] attrib: Change command->pdu pointer type from guint8 Jefferson Delfes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130424140245.GB18679@x220 \
--to=johan.hedberg@gmail.com \
--cc=jefferson.delfes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox