* [PATCH BlueZ 1/2] tools: Remove simple-service
@ 2014-04-14 12:40 Luiz Augusto von Dentz
2014-04-14 12:40 ` [PATCH BlueZ 2/2] core/profile: Fix regression when registering for client only Luiz Augusto von Dentz
2014-04-16 9:50 ` [PATCH BlueZ 1/2] tools: Remove simple-service Szymon Janc
0 siblings, 2 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2014-04-14 12:40 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
simple-service no longer works since the API it uses no longer exists and
Profile API already has a similar tool.
---
test/simple-service | 128 ----------------------------------------------------
1 file changed, 128 deletions(-)
delete mode 100755 test/simple-service
diff --git a/test/simple-service b/test/simple-service
deleted file mode 100755
index 02d7648..0000000
--- a/test/simple-service
+++ /dev/null
@@ -1,128 +0,0 @@
-#!/usr/bin/python
-
-from __future__ import absolute_import, print_function, unicode_literals
-
-import sys
-import time
-import dbus
-import bluezutils
-
-xml = ' \
-<?xml version="1.0" encoding="UTF-8" ?> \
-<record> \
- <attribute id="0x0001"> \
- <sequence> \
- <uuid value="0x1101"/> \
- </sequence> \
- </attribute> \
- \
- <attribute id="0x0002"> \
- <uint32 value="0"/> \
- </attribute> \
- \
- <attribute id="0x0003"> \
- <uuid value="00001101-0000-1000-8000-00805f9b34fb"/> \
- </attribute> \
- \
- <attribute id="0x0004"> \
- <sequence> \
- <sequence> \
- <uuid value="0x0100"/> \
- </sequence> \
- <sequence> \
- <uuid value="0x0003"/> \
- <uint8 value="23"/> \
- </sequence> \
- </sequence> \
- </attribute> \
- \
- <attribute id="0x0005"> \
- <sequence> \
- <uuid value="0x1002"/> \
- </sequence> \
- </attribute> \
- \
- <attribute id="0x0006"> \
- <sequence> \
- <uint16 value="0x656e"/> \
- <uint16 value="0x006a"/> \
- <uint16 value="0x0100"/> \
- </sequence> \
- </attribute> \
- \
- <attribute id="0x0007"> \
- <uint32 value="0"/> \
- </attribute> \
- \
- <attribute id="0x0008"> \
- <uint8 value="0xff"/> \
- </attribute> \
- \
- <attribute id="0x0009"> \
- <sequence> \
- <sequence> \
- <uuid value="0x1101"/> \
- <uint16 value="0x0100"/> \
- </sequence> \
- </sequence> \
- </attribute> \
- \
- <attribute id="0x000a"> \
- <url value="http://www.bluez.org/"/> \
- </attribute> \
- \
- <attribute id="0x000b"> \
- <url value="http://www.bluez.org/"/> \
- </attribute> \
- \
- <attribute id="0x000c"> \
- <url value="http://www.bluez.org/"/> \
- </attribute> \
- \
- <attribute id="0x0100"> \
- <text value="Serial Port"/> \
- </attribute> \
- \
- <attribute id="0x0101"> \
- <text value="Serial Port Service"/> \
- </attribute> \
- \
- <attribute id="0x0102"> \
- <text value="BlueZ"/> \
- </attribute> \
- \
- <attribute id="0x0200"> \
- <sequence> \
- <uint16 value="0x0100"/> \
- </sequence> \
- </attribute> \
- \
- <attribute id="0x0201"> \
- <uint32 value="0"/> \
- </attribute> \
-</record> \
-'
-
-bus = dbus.SystemBus()
-
-if len(sys.argv) > 1:
- path = bluezutils.find_adapter(sys.argv[1]).object_path
-else:
- path = bluezutils.find_adapter().object_path
-
-service = dbus.Interface(bus.get_object("org.bluez", path),
- "org.bluez.Service")
-
-handle = service.AddRecord(xml)
-
-print("Service record with handle 0x%04x added" % (handle))
-
-print("Press CTRL-C to remove service record")
-
-try:
- time.sleep(1000)
- print("Terminating session")
-except:
- pass
-
-service.RemoveRecord(dbus.UInt32(handle))
--
1.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH BlueZ 2/2] core/profile: Fix regression when registering for client only
2014-04-14 12:40 [PATCH BlueZ 1/2] tools: Remove simple-service Luiz Augusto von Dentz
@ 2014-04-14 12:40 ` Luiz Augusto von Dentz
2014-04-16 9:50 ` [PATCH BlueZ 1/2] tools: Remove simple-service Szymon Janc
1 sibling, 0 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2014-04-14 12:40 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This got introduced with PCE that register a record for PBAP client, but
it end up causing a regression where all profiles that have records would
be probed as if server was enabled as well.
Note that is was possible to register PBAP client with PCE record, in
that case Role option should be omitted so both server and client role
are enabled by default which does not affect PBAP server component since
it uses a different UUID, in fact the correct form to add PCE record is
probably to register as server only.
---
src/profile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/profile.c b/src/profile.c
index f065235..f30f4f6 100644
--- a/src/profile.c
+++ b/src/profile.c
@@ -2209,7 +2209,7 @@ static struct ext_profile *create_ext(const char *owner, const char *path,
p->local_uuid = ext->service ? ext->service : ext->uuid;
p->remote_uuid = ext->remote_uuid;
- if (ext->enable_server || ext->record || ext->get_record) {
+ if (ext->enable_server) {
p->adapter_probe = ext_adapter_probe;
p->adapter_remove = ext_adapter_remove;
}
--
1.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH BlueZ 1/2] tools: Remove simple-service
2014-04-14 12:40 [PATCH BlueZ 1/2] tools: Remove simple-service Luiz Augusto von Dentz
2014-04-14 12:40 ` [PATCH BlueZ 2/2] core/profile: Fix regression when registering for client only Luiz Augusto von Dentz
@ 2014-04-16 9:50 ` Szymon Janc
2014-04-22 7:52 ` Luiz Augusto von Dentz
1 sibling, 1 reply; 4+ messages in thread
From: Szymon Janc @ 2014-04-16 9:50 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: linux-bluetooth
Hi Luiz,
On Monday 14 of April 2014 15:40:01 Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> simple-service no longer works since the API it uses no longer exists and
> Profile API already has a similar tool.
> ---
> test/simple-service | 128 ----------------------------------------------------
> 1 file changed, 128 deletions(-)
> delete mode 100755 test/simple-service
You should also remove it from Makefile.tools.
>
> diff --git a/test/simple-service b/test/simple-service
> deleted file mode 100755
> index 02d7648..0000000
> --- a/test/simple-service
> +++ /dev/null
> @@ -1,128 +0,0 @@
> -#!/usr/bin/python
> -
> -from __future__ import absolute_import, print_function, unicode_literals
> -
> -import sys
> -import time
> -import dbus
> -import bluezutils
> -
> -xml = ' \
> -<?xml version="1.0" encoding="UTF-8" ?> \
> -<record> \
> - <attribute id="0x0001"> \
> - <sequence> \
> - <uuid value="0x1101"/> \
> - </sequence> \
> - </attribute> \
> - \
> - <attribute id="0x0002"> \
> - <uint32 value="0"/> \
> - </attribute> \
> - \
> - <attribute id="0x0003"> \
> - <uuid value="00001101-0000-1000-8000-00805f9b34fb"/> \
> - </attribute> \
> - \
> - <attribute id="0x0004"> \
> - <sequence> \
> - <sequence> \
> - <uuid value="0x0100"/> \
> - </sequence> \
> - <sequence> \
> - <uuid value="0x0003"/> \
> - <uint8 value="23"/> \
> - </sequence> \
> - </sequence> \
> - </attribute> \
> - \
> - <attribute id="0x0005"> \
> - <sequence> \
> - <uuid value="0x1002"/> \
> - </sequence> \
> - </attribute> \
> - \
> - <attribute id="0x0006"> \
> - <sequence> \
> - <uint16 value="0x656e"/> \
> - <uint16 value="0x006a"/> \
> - <uint16 value="0x0100"/> \
> - </sequence> \
> - </attribute> \
> - \
> - <attribute id="0x0007"> \
> - <uint32 value="0"/> \
> - </attribute> \
> - \
> - <attribute id="0x0008"> \
> - <uint8 value="0xff"/> \
> - </attribute> \
> - \
> - <attribute id="0x0009"> \
> - <sequence> \
> - <sequence> \
> - <uuid value="0x1101"/> \
> - <uint16 value="0x0100"/> \
> - </sequence> \
> - </sequence> \
> - </attribute> \
> - \
> - <attribute id="0x000a"> \
> - <url value="http://www.bluez.org/"/> \
> - </attribute> \
> - \
> - <attribute id="0x000b"> \
> - <url value="http://www.bluez.org/"/> \
> - </attribute> \
> - \
> - <attribute id="0x000c"> \
> - <url value="http://www.bluez.org/"/> \
> - </attribute> \
> - \
> - <attribute id="0x0100"> \
> - <text value="Serial Port"/> \
> - </attribute> \
> - \
> - <attribute id="0x0101"> \
> - <text value="Serial Port Service"/> \
> - </attribute> \
> - \
> - <attribute id="0x0102"> \
> - <text value="BlueZ"/> \
> - </attribute> \
> - \
> - <attribute id="0x0200"> \
> - <sequence> \
> - <uint16 value="0x0100"/> \
> - </sequence> \
> - </attribute> \
> - \
> - <attribute id="0x0201"> \
> - <uint32 value="0"/> \
> - </attribute> \
> -</record> \
> -'
> -
> -bus = dbus.SystemBus()
> -
> -if len(sys.argv) > 1:
> - path = bluezutils.find_adapter(sys.argv[1]).object_path
> -else:
> - path = bluezutils.find_adapter().object_path
> -
> -service = dbus.Interface(bus.get_object("org.bluez", path),
> - "org.bluez.Service")
> -
> -handle = service.AddRecord(xml)
> -
> -print("Service record with handle 0x%04x added" % (handle))
> -
> -print("Press CTRL-C to remove service record")
> -
> -try:
> - time.sleep(1000)
> - print("Terminating session")
> -except:
> - pass
> -
> -service.RemoveRecord(dbus.UInt32(handle))
>
--
Best regards,
Szymon Janc
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH BlueZ 1/2] tools: Remove simple-service
2014-04-16 9:50 ` [PATCH BlueZ 1/2] tools: Remove simple-service Szymon Janc
@ 2014-04-22 7:52 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2014-04-22 7:52 UTC (permalink / raw)
To: Szymon Janc; +Cc: linux-bluetooth@vger.kernel.org
Hi Szymon,
On Wed, Apr 16, 2014 at 12:50 PM, Szymon Janc <szymon.janc@tieto.com> wrote:
> Hi Luiz,
>
> On Monday 14 of April 2014 15:40:01 Luiz Augusto von Dentz wrote:
>> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>>
>> simple-service no longer works since the API it uses no longer exists and
>> Profile API already has a similar tool.
>> ---
>> test/simple-service | 128 ----------------------------------------------------
>> 1 file changed, 128 deletions(-)
>> delete mode 100755 test/simple-service
>
> You should also remove it from Makefile.tools.
>
>>
>> diff --git a/test/simple-service b/test/simple-service
>> deleted file mode 100755
>> index 02d7648..0000000
>> --- a/test/simple-service
>> +++ /dev/null
>> @@ -1,128 +0,0 @@
>> -#!/usr/bin/python
>> -
>> -from __future__ import absolute_import, print_function, unicode_literals
>> -
>> -import sys
>> -import time
>> -import dbus
>> -import bluezutils
>> -
>> -xml = ' \
>> -<?xml version="1.0" encoding="UTF-8" ?> \
>> -<record> \
>> - <attribute id="0x0001"> \
>> - <sequence> \
>> - <uuid value="0x1101"/> \
>> - </sequence> \
>> - </attribute> \
>> - \
>> - <attribute id="0x0002"> \
>> - <uint32 value="0"/> \
>> - </attribute> \
>> - \
>> - <attribute id="0x0003"> \
>> - <uuid value="00001101-0000-1000-8000-00805f9b34fb"/> \
>> - </attribute> \
>> - \
>> - <attribute id="0x0004"> \
>> - <sequence> \
>> - <sequence> \
>> - <uuid value="0x0100"/> \
>> - </sequence> \
>> - <sequence> \
>> - <uuid value="0x0003"/> \
>> - <uint8 value="23"/> \
>> - </sequence> \
>> - </sequence> \
>> - </attribute> \
>> - \
>> - <attribute id="0x0005"> \
>> - <sequence> \
>> - <uuid value="0x1002"/> \
>> - </sequence> \
>> - </attribute> \
>> - \
>> - <attribute id="0x0006"> \
>> - <sequence> \
>> - <uint16 value="0x656e"/> \
>> - <uint16 value="0x006a"/> \
>> - <uint16 value="0x0100"/> \
>> - </sequence> \
>> - </attribute> \
>> - \
>> - <attribute id="0x0007"> \
>> - <uint32 value="0"/> \
>> - </attribute> \
>> - \
>> - <attribute id="0x0008"> \
>> - <uint8 value="0xff"/> \
>> - </attribute> \
>> - \
>> - <attribute id="0x0009"> \
>> - <sequence> \
>> - <sequence> \
>> - <uuid value="0x1101"/> \
>> - <uint16 value="0x0100"/> \
>> - </sequence> \
>> - </sequence> \
>> - </attribute> \
>> - \
>> - <attribute id="0x000a"> \
>> - <url value="http://www.bluez.org/"/> \
>> - </attribute> \
>> - \
>> - <attribute id="0x000b"> \
>> - <url value="http://www.bluez.org/"/> \
>> - </attribute> \
>> - \
>> - <attribute id="0x000c"> \
>> - <url value="http://www.bluez.org/"/> \
>> - </attribute> \
>> - \
>> - <attribute id="0x0100"> \
>> - <text value="Serial Port"/> \
>> - </attribute> \
>> - \
>> - <attribute id="0x0101"> \
>> - <text value="Serial Port Service"/> \
>> - </attribute> \
>> - \
>> - <attribute id="0x0102"> \
>> - <text value="BlueZ"/> \
>> - </attribute> \
>> - \
>> - <attribute id="0x0200"> \
>> - <sequence> \
>> - <uint16 value="0x0100"/> \
>> - </sequence> \
>> - </attribute> \
>> - \
>> - <attribute id="0x0201"> \
>> - <uint32 value="0"/> \
>> - </attribute> \
>> -</record> \
>> -'
>> -
>> -bus = dbus.SystemBus()
>> -
>> -if len(sys.argv) > 1:
>> - path = bluezutils.find_adapter(sys.argv[1]).object_path
>> -else:
>> - path = bluezutils.find_adapter().object_path
>> -
>> -service = dbus.Interface(bus.get_object("org.bluez", path),
>> - "org.bluez.Service")
>> -
>> -handle = service.AddRecord(xml)
>> -
>> -print("Service record with handle 0x%04x added" % (handle))
>> -
>> -print("Press CTRL-C to remove service record")
>> -
>> -try:
>> - time.sleep(1000)
>> - print("Terminating session")
>> -except:
>> - pass
>> -
>> -service.RemoveRecord(dbus.UInt32(handle))
>>
Pushed with the correction.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-22 7:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-14 12:40 [PATCH BlueZ 1/2] tools: Remove simple-service Luiz Augusto von Dentz
2014-04-14 12:40 ` [PATCH BlueZ 2/2] core/profile: Fix regression when registering for client only Luiz Augusto von Dentz
2014-04-16 9:50 ` [PATCH BlueZ 1/2] tools: Remove simple-service Szymon Janc
2014-04-22 7:52 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox