* [PATCH] android/core: Fix extra assignment
@ 2014-09-26 8:16 Andrei Emeltchenko
2014-09-26 9:54 ` Szymon Janc
0 siblings, 1 reply; 2+ messages in thread
From: Andrei Emeltchenko @ 2014-09-26 8:16 UTC (permalink / raw)
To: linux-bluetooth
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
prop is assigned in the beginning of for() loop. Fixes warning:
...
android/main.c:336:3: warning: Value stored to 'prop' is never read
prop = buf;
^ ~~~
...
---
android/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/android/main.c b/android/main.c
index 663995e..2bc2dfe 100644
--- a/android/main.c
+++ b/android/main.c
@@ -334,7 +334,6 @@ static void configuration(const void *buf, uint16_t len)
buf += sizeof(*prop) + prop->len;
len -= sizeof(*prop) + prop->len;
- prop = buf;
}
ipc_send_rsp(hal_ipc, HAL_SERVICE_ID_CORE, HAL_OP_CONFIGURATION,
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] android/core: Fix extra assignment
2014-09-26 8:16 [PATCH] android/core: Fix extra assignment Andrei Emeltchenko
@ 2014-09-26 9:54 ` Szymon Janc
0 siblings, 0 replies; 2+ messages in thread
From: Szymon Janc @ 2014-09-26 9:54 UTC (permalink / raw)
To: Andrei Emeltchenko; +Cc: linux-bluetooth
Hi Andrei,
On Friday 26 of September 2014 11:16:45 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> prop is assigned in the beginning of for() loop. Fixes warning:
> ...
> android/main.c:336:3: warning: Value stored to 'prop' is never read
> prop = buf;
> ^ ~~~
> ...
> ---
> android/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/android/main.c b/android/main.c
> index 663995e..2bc2dfe 100644
> --- a/android/main.c
> +++ b/android/main.c
> @@ -334,7 +334,6 @@ static void configuration(const void *buf, uint16_t len)
>
> buf += sizeof(*prop) + prop->len;
> len -= sizeof(*prop) + prop->len;
> - prop = buf;
> }
>
> ipc_send_rsp(hal_ipc, HAL_SERVICE_ID_CORE, HAL_OP_CONFIGURATION,
>
Applied, thanks.
--
Best regards,
Szymon Janc
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-26 9:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-26 8:16 [PATCH] android/core: Fix extra assignment Andrei Emeltchenko
2014-09-26 9:54 ` Szymon Janc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox