* [PATCH] android/log: Add missing libc includes.
@ 2015-02-02 8:33 Ian Coolidge
2015-02-02 11:50 ` Szymon Janc
0 siblings, 1 reply; 4+ messages in thread
From: Ian Coolidge @ 2015-02-02 8:33 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Ian Coolidge
---
android/log.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/android/log.c b/android/log.c
index 09d226a..8013eba 100644
--- a/android/log.c
+++ b/android/log.c
@@ -25,7 +25,10 @@
#endif
#include <fcntl.h>
+#include <stdarg.h>
#include <stdio.h>
+#include <stdint.h>
+#include <stdlib.h>
#include <unistd.h>
#include <stdbool.h>
#include <time.h>
--
2.2.0.rc0.207.ga3a616c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] android/log: Add missing libc includes.
2015-02-02 8:33 [PATCH] android/log: Add missing libc includes Ian Coolidge
@ 2015-02-02 11:50 ` Szymon Janc
2015-02-02 19:10 ` [PATCH v2] " Ian Coolidge
0 siblings, 1 reply; 4+ messages in thread
From: Szymon Janc @ 2015-02-02 11:50 UTC (permalink / raw)
To: Ian Coolidge; +Cc: linux-bluetooth
Hi Ian,
On Monday 02 of February 2015 00:33:48 Ian Coolidge wrote:
> ---
> android/log.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/android/log.c b/android/log.c
> index 09d226a..8013eba 100644
> --- a/android/log.c
> +++ b/android/log.c
> @@ -25,7 +25,10 @@
> #endif
>
> #include <fcntl.h>
> +#include <stdarg.h>
> #include <stdio.h>
> +#include <stdint.h>
> +#include <stdlib.h>
> #include <unistd.h>
> #include <stdbool.h>
> #include <time.h>
Could you add some explanation to commit message why those are needed?
--
Best regards,
Szymon Janc
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] android/log: Add missing libc includes.
2015-02-02 11:50 ` Szymon Janc
@ 2015-02-02 19:10 ` Ian Coolidge
2015-02-03 9:54 ` Szymon Janc
0 siblings, 1 reply; 4+ messages in thread
From: Ian Coolidge @ 2015-02-02 19:10 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Ian Coolidge
Bionic is moving to reduce the amount of transitive includes,
so they should not be relied upon.
---
android/log.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/android/log.c b/android/log.c
index 09d226a..8013eba 100644
--- a/android/log.c
+++ b/android/log.c
@@ -25,7 +25,10 @@
#endif
#include <fcntl.h>
+#include <stdarg.h>
#include <stdio.h>
+#include <stdint.h>
+#include <stdlib.h>
#include <unistd.h>
#include <stdbool.h>
#include <time.h>
--
2.2.0.rc0.207.ga3a616c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] android/log: Add missing libc includes.
2015-02-02 19:10 ` [PATCH v2] " Ian Coolidge
@ 2015-02-03 9:54 ` Szymon Janc
0 siblings, 0 replies; 4+ messages in thread
From: Szymon Janc @ 2015-02-03 9:54 UTC (permalink / raw)
To: Ian Coolidge; +Cc: linux-bluetooth
Hi Ian,
On Monday 02 of February 2015 11:10:40 Ian Coolidge wrote:
> Bionic is moving to reduce the amount of transitive includes,
> so they should not be relied upon.
> ---
> android/log.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/android/log.c b/android/log.c
> index 09d226a..8013eba 100644
> --- a/android/log.c
> +++ b/android/log.c
> @@ -25,7 +25,10 @@
> #endif
>
> #include <fcntl.h>
> +#include <stdarg.h>
> #include <stdio.h>
> +#include <stdint.h>
> +#include <stdlib.h>
> #include <unistd.h>
> #include <stdbool.h>
> #include <time.h>
>
Patch applied, thanks.
--
Best regards,
Szymon Janc
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-03 9:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-02 8:33 [PATCH] android/log: Add missing libc includes Ian Coolidge
2015-02-02 11:50 ` Szymon Janc
2015-02-02 19:10 ` [PATCH v2] " Ian Coolidge
2015-02-03 9:54 ` Szymon Janc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox