[PATCH v1] Bluetooth: btintel_pcie: Fix SCP DBGC base address

[PATCH v1] Bluetooth: btintel_pcie: Fix SCP DBGC base address

[Chandrashekar Devegowda]

BTINTEL_PCIE_DBGC_BASE_ADDR_SCP is defined as 0xf0d5d500, one register
row past the base of the SCP debug controller. The status and
wrap-around registers derived from it at offsets 0x1C and 0x2C
therefore point at the wrong addresses, and the debug buffer status
and wrap-around state read while dumping SCP debug traces are
incorrect.

Use 0xf0d5d400 so that the derived offsets land on the intended
registers.

Fixes: e43b33bf8d67 ("Bluetooth: btintel_pcie: Load IOSF debug regs by controller variant")
Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
---
 drivers/bluetooth/btintel_pcie.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btintel_pcie.h b/drivers/bluetooth/btintel_pcie.h
index f04dfb0b30fa..c11620dbec46 100644
--- a/drivers/bluetooth/btintel_pcie.h
+++ b/drivers/bluetooth/btintel_pcie.h
@@ -82,7 +82,7 @@
 #define BTINTEL_PCIE_DBGC_CUR_DBGBUFF_STATUS		(BTINTEL_PCIE_DBGC_BASE_ADDR + 0x1C)
 #define BTINTEL_PCIE_DBGC_DBGBUFF_WRAP_ARND		(BTINTEL_PCIE_DBGC_BASE_ADDR + 0x2C)
 
-#define BTINTEL_PCIE_DBGC_BASE_ADDR_SCP			(0xf0d5d500)
+#define BTINTEL_PCIE_DBGC_BASE_ADDR_SCP			(0xf0d5d400)
 #define BTINTEL_PCIE_DBGC_CUR_DBGBUFF_STATUS_SCP	(BTINTEL_PCIE_DBGC_BASE_ADDR_SCP + 0x1C)
 #define BTINTEL_PCIE_DBGC_DBGBUFF_WRAP_ARND_SCP		(BTINTEL_PCIE_DBGC_BASE_ADDR_SCP + 0x2C)
 #define BTINTEL_PCIE_DBGC_ALLOCATION_OFFSET		0x100
-- 
2.43.0

Re: [PATCH v1] Bluetooth: btintel_pcie: Fix SCP DBGC base address

[Paul Menzel]

[Cc: +Sai as the author of the fixed commit]

Dear Chandrashekar,


Thank you for your patch.

Am 04.11.26 um 07:45 schrieb Chandrashekar Devegowda:
> BTINTEL_PCIE_DBGC_BASE_ADDR_SCP is defined as 0xf0d5d500, one register
> row past the base of the SCP debug controller.

Please mention the source where to verify that? Was some typo in the 
datasheet corrected?

> The status and
> wrap-around registers derived from it at offsets 0x1C and 0x2C
> therefore point at the wrong addresses, and the debug buffer status
> and wrap-around state read while dumping SCP debug traces are
> incorrect.
> 
> Use 0xf0d5d400 so that the derived offsets land on the intended
> registers.

Please configure your editor to use the official line length limit of 75 
characters. That would save two lines here.

Please add a paragraph to how to test this.

> Fixes: e43b33bf8d67 ("Bluetooth: btintel_pcie: Load IOSF debug regs by controller variant")
> Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
> ---
>   drivers/bluetooth/btintel_pcie.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btintel_pcie.h b/drivers/bluetooth/btintel_pcie.h
> index f04dfb0b30fa..c11620dbec46 100644
> --- a/drivers/bluetooth/btintel_pcie.h
> +++ b/drivers/bluetooth/btintel_pcie.h
> @@ -82,7 +82,7 @@
>   #define BTINTEL_PCIE_DBGC_CUR_DBGBUFF_STATUS		(BTINTEL_PCIE_DBGC_BASE_ADDR + 0x1C)
>   #define BTINTEL_PCIE_DBGC_DBGBUFF_WRAP_ARND		(BTINTEL_PCIE_DBGC_BASE_ADDR + 0x2C)
>   
> -#define BTINTEL_PCIE_DBGC_BASE_ADDR_SCP			(0xf0d5d500)
> +#define BTINTEL_PCIE_DBGC_BASE_ADDR_SCP			(0xf0d5d400)
>   #define BTINTEL_PCIE_DBGC_CUR_DBGBUFF_STATUS_SCP	(BTINTEL_PCIE_DBGC_BASE_ADDR_SCP + 0x1C)
>   #define BTINTEL_PCIE_DBGC_DBGBUFF_WRAP_ARND_SCP		(BTINTEL_PCIE_DBGC_BASE_ADDR_SCP + 0x2C)
>   #define BTINTEL_PCIE_DBGC_ALLOCATION_OFFSET		0x100


Kind regards,

Paul

RE: [PATCH v1] Bluetooth: btintel_pcie: Fix SCP DBGC base address

[Devegowda, Chandrashekar]

Hi Paul
    Thanks for the comments.

> -----Original Message-----
> From: Paul Menzel <pmenzel@molgen.mpg.de>
> Sent: Wednesday, November 04, 2026 12:35 PM
> To: Devegowda, Chandrashekar <chandrashekar.devegowda@intel.com>
> Cc: linux-bluetooth@vger.kernel.org; Tumkur Narayan, Chethan
> <chethan.tumkur.narayan@intel.com>; K, Kiran <kiran.k@intel.com>; Aluvala
> Sai Teja <aluvala.sai.teja@intel.com>
> Subject: Re: [PATCH v1] Bluetooth: btintel_pcie: Fix SCP DBGC base address
> 
> [Cc: +Sai as the author of the fixed commit]
> 
> Dear Chandrashekar,
> 
> 
> Thank you for your patch.
> 
> Am 04.11.26 um 07:45 schrieb Chandrashekar Devegowda:
> > BTINTEL_PCIE_DBGC_BASE_ADDR_SCP is defined as 0xf0d5d500, one
> register
> > row past the base of the SCP debug controller.
> 
> Please mention the source where to verify that? Was some typo in the
> datasheet corrected?

This was a typo and the dump was verified with the corrected base address.
 
> > The status and
> > wrap-around registers derived from it at offsets 0x1C and 0x2C
> > therefore point at the wrong addresses, and the debug buffer status
> > and wrap-around state read while dumping SCP debug traces are
> > incorrect.
> >
> > Use 0xf0d5d400 so that the derived offsets land on the intended
> > registers.
> 
> Please configure your editor to use the official line length limit of 75
> characters. That would save two lines here.

Ack

> 
> Please add a paragraph to how to test this.

Ack, will add the details.

> 
> > Fixes: e43b33bf8d67 ("Bluetooth: btintel_pcie: Load IOSF debug regs by
> > controller variant")
> > Signed-off-by: Chandrashekar Devegowda
> > <chandrashekar.devegowda@intel.com>
> > ---
> >   drivers/bluetooth/btintel_pcie.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/bluetooth/btintel_pcie.h
> > b/drivers/bluetooth/btintel_pcie.h
> > index f04dfb0b30fa..c11620dbec46 100644
> > --- a/drivers/bluetooth/btintel_pcie.h
> > +++ b/drivers/bluetooth/btintel_pcie.h
> > @@ -82,7 +82,7 @@
> >   #define BTINTEL_PCIE_DBGC_CUR_DBGBUFF_STATUS
> 	(BTINTEL_PCIE_DBGC_BASE_ADDR + 0x1C)
> >   #define BTINTEL_PCIE_DBGC_DBGBUFF_WRAP_ARND
> 	(BTINTEL_PCIE_DBGC_BASE_ADDR + 0x2C)
> >
> > -#define BTINTEL_PCIE_DBGC_BASE_ADDR_SCP
> 	(0xf0d5d500)
> > +#define BTINTEL_PCIE_DBGC_BASE_ADDR_SCP
> 	(0xf0d5d400)
> >   #define BTINTEL_PCIE_DBGC_CUR_DBGBUFF_STATUS_SCP
> 	(BTINTEL_PCIE_DBGC_BASE_ADDR_SCP + 0x1C)
> >   #define BTINTEL_PCIE_DBGC_DBGBUFF_WRAP_ARND_SCP
> 	(BTINTEL_PCIE_DBGC_BASE_ADDR_SCP + 0x2C)
> >   #define BTINTEL_PCIE_DBGC_ALLOCATION_OFFSET		0x100
> 
> 
> Kind regards,
> 
> Paul

Thanks and Regards,
Chandru

RE: [v1] Bluetooth: btintel_pcie: Fix SCP DBGC base address

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1201364/

---Test result---

Test Summary:
CheckPatch                    PASS      0.38 seconds
VerifyFixes                   PASS      0.05 seconds
VerifySignedoff               PASS      0.05 seconds
GitLint                       PASS      0.15 seconds
SubjectPrefix                 PASS      0.05 seconds
BuildKernel                   PASS      20.39 seconds
CheckAllWarning               PASS      23.01 seconds
CheckSparse                   PASS      24.60 seconds
BuildKernel32                 PASS      20.47 seconds
CheckKernelLLVM               PASS      22.36 seconds
TestRunnerSetup               PASS      475.52 seconds
IncrementalBuild              PASS      18.85 seconds



https://github.com/bluez/bluetooth-next/pull/1060

---
Regards,
Linux Bluetooth

[PATCH v2] Bluetooth: btintel_pcie: Fix SCP DBGC base address

[Chandrashekar Devegowda]

BTINTEL_PCIE_DBGC_BASE_ADDR_SCP was entered as 0xf0d5d500 by mistake
when the define was added. The base of the SCP debug controller is
0xf0d5d400, as documented in the Intel SCP SAS document, so the value
is one register row too high. The status and wrap-around registers
derived from it at offsets 0x1C and 0x2C therefore point at the wrong
addresses, and the debug buffer status and wrap-around state read while
dumping SCP debug traces are incorrect.

Use 0xf0d5d400 so that the derived offsets land on the intended
registers.

Tested on an SCP platform by triggering a firmware exception and
collecting the resulting devcoredump. With the corrected base address,
the debug buffer status and wrap-around registers read back valid
values and the DRAM monitor buffers in the dump are decoded correctly;
with the old address they are read from the wrong registers.

Fixes: e43b33bf8d67 ("Bluetooth: btintel_pcie: Load IOSF debug regs by controller variant")
Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
---
Changes in v2:
- Rewrap commit message to 75 columns
- Explain that the original value was a typo made when the define
  was added, and cite the Intel SCP SAS document as the source of
  the correct base address
- Add a paragraph describing how the fix was tested

 drivers/bluetooth/btintel_pcie.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btintel_pcie.h b/drivers/bluetooth/btintel_pcie.h
index 4125601b78d7..181df5e14062 100644
--- a/drivers/bluetooth/btintel_pcie.h
+++ b/drivers/bluetooth/btintel_pcie.h
@@ -83,7 +83,7 @@
 #define BTINTEL_PCIE_DBGC_CUR_DBGBUFF_STATUS		(BTINTEL_PCIE_DBGC_BASE_ADDR + 0x1C)
 #define BTINTEL_PCIE_DBGC_DBGBUFF_WRAP_ARND		(BTINTEL_PCIE_DBGC_BASE_ADDR + 0x2C)
 
-#define BTINTEL_PCIE_DBGC_BASE_ADDR_SCP			(0xf0d5d500)
+#define BTINTEL_PCIE_DBGC_BASE_ADDR_SCP			(0xf0d5d400)
 #define BTINTEL_PCIE_DBGC_CUR_DBGBUFF_STATUS_SCP	(BTINTEL_PCIE_DBGC_BASE_ADDR_SCP + 0x1C)
 #define BTINTEL_PCIE_DBGC_DBGBUFF_WRAP_ARND_SCP		(BTINTEL_PCIE_DBGC_BASE_ADDR_SCP + 0x2C)
 #define BTINTEL_PCIE_DBGC_ALLOCATION_OFFSET		0x100
-- 
2.43.0

RE: [v2] Bluetooth: btintel_pcie: Fix SCP DBGC base address

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1208423/

---Test result---

Test Summary:
CheckPatch                    PASS      2.57 seconds
VerifyFixes                   PASS      0.20 seconds
VerifySignedoff               PASS      0.13 seconds
GitLint                       PASS      0.35 seconds
SubjectPrefix                 PASS      0.13 seconds
BuildKernel                   PASS      31.71 seconds
CheckAllWarning               PASS      36.31 seconds
CheckSparse                   PASS      39.09 seconds
BuildKernel32                 PASS      31.94 seconds
CheckKernelLLVM               PASS      34.23 seconds
TestRunnerSetup               PASS      744.21 seconds
IncrementalBuild              PASS      29.33 seconds



https://github.com/bluez/bluetooth-next/pull/1112

---
Regards,
Linux Bluetooth

Re: [PATCH v2] Bluetooth: btintel_pcie: Fix SCP DBGC base address

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 11 Nov 2026 19:48:22 +0530 you wrote:
> BTINTEL_PCIE_DBGC_BASE_ADDR_SCP was entered as 0xf0d5d500 by mistake
> when the define was added. The base of the SCP debug controller is
> 0xf0d5d400, as documented in the Intel SCP SAS document, so the value
> is one register row too high. The status and wrap-around registers
> derived from it at offsets 0x1C and 0x2C therefore point at the wrong
> addresses, and the debug buffer status and wrap-around state read while
> dumping SCP debug traces are incorrect.
> 
> [...]

Here is the summary with links:
  - [v2] Bluetooth: btintel_pcie: Fix SCP DBGC base address
    https://git.kernel.org/bluetooth/bluetooth-next/c/1752a2c40059

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html