From: Johan Hedberg <johan.hedberg@gmail.com>
To: Peter Hurley <phurley@charter.net>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>
Subject: Re: Fix for audio stream XCASE connect:connect failures
Date: Wed, 9 Sep 2009 01:28:39 +0300 [thread overview]
Message-ID: <20090908222839.GA25653@jh-x301> (raw)
In-Reply-To: <4AA6C556.9050804@charter.net>
Hi Peter,
On Tue, Sep 08, 2009, Peter Hurley wrote:
..lots of great analysis snipped..
> Comments?
That's some really nice analysis of the situation you've done. The chosen
solution seems like the best one and and patch looks good too. Could you
still do the following so we can get it pushed upstream and you get the
proper credits as the author of the patch:
- Use /* .. */ for comments instead of //
- Make sure your lines are max 80 columns (e.g. shorten the debug message
or split it into two lines if necessary)
- commit it to your own tree with a descriptive commit message and prepare
a patch using "git format-patch". This way it's easy for me to apply it
using "git am" and e.g. the author field gets correctly preserved.
Thanks.
Johan
next prev parent reply other threads:[~2009-09-08 22:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 20:57 Fix for audio stream XCASE connect:connect failures Peter Hurley
2009-09-08 22:28 ` Johan Hedberg [this message]
2009-09-09 12:32 ` Luiz Augusto von Dentz
2009-09-09 15:49 ` Peter Hurley
2009-09-09 17:25 ` [PATCH 1/1] Fixed duplicate attempt from device to connect 'signalling' channel Peter Hurley
2009-09-09 17:55 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090908222839.GA25653@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=phurley@charter.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox