From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Peter Hurley <phurley@charter.net>,
linux-bluetooth <linux-bluetooth@vger.kernel.org>
Subject: Re: Fix for audio stream XCASE connect:connect failures
Date: Wed, 9 Sep 2009 09:32:36 -0300 [thread overview]
Message-ID: <2d5a2c100909090532o3475a23fs3a0e3c10d78713af@mail.gmail.com> (raw)
In-Reply-To: <20090908222839.GA25653@jh-x301>
Hi,
On Tue, Sep 8, 2009 at 7:28 PM, Johan Hedberg <johan.hedberg@gmail.com> wrote:
> - Use /* .. */ for comments instead of //
> - Make sure your lines are max 80 columns (e.g. shorten the debug message
> or split it into two lines if necessary)
> - commit it to your own tree with a descriptive commit message and prepare
> a patch using "git format-patch". This way it's easy for me to apply it
> using "git am" and e.g. the author field gets correctly preserved.
>
Besides this it seems pretty good, please also make sure the DBus
signals are right, which in this case means we shouldn't emit
disconnected when dropping the second connection attempt, you can use
dbus-monitor --system sender='org.bluez'.
Regards,
--
Luiz Augusto von Dentz
Engenheiro de Computação
next prev parent reply other threads:[~2009-09-09 12:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 20:57 Fix for audio stream XCASE connect:connect failures Peter Hurley
2009-09-08 22:28 ` Johan Hedberg
2009-09-09 12:32 ` Luiz Augusto von Dentz [this message]
2009-09-09 15:49 ` Peter Hurley
2009-09-09 17:25 ` [PATCH 1/1] Fixed duplicate attempt from device to connect 'signalling' channel Peter Hurley
2009-09-09 17:55 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d5a2c100909090532o3475a23fs3a0e3c10d78713af@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=phurley@charter.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox